Update TrustedXFF to use core's StaticArrayWriter implementation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Dec 20 2018, 9:46 PM

Description

MediaWiki core has a StaticArrayWriter class as of T200626: Standardize on a single PHP static array writer implementation. TrustedXFF's generate script needs to be updated to use it instead of rolling its own.

Details

	Subject	Repo	Branch	Lines +/-
	Move trusted-hosts.php artefact from wmf-config to extension repo	mediawiki/extensions/TrustedXFF	master	+194 -348

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T212460 Adopt static array files for local disk storage of values (epic)
		Resolved		Krinkle	T212461 Update TrustedXFF to use core's StaticArrayWriter implementation

Event Timeline

Legoktm created this task.Dec 20 2018, 9:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2018, 9:46 PM

Krinkle added a parent task: T212460: Adopt static array files for local disk storage of values (epic).Dec 20 2018, 9:52 PM

Krinkle added a project: Technical-Debt.Feb 22 2020, 1:22 AM

Krinkle moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.

Krinkle added projects: patch-welcome, Performance-Team.

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.May 20 2020, 5:25 PM

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.

Change 605714 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TrustedXFF@master] Move trusted-hosts.php artefact from wmf-config to extension repo

https://gerrit.wikimedia.org/r/605714

gerritbot added a project: Patch-For-Review.Jun 16 2020, 1:32 AM

Krinkle claimed this task.Jun 16 2020, 1:33 AM

Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar), patch-welcome.

Krinkle moved this task from Backlog: Maintenance, non-prioritized to Blocked (old) on the Performance-Team board.

Krinkle triaged this task as Low priority.Jun 16 2020, 4:42 PM

Krinkle closed this task as Resolved.Jun 24 2020, 1:15 AM

Change 605714 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@master] Move trusted-hosts.php artefact from wmf-config to extension repo

https://gerrit.wikimedia.org/r/605714

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 24 2020, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2020, 2:10 AM

Urbanecm mentioned this in T298243: Finish removal of wgTrustedXffFile .Dec 23 2021, 1:38 PM