Page MenuHomePhabricator
Create Task
Maniphest T200626

Standardize on a single PHP static array writer implementation
Closed, ResolvedPublic
Actions

Description

There's an implementation in SyntaxHighlight, TrustedXFF, and core's LCStoreStaticArray. They all differ slightly, and given that we're moving away from CDB to static PHP arrays, we should have a single implementation in core that can be reused.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jul 28 2018, 10:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2018, 10:58 PM
Reedy subscribed.Jul 29 2018, 12:42 AM

Is this something that might be worth implementing straight as a vendored package?

gerritbot subscribed.Jul 29 2018, 12:47 AM

Change 448992 had a related patch set uploaded (by Krinkle; owner: Reedy):
[mediawiki/extensions/TrustedXFF@master] Run str_replace on a string

https://gerrit.wikimedia.org/r/448992

gerritbot added a project: Patch-For-Review.Jul 29 2018, 12:47 AM
Krinkle awarded a token.Jul 29 2018, 12:47 AM
gerritbot added a comment.Jul 29 2018, 12:47 AM

Change 448993 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TrustedXFF@REL1_31] Run str_replace on a string

https://gerrit.wikimedia.org/r/448993

gerritbot added a comment.Jul 29 2018, 12:48 AM

Change 448994 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TrustedXFF@REL1_30] Run str_replace on a string

https://gerrit.wikimedia.org/r/448994

gerritbot added a comment.Jul 29 2018, 12:49 AM

Change 448992 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@master] Run str_replace on a string

https://gerrit.wikimedia.org/r/448992

gerritbot added a comment.Jul 29 2018, 12:49 AM

Change 448993 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@REL1_31] Run str_replace on a string

https://gerrit.wikimedia.org/r/448993

gerritbot added a comment.Jul 29 2018, 12:50 AM

Change 448994 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@REL1_30] Run str_replace on a string

https://gerrit.wikimedia.org/r/448994

Reedy updated the task description. (Show Details)Jul 29 2018, 12:51 AM
Reedy removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 29 2018, 1:00 AM
Krinkle subscribed.Jul 29 2018, 1:05 AM

There's an implementation in SyntaxHighlight, TrustedXFF, and core's LCStaticArray.

Also mediawiki-extensions-WikimediaMaintenance:/dumpInterwiki.php, and as of recent wfMakeStaticArrayFile() in MediaWiki core as used by maintenance/generateNormalizerDataMl.php.

Krinkle added a project: Librarization.Jul 29 2018, 1:06 AM
Legoktm added a comment.Jul 29 2018, 4:12 AM

Oh, I forgot about wfMakeStaticArrayFile. I think that meets my needs. Theoretically we could put it in the cdb library to match \Cdb\Reader\Hash, but that seems weird since it has nothing to do with cdb.

gerritbot added a comment.Jul 29 2018, 4:30 AM

Change 449000 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Use wfMakeStaticArrayFile()

https://gerrit.wikimedia.org/r/449000

gerritbot added a project: Patch-For-Review.Jul 29 2018, 4:30 AM
gerritbot added a comment.Jul 29 2018, 5:02 AM

Change 449001 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[cdb@master] Add Cdb\Writer\Hash implementation

https://gerrit.wikimedia.org/r/449001

Legoktm renamed this task from Put a PHP static array writer implementation into MediaWiki core to Standardize on a single PHP static array writer implementation.Jul 29 2018, 5:02 AM
gerritbot added a comment.Aug 1 2018, 7:29 PM

Change 449000 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Use wfMakeStaticArrayFile()

https://gerrit.wikimedia.org/r/449000

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)); removed MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Aug 1 2018, 8:01 PM
Legoktm added a project: MW-1.32-release.Aug 2 2018, 2:21 AM

Tagging as a 1.32 release blocker to clarify on whether we want to librarize this (in cdb, or maybe something else) or whether we're ok with wfMakeStaticArrayFile() becoming a stable interface.

Krinkle added a comment.Aug 2 2018, 4:37 AM

@Legoktm Aye, I apologise for including a new global function in 2018. It looked so nice alongside the wfGetPrecompiledData() function I was replacing at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/434040/6/includes/GlobalFunctions.php.

Let's at least make it an autoloaded class rather than a global function before this becomes a stable release.

Krinkle moved this task from Untriaged to To Do on the Librarization board.Aug 12 2018, 12:43 PM
gerritbot added a comment.Aug 18 2018, 5:33 AM

Change 453567 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Move wfMakeStaticArrayFile() into a class

https://gerrit.wikimedia.org/r/453567

gerritbot added a comment.Aug 18 2018, 5:33 AM

Change 453568 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] [WIP] Remove wfMakeStaticArrayFile()

https://gerrit.wikimedia.org/r/453568

gerritbot added a comment.Aug 18 2018, 5:34 AM

Change 453569 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Use StaticArrayWriter class

https://gerrit.wikimedia.org/r/453569

gerritbot added a comment.Aug 18 2018, 5:35 AM

Change 453570 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SecureLinkFixer@master] Use StaticArrayWriter class

https://gerrit.wikimedia.org/r/453570

Legoktm mentioned this in rESLF1a14b66fef5c: Use StaticArrayWriter class.Aug 18 2018, 5:39 AM
Legoktm mentioned this in rESLF6fa4aa9d3cf5: Use StaticArrayWriter class.
gerritbot added a comment.Aug 18 2018, 6:25 AM

Change 453567 merged by jenkins-bot:
[mediawiki/core@master] Move wfMakeStaticArrayFile() into a class

https://gerrit.wikimedia.org/r/453567

gerritbot added a comment.Aug 18 2018, 6:25 AM

Change 453570 merged by jenkins-bot:
[mediawiki/extensions/SecureLinkFixer@master] Use StaticArrayWriter class

https://gerrit.wikimedia.org/r/453570

gerritbot added a comment.Aug 18 2018, 6:25 AM

Change 453569 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Use StaticArrayWriter class

https://gerrit.wikimedia.org/r/453569

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 18 2018, 7:00 AM
gerritbot added a comment.Aug 18 2018, 7:15 AM

Change 453568 merged by jenkins-bot:
[mediawiki/core@master] Remove wfMakeStaticArrayFile()

https://gerrit.wikimedia.org/r/453568

Legoktm claimed this task.Aug 19 2018, 9:56 AM
gerritbot added a comment.Aug 19 2018, 10:18 AM

Change 453674 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Support nested arrays in StaticArrayWriter

https://gerrit.wikimedia.org/r/453674

gerritbot added a comment.Aug 19 2018, 10:18 AM

Change 453675 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Use StaticArrayWriter in LCStoreStaticArray

https://gerrit.wikimedia.org/r/453675

gerritbot added a comment.Aug 27 2018, 10:53 PM

Change 453674 merged by jenkins-bot:
[mediawiki/core@master] Support nested arrays in StaticArrayWriter

https://gerrit.wikimedia.org/r/453674

gerritbot added a comment.Aug 27 2018, 10:54 PM

Change 453675 merged by jenkins-bot:
[mediawiki/core@master] Use StaticArrayWriter in LCStoreStaticArray

https://gerrit.wikimedia.org/r/453675

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 27 2018, 11:00 PM
Krinkle triaged this task as Medium priority.Sep 2 2018, 12:58 AM
gerritbot added a comment.Sep 3 2018, 6:08 AM

Change 449001 abandoned by Legoktm:
Add Cdb\Writer\Hash implementation

Reason:
Not going in this direction

https://gerrit.wikimedia.org/r/449001

Jdforrester-WMF removed a project: Patch-For-Review.Oct 5 2018, 10:41 PM
Jdforrester-WMF subscribed.

No open patchsets FWICS.

Legoktm added a comment.Oct 8 2018, 2:42 AM

The last implementation that needed porting is TrustedXFF.

daniel subscribed.Dec 17 2018, 12:42 PM

This is marked as a release blocker. What's still needed here?

Krinkle added a comment.Dec 20 2018, 9:35 PM

Looks like TrustedXFF still has its own version of StaticArrayWriter. I didn't realise the class names clashed, that's odd.

Legoktm closed this task as Resolved.Dec 20 2018, 9:39 PM

TrustedXFF isn't a bundled extension, so it shouldn't be a release blocker. I'll file a separate bug for that since I think it needs more work than just this part.

Legoktm mentioned this in T212461: Update TrustedXFF to use core's StaticArrayWriter implementation.Dec 20 2018, 9:46 PM
Krinkle added a parent task: T212460: Adopt static array files for local disk storage of values (epic).Dec 20 2018, 9:51 PM
DannyS712 mentioned this in T254133: Move StaticArrayWriter to a stand-alone library.Jun 1 2020, 8:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits