Page MenuHomePhabricator

Fix nullability of column recentchanges.rc_params on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

Mismatching field nullability of recentchanges.rc_params

on s1, s2

The field was set to nullable with rMW79eb0fe88d35aac3dce2b6fbefc652b123414066

There is no ready ALTER statement in the commit history.

ALTER TABLE /*_*/recentchanges
  CHANGE rc_params rc_params BLOB DEFAULT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s1, s2 - list of wikis needs to be created
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress

  • s1
  • s2

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Marostegui triaged this task as Medium priority.Mon, Jan 3, 6:05 AM
Marostegui moved this task from Triage to Ready on the DBA board.
Marostegui added subscribers: Ladsgroup, Marostegui.

@Ladsgroup let's use the autodiscovery for this schema change. I will start once I have finished the two we have on-going at the moment (hopefully in the next few days).

I am running this change with the autodiscovery mode on s2.

Mentioned in SAL (#wikimedia-operations) [2022-01-04T06:37:15Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1105:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18339 and previous config saved to /var/cache/conftool/dbconfig/20220104-063714-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T06:59:42Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18340 and previous config saved to /var/cache/conftool/dbconfig/20220104-065942-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T07:44:56Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18344 and previous config saved to /var/cache/conftool/dbconfig/20220104-074456-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T08:00:52Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1170:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18346 and previous config saved to /var/cache/conftool/dbconfig/20220104-080051-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T08:06:04Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1170:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18347 and previous config saved to /var/cache/conftool/dbconfig/20220104-080604-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T08:51:20Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1170:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18353 and previous config saved to /var/cache/conftool/dbconfig/20220104-085118-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T08:51:27Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1146:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18354 and previous config saved to /var/cache/conftool/dbconfig/20220104-085127-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T09:04:06Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1146:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18355 and previous config saved to /var/cache/conftool/dbconfig/20220104-090406-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T09:49:20Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1146:3312 (T298316)', diff saved to https://phabricator.wikimedia.org/P18358 and previous config saved to /var/cache/conftool/dbconfig/20220104-094920-marostegui.json

The change has finished on all s2 slaves without any issues with the auto-discovery :-)
I am going to run it on the master manually now.
Once done, I will start with s1.

Started the schema change on s1 with auto-discovery. The dry run looked good.

Mentioned in SAL (#wikimedia-operations) [2022-01-04T10:52:44Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1099:3311 (T298316)', diff saved to https://phabricator.wikimedia.org/P18364 and previous config saved to /var/cache/conftool/dbconfig/20220104-105244-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T10:59:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T298316)', diff saved to https://phabricator.wikimedia.org/P18367 and previous config saved to /var/cache/conftool/dbconfig/20220104-105949-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T11:45:04Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T298316)', diff saved to https://phabricator.wikimedia.org/P18370 and previous config saved to /var/cache/conftool/dbconfig/20220104-114503-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T12:16:43Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1105:3311 (T298316)', diff saved to https://phabricator.wikimedia.org/P18372 and previous config saved to /var/cache/conftool/dbconfig/20220104-121643-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T12:23:03Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T298316)', diff saved to https://phabricator.wikimedia.org/P18373 and previous config saved to /var/cache/conftool/dbconfig/20220104-122302-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-04T13:08:17Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T298316)', diff saved to https://phabricator.wikimedia.org/P18378 and previous config saved to /var/cache/conftool/dbconfig/20220104-130816-marostegui.json

All s1 slaves done, proceeding manually with the master now

enwiki fully done.

Resolving this