Page MenuHomePhabricator

File history and Special:ListFiles should use a dedicated table generator
Open, MediumPublic


On an ImagePage the file histroy shows Dimensions and Size in one column.

On Special:ListFiles only the Size is shown.

Please add the Dimensions to Special:ListFiles (maybe to column Size and change the header).


Version: unspecified
Severity: major



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:32 PM
bzimport set Reference to bz27850.
bzimport added a subscriber: Unknown Object (MLST).

usertoollinks on Special:ListFiles for the uploader are also nice. Thanks.

Table should probably be put in a class to reduce code duplication and number of messages.

Reedy added a comment.Mar 5 2011, 5:46 PM

<Reedy> Typical MW, we do one thing one way, and the same thing a different way in another feature
<BryanTM> Reedy: TablePager is a horrible interface that mixes querying with presentation
<Reedy> :D
<Reedy> I noes
<BryanTM> (same for QueryPage and all other Pagers)

I normalised the ordering of the columns a bit in r83301

We could migrate the column names and reuse messages (can we get away with that..?), as there's some difference between them.

(With regards to what Siebrand was wanting to do. Maybe he can say whether we can reuse the messages as they are for essentially the same usage)

As for the actual request, the file stuff is all over the place, and i'm not sure on the sanest way to add the actual output of the dimensions.

Bryan.TongMinh wrote:

Another note, Special:ListFiles does not support RevDel. This would be fixed by a dedicated ImageTable generator.

Bumping importance.

(In reply to comment #4)

Another note, Special:ListFiles does not support RevDel.

That is not needed, because RevDel does not support the current version of an image (bug 20742)

Scott added a comment.Jan 17 2013, 8:41 PM

I was going to file a separate bug for this but it seems like it would be best put here - as the table cells in the file history have justified text alignment, the Dimensions cell ends up looking like this:

2,396 ×
(2.17 MB)

Short of specifying an explicit width for this column, this could be fixed by using non-breaking spaces around the multiplication symbol.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2015, 6:14 PM