Page MenuHomePhabricator

Fix mismatching field type of oldimage.oi_timestamp on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

Mismatching field type of oldimage.oi_timestamp

on s1, s2, s3, s4, s7

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.
The column was added in d82c14fb4fbac288b42ca5918b0a72f33ecb1e69#change-pVGjpnYAcwz0

There is no ready ALTER statement in the commit history.

ALTER TABLE /*_*/oldimage
  CHANGE oi_timestamp oi_timestamp BINARY(14) NOT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s1, s2, s3, s4, s7 - list of wikis needs to be created
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

s4 is fully done, only pending the master. The table is quite big there, so we cannot do the master online

s4 old master, db1138 done

Mentioned in SAL (#wikimedia-operations) [2022-04-26T15:30:39Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26557 and previous config saved to /var/cache/conftool/dbconfig/20220426-153039-ladsgroup.json

Ladsgroup moved this task from Done to In progress on the DBA board.
Ladsgroup subscribed.

This is still needed in s5 and s6 which didn't show up in the original report given the fact that it picks up a wiki at random (in order to avoid s3 ruining the report). I do it.

Mentioned in SAL (#wikimedia-operations) [2022-04-26T15:32:53Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26558 and previous config saved to /var/cache/conftool/dbconfig/20220426-153253-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T16:18:08Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26566 and previous config saved to /var/cache/conftool/dbconfig/20220426-161808-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T16:18:18Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1144:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26567 and previous config saved to /var/cache/conftool/dbconfig/20220426-161816-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T16:20:30Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26568 and previous config saved to /var/cache/conftool/dbconfig/20220426-162029-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T17:05:45Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26576 and previous config saved to /var/cache/conftool/dbconfig/20220426-170545-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T17:06:01Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1110 (T298556)', diff saved to https://phabricator.wikimedia.org/P26577 and previous config saved to /var/cache/conftool/dbconfig/20220426-170553-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T17:08:07Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298556)', diff saved to https://phabricator.wikimedia.org/P26578 and previous config saved to /var/cache/conftool/dbconfig/20220426-170807-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T17:53:22Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298556)', diff saved to https://phabricator.wikimedia.org/P26587 and previous config saved to /var/cache/conftool/dbconfig/20220426-175322-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T17:54:27Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1130 (T298556)', diff saved to https://phabricator.wikimedia.org/P26588 and previous config saved to /var/cache/conftool/dbconfig/20220426-175424-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T17:55:37Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1130 (T298556)', diff saved to https://phabricator.wikimedia.org/P26589 and previous config saved to /var/cache/conftool/dbconfig/20220426-175536-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T18:41:01Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26595 and previous config saved to /var/cache/conftool/dbconfig/20220426-184058-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T18:43:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26596 and previous config saved to /var/cache/conftool/dbconfig/20220426-184313-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T19:28:29Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298556)', diff saved to https://phabricator.wikimedia.org/P26605 and previous config saved to /var/cache/conftool/dbconfig/20220426-192828-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T19:28:51Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1161 (T298556)', diff saved to https://phabricator.wikimedia.org/P26606 and previous config saved to /var/cache/conftool/dbconfig/20220426-192841-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T19:30:55Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298556)', diff saved to https://phabricator.wikimedia.org/P26607 and previous config saved to /var/cache/conftool/dbconfig/20220426-193055-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T20:16:11Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298556)', diff saved to https://phabricator.wikimedia.org/P26616 and previous config saved to /var/cache/conftool/dbconfig/20220426-201610-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T22:53:29Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26636 and previous config saved to /var/cache/conftool/dbconfig/20220426-225326-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T22:54:38Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26637 and previous config saved to /var/cache/conftool/dbconfig/20220426-225437-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T23:39:53Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26645 and previous config saved to /var/cache/conftool/dbconfig/20220426-233953-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-26T23:40:06Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1180 (T298556)', diff saved to https://phabricator.wikimedia.org/P26646 and previous config saved to /var/cache/conftool/dbconfig/20220426-234000-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T00:40:15Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298556)', diff saved to https://phabricator.wikimedia.org/P26653 and previous config saved to /var/cache/conftool/dbconfig/20220427-004015-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T01:25:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298556)', diff saved to https://phabricator.wikimedia.org/P26659 and previous config saved to /var/cache/conftool/dbconfig/20220427-012530-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T01:25:45Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1098:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26660 and previous config saved to /var/cache/conftool/dbconfig/20220427-012538-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T01:28:50Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26661 and previous config saved to /var/cache/conftool/dbconfig/20220427-012850-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T02:14:05Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26667 and previous config saved to /var/cache/conftool/dbconfig/20220427-021405-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T02:14:52Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26668 and previous config saved to /var/cache/conftool/dbconfig/20220427-021450-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T02:17:02Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26669 and previous config saved to /var/cache/conftool/dbconfig/20220427-021702-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T03:02:18Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298556)', diff saved to https://phabricator.wikimedia.org/P26675 and previous config saved to /var/cache/conftool/dbconfig/20220427-030217-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T03:02:32Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1131 (T298556)', diff saved to https://phabricator.wikimedia.org/P26676 and previous config saved to /var/cache/conftool/dbconfig/20220427-030225-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T03:04:33Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1131 (T298556)', diff saved to https://phabricator.wikimedia.org/P26677 and previous config saved to /var/cache/conftool/dbconfig/20220427-030433-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T03:49:48Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1131 (T298556)', diff saved to https://phabricator.wikimedia.org/P26680 and previous config saved to /var/cache/conftool/dbconfig/20220427-034948-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T03:50:11Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1165 (T298556)', diff saved to https://phabricator.wikimedia.org/P26681 and previous config saved to /var/cache/conftool/dbconfig/20220427-035001-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T03:52:09Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298556)', diff saved to https://phabricator.wikimedia.org/P26682 and previous config saved to /var/cache/conftool/dbconfig/20220427-035208-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T04:37:25Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298556)', diff saved to https://phabricator.wikimedia.org/P26685 and previous config saved to /var/cache/conftool/dbconfig/20220427-043724-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T04:37:40Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1168 (T298556)', diff saved to https://phabricator.wikimedia.org/P26686 and previous config saved to /var/cache/conftool/dbconfig/20220427-043732-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T04:40:41Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298556)', diff saved to https://phabricator.wikimedia.org/P26687 and previous config saved to /var/cache/conftool/dbconfig/20220427-044040-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T05:25:56Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298556)', diff saved to https://phabricator.wikimedia.org/P26692 and previous config saved to /var/cache/conftool/dbconfig/20220427-052555-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T12:47:27Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1180 (T298556)', diff saved to https://phabricator.wikimedia.org/P26708 and previous config saved to /var/cache/conftool/dbconfig/20220427-124714-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T12:50:22Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298556)', diff saved to https://phabricator.wikimedia.org/P26709 and previous config saved to /var/cache/conftool/dbconfig/20220427-125022-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T13:35:37Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298556)', diff saved to https://phabricator.wikimedia.org/P26718 and previous config saved to /var/cache/conftool/dbconfig/20220427-133537-ladsgroup.json

Ladsgroup updated the task description. (Show Details)

Done in s5 and s6 including masters.