Maniphest T298564

Add support for using ipv6 address for memcached
Closed, ResolvedPublic
Actions

Description

Here https://github.com/miraheze/mediawiki/blob/REL1_37/includes/libs/objectcache/utils/MemcachedClient.php#L788 does not support ipv6.

ip-utils provides a method which could be used:

splitHostAndPort( $ip_and_port )

so this could become

$server = splitHostAndPort( $ip_and_port )
if ($server === false || !isset( $server[1] )) return false;
$ip = $server[0];
$port = $server[1];

I think ?

Details

	Subject	Repo	Branch	Lines +/-
	MemcachedClient: Add support for ipv6	mediawiki/core	REL1_37	+23 -3
	MemcachedClient: Add support for ipv6	mediawiki/core	REL1_36	+23 -3
	MemcachedClient: Add support for ipv6	mediawiki/core	REL1_35	+23 -3
	MemcachedClient: Add support for ipv6	mediawiki/core	master	+23 -3

Customize query in gerrit

Related Objects

Mentioned In: T320707: Cannot log in from MW1.35.8 or 1.35.6 with memcached (port number in $wgMemCachedServers changed from string to integer)

Event Timeline

Paladox created this task.Jan 4 2022, 8:16 PM

Restricted Application added projects: Performance-Team, User-RhinosF1. · View Herald TranscriptJan 4 2022, 8:16 PM

Restricted Application added subscribers: Reception123, Aklapper. · View Herald Transcript

Paladox updated the task description. (Show Details)Jan 4 2022, 8:25 PM

Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.Jan 4 2022, 8:59 PM

Change 751203 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@master] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/751203

gerritbot added a project: Patch-For-Review.Jan 4 2022, 11:46 PM

Reedy added projects: MW-1.35-release, MW-1.36-release, MW-1.37-release.Jan 5 2022, 12:32 AM

RhinosF1 moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.Jan 7 2022, 11:12 PM

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jan 10 2022, 7:52 PM

Change 751203 merged by jenkins-bot:

[mediawiki/core@master] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/751203

Change 752282 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@REL1_37] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/752282

Change 752283 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@REL1_36] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/752283

Change 752284 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@REL1_35] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/752284

Change 752284 merged by jenkins-bot:

[mediawiki/core@REL1_35] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/752284

Change 752282 merged by jenkins-bot:

[mediawiki/core@REL1_37] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/752282

Paladox closed this task as Resolved.Jan 10 2022, 8:37 PM

Paladox claimed this task.

Change 752283 merged by jenkins-bot:

[mediawiki/core@REL1_36] MemcachedClient: Add support for ipv6

https://gerrit.wikimedia.org/r/752283

ReleaseTaggerBot added projects: MW-1.36-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MW-1.37-notes.Jan 10 2022, 9:00 PM

Maintenance_bot moved this task from Miraheze-Linked to Done on the User-RhinosF1 board.Jan 10 2022, 9:15 PM

Reedy reopened this task as Open.Jan 10 2022, 9:37 PM

Reedy closed this task as Resolved.

Reedy triaged this task as Low priority.

Reedy edited projects, added IPv6; removed Patch-For-Review.

taavi mentioned this in T320707: Cannot log in from MW1.35.8 or 1.35.6 with memcached (port number in $wgMemCachedServers changed from string to integer).Oct 13 2022, 10:44 AM