Maniphest T298598

Apply correct spacing and positioning on function heading
Closed, ResolvedPublic
Actions

Assigned To

• AdesojiThisDot

Authored By

	SimoneThisDot
	Jan 5 2022, 10:26 AM

Tags

Referenced Files

	F34908146: image.png
	Jan 5 2022, 10:26 AM

Subscribers

Jdforrester-WMF

Description

The current function editor heading is spread across the top, we should change this to align with the designs (left aligned)

Align the heading to the left
Ensure bottom and right margin of each tab is correct
Move the font definition in the new shared file

image.png (539×917 px, 52 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Apply correct spacing and positioning on function heading	mediawiki/extensions/WikiLambda	master	+70 -57

Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Jan 5 2022, 10:26 AM

DVrandecic moved this task from To Triage to Phase η – Generic types on the Abstract Wikipedia team board.Jan 11 2022, 5:24 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.

DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 11 2022, 5:47 PM

• AdesojiThisDot changed the task status from Open to In Progress.Feb 23 2022, 12:19 PM

• AdesojiThisDot claimed this task.

• AdesojiThisDot moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.

Change 765683 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] Apply correct spacing and positioning on function heading

https://gerrit.wikimedia.org/r/765683

gerritbot added a project: Patch-For-Review.Feb 25 2022, 8:01 AM

Jdforrester-WMF moved this task from In progress to Code Review on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 25 2022, 3:51 PM

Change 765683 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Apply correct spacing and positioning on function heading

https://gerrit.wikimedia.org/r/765683

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 25 2022, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2022, 7:10 PM

• AdesojiThisDot moved this task from Code Review to Design Review on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 28 2022, 11:43 AM

• aishwaryavardhana moved this task from Design Review to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 17 2022, 12:26 AM

Design sign off -> this is good to close.