Page MenuHomePhabricator

Wikidiff2 doesn't show differences for template changes
Closed, ResolvedPublic

Details

Reference
bz27993

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:29 PM
bzimport added a project: wikidiff2.
bzimport set Reference to bz27993.

Can't reproduce. Try recompiling.

Didn't seem to help. I added a test that fails for me in r83872.

Libraries have been installed in:

/www/sandwiki/extensions/wikidiff2/modules

If you ever happen to want to link against installed libraries

in a given directory, [...]

Build complete.
Don't forget to run 'make test'.

PHP : /usr/bin/php
PHP_SAPI : cli
PHP_VERSION : 5.3.2-1ubuntu4.7
ZEND_VERSION: 2.3.0
PHP_OS : Linux - Linux v22011026445052.yourvserver.net 2.6.35.11-vs2.3.0.36.33-netcup #1 SMP Mon Feb 7 08:00:09 UTC 2011 x86_64
INI actual : /www/sandwiki/extensions/wikidiff2/tmp-php.ini
More .INIs :
CWD : /www/sandwiki/extensions/wikidiff2
Extra dirs :

VALGRIND : Not used

TIME START 2011-03-14 07:38:44

FAIL Diff test A [tests/001.phpt]
PASS Diff test B [tests/002.phpt]

FAIL Diff test C: https://bugzilla.wikimedia.org/show_bug.cgi?id=27993 [tests/003.phpt]

TIME END 2011-03-14 07:38:44

cat tests/003.diff
007+ <td class="diff-deletedline"><div></div></td>
007- <td class="diff-deletedline"><div>FUZZYRajaa</div></td>
009+ <td class="diff-addedline"><div></div></td>
009- <td class="diff-addedline"><div>Rajaa</div></td

Tests pass and broken diffs show correctly after purging.