Page MenuHomePhabricator

Docker compose names don't fit again
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • I am on Docker compose v2.2.3
  • I install a new local Wikifunctions

What happens?:
extensions/WikiLambda/extension.json looks for mediawiki_function-orchestrator_1 and mediawiki_function-evaluator_1, but the instances are called mediawiki-function-orchestrator-1 and mediawiki-function-evaluator-1

What should have happened instead?:
The names should be consistent

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

As of January 25.
This is a regression. I assume this is because Docker Compose behavior keeps switching around.

Event Timeline

Sound familier https://gitlab.wikimedia.org/repos/releng/cli/-/commit/2f6c6dbe41135062ba556e68168794d9ad5c7051

A change between v1 and v2 of docker-compose meant that
container names moves from using _s to -s for their parts.

You probably shouldn't rely on these "service names" at all if they have -s or _s in them
https://github.com/wikimedia/mediawiki-extensions-WikiLambda/blob/master/extension.json#L35

You can make use of alises and avoid the _s and -s https://docs.docker.com/compose/compose-file/compose-file-v3/#aliases

Change 767601 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] extension: Update orchestrator/evaluator docker-compose defaults yet again

https://gerrit.wikimedia.org/r/767601

Change 767601 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] extension: Update orchestrator/evaluator docker-compose defaults yet again

https://gerrit.wikimedia.org/r/767601