Page MenuHomePhabricator

User CSS/JS removes _ from page skin name
Closed, InvalidPublic

Description

Author: joshua.a.dickerson

Description:
The user CSS/JS file names are being stripped of the underscores making them useless. The only way to change that is by removing the underscore from the skin name, but that makes it harder to read. It should work with any PHP and URL allowed characters.

smf_curve.css gets rewritten as smfcurve.css but the skin name is smf_curve.


Version: unspecified
Severity: normal

Details

Reference
bz28035

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:32 PM
bzimport set Reference to bz28035.
bzimport added a subscriber: Unknown Object (MLST).

I don't seem to be encountering such a problem testing locally on trunk, r85093. I created a copy of the 'Simple' skin called 'Simple_foo' and edited my matching pages (sample URLs included):

http://lazarus.local/trunk/index.php/Uzanto:WikiSysop/simple_foo.css
http://lazarus.local/trunk/index.php/Uzanto:WikiSysop/simple_foo.js

by following the links from the prefs page.

Both appear to work ok.

Can you clarify what you mean by 'stripped' and 'rewritten'? Is this something that happens specifically to smf_curve or to other skins?

DannyS712 subscribed.

Still no reply, can't be reproduced, setting as invalid