Maniphest T300439

Reply tool sometimes adds unnecessary empty lines in multi-paragraph replies
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jan 29 2022, 5:41 PM

Tags

Referenced Files

	F34944592: Screenshot 2022-02-07 at 18.43.21.png
	Feb 7 2022, 5:48 PM

	F34944598: Screenshot 2022-02-07 at 18.45.56.png
	Feb 7 2022, 5:48 PM

Subscribers

Description

As seen here: https://en.wikisource.org/w/index.php?title=User_talk:Matma_Rex&diff=12108727&oldid=12108300 the reply tool sometimes adds unnecessary empty lines in multi-paragraph replies.

Steps to reproduce:

Type the following reply in source mode:

a
<blockquote>x</blockquote>
b

Switch to visual
Click "Reply"

Result: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:T300439&diff=535937&oldid=535936&diffmode=source
Expected: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:T300439&diff=535938&oldid=535937&diffmode=source

Details

	Subject	Repo	Branch	Lines +/-
	Remove empty lines in visual mode in some more cases	mediawiki/extensions/DiscussionTools	master	+7 -3

Customize query in gerrit

Event Timeline

matmarex created this task.Jan 29 2022, 5:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2022, 5:41 PM

matmarex updated the task description. (Show Details)Jan 29 2022, 5:43 PM

matmarex claimed this task.Jan 29 2022, 5:50 PM

Change 758051 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove empty lines in visual mode in some more cases

https://gerrit.wikimedia.org/r/758051

gerritbot added a project: Patch-For-Review.Jan 29 2022, 5:54 PM

Change 758051 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove empty lines in visual mode in some more cases

https://gerrit.wikimedia.org/r/758051

matmarex added a project: Editing-team (Kanban Board).Feb 2 2022, 5:39 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

matmarex edited projects, added Editing QA; removed Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 2 2022, 6:00 PM

The reply tool shows multi-paragraph replies without empty lines. i.e the replies are displayed as is.

Screenshot 2022-02-07 at 18.45.56.png (826×2 px, 166 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Feb 7 2022, 5:48 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Feb 9 2022, 3:00 AM