Page MenuHomePhabricator

Reply tool sometimes adds unnecessary empty lines in multi-paragraph replies
Closed, ResolvedPublic

Description

As seen here: https://en.wikisource.org/w/index.php?title=User_talk:Matma_Rex&diff=12108727&oldid=12108300 the reply tool sometimes adds unnecessary empty lines in multi-paragraph replies.

Steps to reproduce:

  1. Type the following reply in source mode:
a
<blockquote>x</blockquote>
b
  1. Switch to visual
  2. Click "Reply"

Result: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:T300439&diff=535937&oldid=535936&diffmode=source
Expected: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:T300439&diff=535938&oldid=535937&diffmode=source

Event Timeline

Change 758051 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove empty lines in visual mode in some more cases

https://gerrit.wikimedia.org/r/758051

Change 758051 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove empty lines in visual mode in some more cases

https://gerrit.wikimedia.org/r/758051

The reply tool shows multi-paragraph replies without empty lines. i.e the replies are displayed as is.

Screenshot 2022-02-07 at 18.45.56.png (826×2 px, 166 KB)

Screenshot 2022-02-07 at 18.43.21.png (554×2 px, 116 KB)