Wikimedia\ParamValidator\ValidationException : Validation of `test` failed: baduser
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	kostajh
	Feb 1 2022, 8:13 PM

Description

I get this error when running vendor/bin/phpunit core:unit:

There was 1 error:

1) MediaWiki\ParamValidator\TypeDef\UserDefTest::testValidate with data set "T232672: U+200E at position 0 for name" ('Emma', 'Emma')
Wikimedia\ParamValidator\ValidationException: Validation of `test` failed: baduser

/Users/kostajh/src/mediawiki/w/includes/libs/ParamValidator/TypeDef.php:66
/Users/kostajh/src/mediawiki/w/includes/ParamValidator/TypeDef/UserDef.php:88
/Users/kostajh/src/mediawiki/w/tests/phpunit/unit/includes/libs/ParamValidator/TypeDef/TypeDefTestCase.php:89

It looks like the test case that fails was touched last in rMW9308ee9cf881: UserDef: no need to return full User objects (cc @DannyS712). This passes in CI, so I guess it is something specific to my macOS PHP 7.4 local setup?

Details

	Subject	Repo	Branch	Lines +/-
	TypeDefTestCase: Skip test on non-Linux environment	mediawiki/core	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T313486: Daylight savings unit test failures on Microsoft Windows
Mentioned Here: rMW9308ee9cf881: UserDef: no need to return full User objects

Event Timeline

kostajh created this task.Feb 1 2022, 8:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2022, 8:13 PM

Google suggests that the character found is a left to right marker - is your local language not English? Otherwise, my only idea is to remove and redownload the file in case there was some accidental drift that git ignores

In T300669#7669940, @DannyS712 wrote:

Google suggests that the character found is a left to right marker - is your local language not English?

My LocalSettings.php is en and my OS (macOS) is using English. But that shouldn't affect what is happening in this test?

Otherwise, my only idea is to remove and redownload the file in case there was some accidental drift that git ignores

Sorry, which file?

In T300669#7707948, @kostajh wrote:

In T300669#7669940, @DannyS712 wrote:

Google suggests that the character found is a left to right marker - is your local language not English?

My LocalSettings.php is en and my OS (macOS) is using English. But that shouldn't affect what is happening in this test?

Otherwise, my only idea is to remove and redownload the file in case there was some accidental drift that git ignores

Sorry, which file?

the file with this failure, tests/phpunit/unit/includes/ParamValidator/TypeDef/UserDefTest.php

Change 802089 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] TypeDefTestCase: Skip test on non-Linux environment

https://gerrit.wikimedia.org/r/802089

gerritbot added a project: Patch-For-Review.Jun 1 2022, 10:22 AM

kostajh mentioned this in T313486: Daylight savings unit test failures on Microsoft Windows.Jul 21 2022, 10:19 AM

No longer reproducible, closing this.

Change 802089 abandoned by Kosta Harlan: