Page MenuHomePhabricator
Create Task
Maniphest T30080

Add configuration option to ArticleFeedback to define namespaces where it is enabled
Closed, ResolvedPublic
Actions

Description

Some wikis have its content in other namespaces besides the main namespace. E.g. English Wikibooks has a "[[b:Cookbook]]" namespace (for recipes) and Portuguese Wikipedia has an "[[pt:Anexo]]" namespace (for lists and other stuff).

As of r83924, ext.articleFeedback.startup.js has the following test:
mw.config.get( 'wgNamespaceNumber', false ) === 0

Instead of this, the extension should check if the the current wgNamespaceNumber is in a predefined list of namespaces (configurable per wiki).

Version: unspecified
Severity: enhancement

Details

Reference
bz28080

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:35 PM
• bzimport added a project: ArticleFeedback.
• bzimport set Reference to bz28080.
He7d3r created this task.Mar 16 2011, 9:17 PM
Peachey88 added a comment.Mar 20 2011, 9:55 AM

(In reply to comment #0)

Instead of this, the extension should check if the the current
wgNamespaceNumber is in a predefined list of namespaces (configurable per
wiki).

"$wgContentNamespaces" might be a good fit, unless you want it to be configurable and be able to choose the namespaces yourself when its setup.

He7d3r added a comment.Mar 20 2011, 10:43 AM

(In reply to comment #1)

"$wgContentNamespaces" might be a good fit, unless you want it to be
configurable and be able to choose the namespaces yourself when its setup.

I think it should use $wgContentNamespaces as default value but still be configurable. This way, if some wiki wants to have feedback about its internal documentation or project pages, they could just add the necessary namespaces (as currently happens on [[wikibooks:pt:]], with ReaderFeedback - bug 26451).

Krinkle added a comment.May 3 2011, 4:46 PM

Using a global variable for this and defaulting to wgContentNamespaces sounds like a sane idea.

I'll implement this soon.

Krinkle added a comment.May 3 2011, 5:11 PM

r87336.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits