Maniphest T301012

Add icon class to icon capable portlet links without an ID
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	BrandonXLF
	Feb 4 2022, 9:46 PM

Tags

Referenced Files

	F34942588: image.png
	Feb 4 2022, 9:46 PM

Subscribers

Description

When an protlet link is added with mw.util.addPortletLink without an ID, it is not aligned with portlet links with an ID. This is because these links are not given the mw-ui-icon and mw-ui-icon-before classes, meaning the margin where the icon would go is never added.

image.png (152×219 px, 3 KB)

In the picture above, "User script" does not have an ID, but "Todo" does.

Details

	Subject	Repo	Branch	Lines +/-
	Add icon classes to portlet links without IDs	mediawiki/skins/Vector	master	+8 -4

Customize query in gerrit

Related Objects

Mentioned In: T334042: All menu items should have a default icon if not specified
T301014: Add icon class to portlet links without IDs

Event Timeline

BrandonXLF created this task.Feb 4 2022, 9:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2022, 9:46 PM

BrandonXLF claimed this task.Feb 4 2022, 9:46 PM

Change 759811 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/skins/Vector@master] Add icon classes to portlet links without IDs

https://gerrit.wikimedia.org/r/759811

gerritbot added a project: Patch-For-Review.Feb 4 2022, 9:51 PM

BrandonXLF mentioned this in T301014: Add icon class to portlet links without IDs.Feb 4 2022, 10:05 PM

Jdlrobson added a project: Web-Team-Backlog.Feb 4 2022, 10:46 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.

ovasileva triaged this task as Medium priority.Feb 8 2022, 3:19 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

Jdlrobson removed BrandonXLF as the assignee of this task.Feb 8 2022, 5:27 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 22 2022, 6:39 PM

LGoto set the point value for this task to 2.Feb 22 2022, 6:39 PM

LGoto moved this task from Code Review to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

When testing we should check ContentTranslation's usage of mw.util.addPortletLink

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 22 2022, 6:39 PM

Jdlrobson claimed this task.Feb 23 2022, 4:23 PM

Change 759811 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add icon classes to portlet links without IDs

https://gerrit.wikimedia.org/r/759811

Jdlrobson closed this task as Resolved.Feb 23 2022, 7:23 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 23 2022, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2022, 8:10 PM

BrandonXLF mentioned this in T334042: All menu items should have a default icon if not specified.Apr 5 2023, 3:36 AM