| BrandonXLF | |
| Apr 5 2023, 3:36 AM |
| F36940385: Screenshot 2023-04-05 at 10.18.44 AM.png | |
| Apr 5 2023, 5:19 PM |
| F34942588: image.png | |
| Apr 5 2023, 3:40 AM |
| Unknown Object (File) | |
| Apr 5 2023, 3:36 AM |
When a protlet link is added with mw.util.addPortletLink without an ID, it is not aligned with portlet links with an ID. This is because the createIconElement is never called for icons without an ID.
In the picture above, "User script" does not have an ID, but "Todo" does.
This is similar to T301012, but is caused by different code.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add an icon to all links for consistent spacing | mediawiki/skins/Vector | master | +8 -6 |
Change 905776 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):
[mediawiki/skins/Vector@master] Add an icon to all links for consistent spacing
@KieranMcCann for gadgets would it make sense to have a default icon, perhaps the labs flask icon to indicate they are gadgets? What do you think?
The 'labFlask' icon is so far used for chemical nodes and contexts in the Math extension and for betalab features.
Removing inactive task assignee. (For future reference, please do so as part of offboarding!)
Change #905776 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] Add an icon to all links for consistent spacing
Reason:
Hello this is an automated message.
I am abandoning this patch as it over a year old, and is not currently in a mergeable state. This has nothing to do with the quality of the patch.
If you still care about this patch, please feel free to restore it and rebase it, and we can happily continue the conversation to help you get it merged.