Page MenuHomePhabricator
Create Task
Maniphest T302597

Increase code coverage of all WikiLambda PHP Registry code to 100% of lines and methods (or marked as ignored if structural)
Open, MediumPublic
Actions

Description

https://doc.wikimedia.org/cover-extensions/WikiLambda/includes/Registry/index.html

  • ZErrorTypeRegistry.php
  • ZLangRegistry.php
  • ZObjectRegistry.php (note: This is abstract so may need to be more generally ignored.)
  • ZTypeRegistry.php

Details

SubjectRepoBranchLines +/-
ZTypeRegistry: Add test coverage of isZFunctionBuiltIn/getZFunctionBuiltInNamemediawiki/extensions/WikiLambdamaster+52 -3
ZTypeRegistry::isZObjectInstanceOfType: Add test for last edge casemediawiki/extensions/WikiLambdamaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 25 2022, 3:59 PM
DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Mar 8 2022, 5:05 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:45 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:37 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
gerritbot added a comment.Mar 20 2023, 3:01 PM

Change 901229 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypeRegistry::isZObjectInstanceOfType: Add test for last edge case

https://gerrit.wikimedia.org/r/901229

gerritbot added a project: Patch-For-Review.Mar 20 2023, 3:01 PM

Change 901230 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypeRegistry: Add test coverage of isZFunctionBuiltIn/getZFunctionBuiltInName

https://gerrit.wikimedia.org/r/901230

gerritbot added a comment.Mar 22 2023, 12:18 AM

Change 901229 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypeRegistry::isZObjectInstanceOfType: Add test for last edge case

https://gerrit.wikimedia.org/r/901229

gerritbot added a comment.Mar 22 2023, 12:31 AM

Change 901230 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypeRegistry: Add test coverage of isZFunctionBuiltIn/getZFunctionBuiltInName

https://gerrit.wikimedia.org/r/901230

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 22 2023, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 22 2023, 1:10 AM
Jdforrester-WMF updated the task description. (Show Details)Mar 22 2023, 3:06 PM
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:04 AM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Apr 18 2024, 4:44 PM
Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.Nov 18 2024, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits