Page MenuHomePhabricator

Replace a story page image
Closed, ResolvedPublic

Assigned To
Authored By
SBisson
Feb 25 2022, 4:17 PM
Referenced Files
F35057131: image.png
Apr 18 2022, 8:35 PM
F35023762: 02 - Overflow menu is active.png
Mar 25 2022, 4:00 PM
F35022033: 02 - Overflow menu is active.png
Mar 24 2022, 7:46 AM
F35022034: 01 - Replace an image.png
Mar 24 2022, 7:46 AM
F35022035: 03 - Select an image to replace.png
Mar 24 2022, 7:46 AM
F35022036: 04 - Image replaced.png
Mar 24 2022, 7:46 AM

Description

Background

Allow users to replace an image while creating a story. Users might consider to replace an image in different scenarios such as previously selected image doesn't fit well with the overall story narrative or they are not happy with the quality of it and want to find a higher resolution version of it.

Design details
Story page to replace imageOverflow menu is active
01 - Replace an image.png (780×360 px, 320 KB)
02 - Overflow menu is active.png (780×360 px, 302 KB)
Select image to replaceImage replaced
03 - Select an image to replace.png (780×360 px, 364 KB)
04 - Image replaced.png (780×360 px, 368 KB)
  • User can access replace image option from an overflow menu on top of the story page.
  • A tap on “Replace image” option would open image selection screen.
  • Don’t show any of the previously selected images.
  • A user is allowed to select only one image.
  • Instantly return back to story page after selecting an image.
  • Story page has an updated image.
  • Text on story page remain unchanged with this action.

Related Objects

Event Timeline

SBisson triaged this task as Medium priority.Feb 25 2022, 4:17 PM

Change 774551 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Replace an image

https://gerrit.wikimedia.org/r/774551

Change 774551 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Replace an image

https://gerrit.wikimedia.org/r/774551

Testing:

AC1: User can access replace image option from an overflow menu on top of the story page. PASSED

AC2: A tap on “Replace image” option would open image selection screen. PASSED

AC3: Don’t show any of the previously selected images. NEEDS WORK
I can see and choose a previously selected image. @SBisson

image.png (1×608 px, 1001 KB)

AC4: A user is allowed to select only one image. PASSED
AC5: Instantly return back to story page after selecting an image. PASSED
AC6: Story page has an updated image. PASSED
AC7: Text on story page remain unchanged with this action. PASSED

[...]
AC3: Don’t show any of the previously selected images. NEEDS WORK
I can see and choose a previously selected image. @SBisson

This actually means that we show all images but they are not selected (they don't have their checkbox checked).

Thanks for that. I interpreted it differently.