Page MenuHomePhabricator
Create Task
Maniphest T302675

Rename centralauth-oversight to centralauth-suppress following the rename of oversight to suppress
Closed, ResolvedPublic
Actions

Description

In T112147 the oversight group got renamed to suppress. CentralAuth however still uses the oversight name in the centralauth-oversight right. This should get changed as well for naming consistency.

Steps

  • add a new centralauth-suppress permission to CentralAuth
  • add the centralauth-suppress permission to the local steward and wmf-supportsafety groups at metawiki
  • add the centralauth-suppress permission to the global sysadmin group
  • migrate CentralAuth to respect centralauth-suppress instead of centralauth-oversight
  • remove the centralauth-oversight permission from the local steward and supportsafety groups at metawiki
  • remove the centralauth-oversight permission from the global sysadmin group
  • remove the centralauth-oversight permission from CentralAuth
  • update permission in vagrant
  • update onwiki references: https://global-search.toolforge.org/?q=%22centralauth-oversight%22&namespaces=&title=

Details

SubjectRepoBranchLines +/-
Restoring centralauth-suppress localisationsmediawiki/extensions/CentralAuthmaster+120 -0
Remove centralauth-oversight permissionmediawiki/extensions/CentralAuthmaster+3 -10
Remove centralauth-oversight from the configoperations/mediawiki-configmaster+0 -3
Rename CentralAuthUser::isOversighted to ::isSuppressedmediawiki/extensions/CentralAuthmaster+12 -12
Migrate centralauth-oversight to centralauth-suppressmediawiki/vagrantmaster+1 -1
Migrate centralauth-oversight to centralauth-suppressmediawiki/extensions/CentralAuthmaster+29 -29
Add centralauth-suppress to steward and wmf-supportsafety at metawikioperations/mediawiki-configmaster+3 -0
Add centralauth-suppress permissionmediawiki/extensions/CentralAuthmaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

Asartea created this task.Feb 27 2022, 12:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2022, 12:11 PM
MarcoAurelio subscribed.EditedFeb 27 2022, 1:46 PM

Excluding i18n files, the code is used on CentralAuth, MediaWiki-Vagrant and the WMF-config files: https://codesearch.wmcloud.org/search/?q=centralauth-oversight&i=nope&files=&excludeFiles=i18n%2F&repos= so if this happens, it needs to be coordinated.

gerritbot added a comment.Feb 27 2022, 3:37 PM

Change 766304 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Add centralauth-suppress permission

https://gerrit.wikimedia.org/r/766304

gerritbot added a project: Patch-For-Review.Feb 27 2022, 3:37 PM
gerritbot added a comment.Feb 27 2022, 3:44 PM

Change 766305 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Migrate centralauth-oversight to centralauth-suppress

https://gerrit.wikimedia.org/r/766305

gerritbot added a comment.Feb 27 2022, 3:48 PM

Change 766306 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Add centralauth-suppress to steward at metawiki

https://gerrit.wikimedia.org/r/766306

gerritbot added a comment.Feb 27 2022, 3:48 PM

Change 766307 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Remove centralauth-oversight from steward at metawiki

https://gerrit.wikimedia.org/r/766307

gerritbot added a comment.Feb 27 2022, 3:50 PM

Change 766308 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/vagrant@master] Migrate centralauth-oversight to centralauth-suppress

https://gerrit.wikimedia.org/r/766308

Zabe subscribed.EditedFeb 27 2022, 3:59 PM
In T302675#7739992, @MarcoAurelio wrote:

Excluding i18n files, the code is used on CentralAuth, MediaWiki-Vagrant and the WMF-config files: https://codesearch.wmcloud.org/search/?q=centralauth-oversight&i=nope&files=&excludeFiles=i18n%2F&repos= so if this happens, it needs to be coordinated.

Steps

  1. add a new centralauth-suppress permission to CentralAuth
  2. add that new permission to the local steward group at metawiki
  3. migrate centralauth to respect that permission instead of centralauth-oversight
  4. remove the centralauth-oversight permission from the local steward group at metawiki
  5. remove the centralauth-oversight permission from CentralAuth

Vagrant can be fixed at some point after step 3.

Asartea added a comment.Feb 27 2022, 4:09 PM

Also noting that as soon as the config change goes live https://meta.wikimedia.org/wiki/MediaWiki:Gadgets-definition will need updating in order to prevent https://meta.wikimedia.org/wiki/MediaWiki:Gadget-globalsuppress from no longer working (actually that can probably just be added in right now)

taavi subscribed.Feb 27 2022, 4:29 PM

@Zabe Looks good, although steps 2 and 4 need to be taken on the staff and sysadmin global groups too.

gerritbot added a comment.Feb 27 2022, 4:31 PM

Change 766304 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add centralauth-suppress permission

https://gerrit.wikimedia.org/r/766304

MarcoAurelio added a comment.Feb 27 2022, 4:49 PM

@Zabe Also on wmf-supportsafety local group at Meta.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 27 2022, 5:00 PM
Zabe claimed this task.Feb 27 2022, 9:11 PM
Zabe updated the task description. (Show Details)
In T302675#7740070, @Majavah wrote:

@Zabe Looks good, although steps 2 and 4 need to be taken on the staff and sysadmin global groups too.

In T302675#7740075, @MarcoAurelio wrote:

@Zabe Also on wmf-supportsafety local group at Meta.

Thank you for the pointer.

Zabe updated the task description. (Show Details)Feb 27 2022, 9:14 PM
Zabe updated the task description. (Show Details)
gerritbot added a comment.Feb 28 2022, 2:53 PM

Change 766775 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Rename CentralAuthUser::isOversighted to ::isSuppressed

https://gerrit.wikimedia.org/r/766775

gerritbot added a comment.Mar 3 2022, 8:15 AM

Change 766306 merged by jenkins-bot:

[operations/mediawiki-config@master] Add centralauth-suppress to steward and wmf-supportsafety at metawiki

https://gerrit.wikimedia.org/r/766306

Stashbot added a comment.Mar 3 2022, 8:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-03T08:18:26Z] <taavi@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:766306|Add centralauth-suppress to steward and wmf-supportsafety at metawiki (T302675)]] (duration: 00m 50s)

Zabe updated the task description. (Show Details)Mar 3 2022, 8:19 AM
taavi updated the task description. (Show Details)Mar 3 2022, 8:29 AM
gerritbot added a comment.Mar 6 2022, 6:28 PM

Change 766305 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Migrate centralauth-oversight to centralauth-suppress

https://gerrit.wikimedia.org/r/766305

Zabe updated the task description. (Show Details)Mar 6 2022, 6:30 PM
gerritbot added a comment.Mar 6 2022, 6:34 PM

Change 766308 merged by jenkins-bot:

[mediawiki/vagrant@master] Migrate centralauth-oversight to centralauth-suppress

https://gerrit.wikimedia.org/r/766308

Zabe updated the task description. (Show Details)Mar 6 2022, 6:42 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 6 2022, 7:00 PM
gerritbot added a comment.Mar 8 2022, 7:01 AM

Change 766775 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Rename CentralAuthUser::isOversighted to ::isSuppressed

https://gerrit.wikimedia.org/r/766775

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.26; 2022-03-14); removed MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 8 2022, 8:00 AM
gerritbot added a comment.Mar 10 2022, 9:07 PM

Change 766307 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove centralauth-oversight from the config

https://gerrit.wikimedia.org/r/766307

Stashbot added a comment.Mar 10 2022, 9:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-10T21:13:41Z] <rzl@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:766307|Remove centralauth-oversight from the config (T302675)]] (duration: 00m 49s)

Zabe updated the task description. (Show Details)Mar 10 2022, 9:16 PM
gerritbot added a comment.Mar 10 2022, 11:51 PM

Change 769794 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Remove centralauth-oversight

https://gerrit.wikimedia.org/r/769794

taavi updated the task description. (Show Details)Mar 11 2022, 9:19 AM
gerritbot added a comment.Mar 11 2022, 9:28 AM

Change 769794 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove centralauth-oversight permission

https://gerrit.wikimedia.org/r/769794

Zabe closed this task as Resolved.Mar 11 2022, 12:58 PM
Zabe updated the task description. (Show Details)
gerritbot added a comment.Mar 14 2022, 1:30 PM

Change 770501 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Restoring centralauth-suppress localisations

https://gerrit.wikimedia.org/r/770501

gerritbot added a comment.Mar 14 2022, 2:43 PM

Change 770501 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Restoring centralauth-suppress localisations

https://gerrit.wikimedia.org/r/770501

Zabe removed a project: Patch-For-Review.Jun 10 2022, 11:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL