false in boolean settings in DefaultSettings.php
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Mar 27 2011, 4:38 PM

Description

Author: theevilipaddress

Description:
Trivial patch

I think that boolean values in DefaultSettings.php should, for consistency, always use true or false instead of 0 or 1. Though both works, I think it's confusing for people when it differs. Not everyone might be aware that it's a boolean value when there are numbers. Simple patch added, thanks.

Version: 1.18.x
Severity: enhancement

Attached:

boolean.patch4 KBDownload

Details

Reference: bz28275

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:35 PM

• bzimport added projects: MediaWiki-Documentation, good first task.

• bzimport set Reference to bz28275.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Mar 27 2011, 4:38 PM

Does this break any strict comparisons?

Preferences of the 'toggle' type (i.e. boolean preferences) are stored numerically as 0 or 1, not as false or true. Applying this patch and checking whether anything would break as a result is more trouble than it's worth IMO.

WONTFIXing per Roan's "more trouble than it's worth"

Change 0/1 to common true/false in boolean settings in DefaultSettings.phpClosed, DeclinedPublicActions

Description

Details

Event Timeline

Change 0/1 to common true/false in boolean settings in DefaultSettings.php
Closed, DeclinedPublic
Actions