Deletion log message can be parsed as wikitext in EditPage recreation confirmation
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	LucasWerkmeister
	Mar 6 2022, 1:12 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

create a page
start editing it
in another tab, delete it with a comment that includes </nowiki> (example: this '''is not''' bold </nowiki> but '''this''' is)
save the edit

What happens?:
MediaWiki tells you that the page was deleted since you started editing it, and asks you to confirm that you want to recreate it. It includes the log message, and anything after the </nowiki> will be parsed as wikitext, for example:

this '''is not''' bold but this is </nowiki>

What should have happened instead?:
The log message should not be parsed as wikitext even if it happens to contain </nowiki>. Log messages are plain text.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
MediaWiki core master

Details

	Subject	Repo	Branch	Lines +/-
	EditPage: Avoid parsing wikitext in comment	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned Here: T28187: Confirmrecreate needs a <nowiki> for the second parameter

Event Timeline

LucasWerkmeister created this task.Mar 6 2022, 1:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2022, 1:12 AM

Change 768268 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/core@master] EditPage: Avoid parsing wikitext in comment

https://gerrit.wikimedia.org/r/768268

gerritbot added a project: Patch-For-Review.Mar 6 2022, 1:13 AM

LucasWerkmeister claimed this task.Mar 6 2022, 1:13 AM

LucasWerkmeister updated the task description. (Show Details)Mar 6 2022, 1:16 AM

Log messages are plain text.

No, they aren’t. Log messages cannot contain formatting like bold and italics, but they can contain a limited wikitext syntax, for example internal links and HTML/XML character entities (&,   etc.). You can use CommentFormatter to properly format log messages.