Page MenuHomePhabricator
Create Task
Maniphest T30324

merge "Disable AJAX suggestions" and "Enable enhanced search suggestions"
Closed, InvalidPublic
Actions

Description

In MediaWiki there are two preferences: "Disable AJAX suggestions" and "Enable enhanced search suggestions (Vector skin only)".

They are problematic for several reasons:

Most average users don't know what AJAX is. This word just shouldn't be there. It should be just called "search suggestions".

The first option says "Disable", but the second one says "Enable". It's confusing - both should say "Enable". "Disable AJAX suggestions" should become "Enable search suggestions", and the value of the checkbox must be reversed for all users.

But better yet, the two options should be merged into one. "Disable AJAX suggestions" doesn't seem to do anything useful in Vector, no matter whether it's checked or not, and "Enable enhanced search suggestions (Vector skin only)", as its name implies is relevant only for Vector. Separating them may have been useful in the early days of Vector, but now that a year after the rollout Vector is rather stable, this doesn't seem to be useful any more.

Version: unspecified
Severity: enhancement

Details

Reference
bz28324

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:26 PM
• bzimport added a project: MediaWiki-Core-Preferences.
• bzimport set Reference to bz28324.
• bzimport added a subscriber: Unknown Object (MLST).
Amire80 created this task.Mar 30 2011, 8:02 AM
DanielFriesen added a comment.Nov 8 2012, 11:24 PM

MWSuggest was dropped and SimpleSearch is now universal. Anyone want to double check that the change fixed this bug?

Krinkle added a comment.Nov 9 2012, 10:59 AM

Which of the two preference keys (not the UI label) should we preserve and should be add a step in the Updater to migrate values?

(For large clusters that don't use update.php we can use maintenance/userOptions.php)

Aklapper added a comment.Nov 21 2012, 2:16 PM

Amir: Could you answer comment 2 please?

Aklapper added a comment.Mar 25 2013, 2:01 PM

Amir: Could you answer comment 2 please?

Amire80 added a comment.Mar 25 2013, 3:06 PM

(In reply to comment #2)

Which of the two preference keys (not the UI label) should we preserve and
should be add a step in the Updater to migrate values?

We should probably remove mwsuggest-disable completely.

Vector-simplesearch-preference should be renamed to "Enable search suggestions".

All that said, Vector-simplesearch-preference doesn't seem to have any effect: I tried unchecking it on Wikipedia and on my test wiki, and I still see search suggestions.

• werdna unsubscribed.Dec 10 2014, 5:38 PM
Mainframe98 closed this task as Invalid.Mar 25 2021, 12:20 PM
Mainframe98 edited subscribers, added: Mainframe98; removed: • wikibugs-l-list.

None of these preferences or messages exist anymore and searchsuggest is the unconditional default now.

Closing as invalid as these seem to have changed elsewhere through another task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL