Page MenuHomePhabricator

Search goes back to earlier state
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • On the Wikistories image search view
  • Type a letter (state 1)
  • Wait for the search spinner to start
  • Type another letter (state 2)

What happens?:

The search query is reset to state 1 and the results are for state 1

What should have happened instead?:

The search query and results should be for state 2

I suspect this has to do with the debounce and abort logic.

Event Timeline

SBisson triaged this task as High priority.Mar 16 2022, 2:28 PM

Change 772928 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Fix image search input bug

https://gerrit.wikimedia.org/r/772928

Change 772928 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Fix image search input bug

https://gerrit.wikimedia.org/r/772928

Hi @SBisson, this is still happening. Please see the video here.

Given the nature of this issue and its trickiness to replicate, I think it's best we try to put down in words what's exactly the faulty behavior we're seeing. The behavior I'm seeing is:

  • Sometimes, if you time it right, you can change the query string by one letter and have the visible images not update to the latest string.
  • That is, as shown in the video, you can end up with "cart" but have the first couple of visible images show images from "car"
  • I'm also seeing, not shown in the video, that if you do end up in that state of "cart" with car images, that's only the first visible images that don't update. That is I can scroll down and see the rest are "cart" images.

Can anyone who is able to replicate the issue also confirm if you're seeing the same behavior?

Change 789688 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Fix search view rendering bug

https://gerrit.wikimedia.org/r/789688

Change 789688 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Fix search view rendering bug

https://gerrit.wikimedia.org/r/789688

Testing:
Excellent work. I tried the method to replicate this and the system search still continued until the correct image was rendered. This has been fixed.