Thu, Aug 13
Perfect, thanks Huei. I've taken the liberty of creating T260316 to explore this idea .
Tue, Aug 11
We will likely need to attribute the text. Will update this ticket once this is confirmed.
This is the follow up PR I'm working on: https://github.com/wikimedia/wikipedia-preview/pull/41
Mon, Aug 10
Thanks Sudhanshu, as discussed over our call I will work on a follow up PR to address these as soon as possible
Thu, Aug 6
Wed, Aug 5
Thu, Jul 30
Wed, Jul 29
@SGautam_WMF thanks Sudhashu, we are addressing your feedback in this follow up PR:
Thu, Jul 23
Wed, Jul 22
Currently, T256157 deals with landscape views and it's scheduled for next month. From a development perspective, it probably makes more sense to handle the loading state landscape view along with or after T256157. Is it reasonable to either:
Jul 16 2020
Jul 14 2020
small issue found
Jul 10 2020
Draft PR, not ready yet PR ready: https://github.com/wikimedia/wikipedia-preview/pull/21
Jul 9 2020
I'm not suggesting the value but the user behaviour.
Jul 8 2020
That's indeed the original suggested value. @SGautam_WMF what do you think?
I have pushed commits to address the scrolling/frozen background as well as minor styling (popup height), and now this PR is merged to master. The demo page on mobile show now display these changes: https://wikimedia.github.io/wikipedia-preview
A dotted blue line appears after taping on "Read more on Wikipedia". This is happening in Firefox(68.10.0).
Unable to view & scroll the long text preview header after tapping on "Continue reading". I only found it in an entry-level Xiaomi android phone.
Jul 7 2020
For now, we can start with this number and if required, play around it to find the one which works well once we have it available in code.
By the way, given that this ticket is very mobile-centric, I'm leaving here instructions on how to run/test local branch directly on your mobile phone:
Jul 6 2020
PR ready for review now: https://github.com/wikimedia/wikipedia-preview/pull/18
Jul 1 2020
Merged now, thanks
Just a draft, not ready yet: https://github.com/wikimedia/wikipedia-preview/pull/18
Jun 30 2020
PR now created: https://github.com/wikimedia/wikipedia-kaios/pull/260
We are working on the final details in branch T236317-feeback-component-css-tweak
Jun 29 2020
Also, I noticed in the video that the alignment of the icon is wrong. This should be fixed here.
I'm not able to replicate in latest versions of Firefox, Chrome and Safari. Huei are you able to replicate? Pita, could you share with us a bit more about your set up when video was recorded: was that running locally? Looks like the index.html margins are missing
Jun 26 2020
Does this look better?
Jun 25 2020
Jun 23 2020
Unrelated to this, I think we need to tweak the position of the discard dialog box as some text is hidden in the Hindi language on all three devices also our usual adjustment for Jio-2
Jun 22 2020
Yea moving it back to Code Review so I can address Sudhanshu's last comment
Jun 19 2020
Agree this is a good opportunity for users to 'learn' that they can switch between links with right/left keys. I like the idea of keeping it more free flowing to make it more intuitive, how about the following to try to achieve that sweet spot, middle ground:
Jun 17 2020
@SGautam_WMF should we add hover pointer to the discovery style?
Nice, looking good
Sharing my takeaways here after having looked at the code. The current app behavior regarding navigation with up/down and right/left keys is:
Jun 15 2020
I would let Angie or Stephane make that call. PR is now merged though, so I think we would need another ticket
The reminder above is actually pretty useful
Jun 11 2020
Jun 9 2020
Jun 6 2020
Jun 4 2020
Sounds good, I have updated the branch the following user-friendly behavior:
It ends with a CTA to read the entire article by visiting mobile Wikipedia.
Jun 2 2020
Looking at the Nairobi article, this is the one picture I'm seeing that I believe you are referring to:
Jun 1 2020
May 31 2020
There are a few ideas regarding what to do when the phone is offline, we should decide how we want to move forward in this thread or in a daily meeting. Some approaches would probably need further design work, one (perhaps temporary) approach I can think of for us to stay most agile is reusing the same offline panel if there's no wifi when the feedback screen is displayed.
May 28 2020
May 27 2020
May 26 2020
Logging here what the links are:
May 20 2020
found a bug: if you select "send" and, once the "Feedback sent" popup is showing, you use the back button
@AMuigai noted, already included now under code review