Page MenuHomePhabricator

eamedina (Eduardo Medina)
Software Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 11 2020, 7:51 PM (100 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
EAMedina (WMF) [ Global Accounts ]

Recent Activity

Mon, Jan 10

eamedina added a comment to T292474: Add Image Attributions.

Sure thing, I've created branch T292474-img-attributions-follow-up and the demo link is: https://wikimedia.github.io/wikistories-prototype/T292474-img-attributions-follow-up/#/

Mon, Jan 10, 4:50 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)

Wed, Dec 22

eamedina added a comment to T296727: Image search experience in Wikistories.

https://github.com/wikimedia/wikistories-prototype/pull/41
https://wikimedia.github.io/wikistories-prototype/T296727-image-search/#/

Wed, Dec 22, 1:23 PM · Wikistories (MVP), Inuka-Team (Kanban)

Dec 13 2021

eamedina added a comment to T295982: Time per frame and play/pause feature.

Oh okay great! Glad it's working, it's good to make a note of your observation then

Dec 13 2021, 6:39 PM · Wikistories (Prototype), Inuka-Team (Kanban)
eamedina added a comment to T295982: Time per frame and play/pause feature.

the story playback did not pause.

Dec 13 2021, 6:18 PM · Wikistories (Prototype), Inuka-Team (Kanban)
eamedina moved T296727: Image search experience in Wikistories from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Dec 13 2021, 2:37 PM · Wikistories (MVP), Inuka-Team (Kanban)
eamedina claimed T296727: Image search experience in Wikistories.
Dec 13 2021, 2:37 PM · Wikistories (MVP), Inuka-Team (Kanban)
eamedina added a comment to T295982: Time per frame and play/pause feature.

Hello @imaigwilo, actually there is no pause button. How to pause depends on whether you are on mobile or desktop, the behavior is specified as:

Dec 13 2021, 1:53 PM · Wikistories (Prototype), Inuka-Team (Kanban)

Dec 6 2021

eamedina moved T295982: Time per frame and play/pause feature from Dev to Code Review on the Inuka-Team (Kanban) board.
Dec 6 2021, 7:30 PM · Wikistories (Prototype), Inuka-Team (Kanban)

Dec 2 2021

eamedina moved T295982: Time per frame and play/pause feature from Code Review to Dev on the Inuka-Team (Kanban) board.
Dec 2 2021, 7:30 PM · Wikistories (Prototype), Inuka-Team (Kanban)

Dec 1 2021

eamedina moved T295982: Time per frame and play/pause feature from Dev to Code Review on the Inuka-Team (Kanban) board.
Dec 1 2021, 3:54 PM · Wikistories (Prototype), Inuka-Team (Kanban)
eamedina added a comment to T295982: Time per frame and play/pause feature.

Ready for review: https://github.com/wikimedia/wikistories-prototype/pull/39

Dec 1 2021, 3:54 PM · Wikistories (Prototype), Inuka-Team (Kanban)

Nov 24 2021

eamedina moved T295982: Time per frame and play/pause feature from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Nov 24 2021, 2:24 PM · Wikistories (Prototype), Inuka-Team (Kanban)
eamedina claimed T295982: Time per frame and play/pause feature.
Nov 24 2021, 2:24 PM · Wikistories (Prototype), Inuka-Team (Kanban)

Nov 22 2021

eamedina moved T294392: [Improvement] Add localized language name support from Dev to Code Review on the Inuka-Team (Kanban) board.
Nov 22 2021, 6:59 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T294392: [Improvement] Add localized language name support.

https://github.com/wikimedia/wikipediapreview-wordpress/pull/55

Nov 22 2021, 6:59 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T292474: Add Image Attributions.

Both the suggestions from Stephane and Elena could work, I think we can move this to design and @SGautam_WMF you can give us the final call?

Nov 22 2021, 2:39 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)

Nov 19 2021

eamedina added a comment to T292474: Add Image Attributions.

Hey @Etonkovidova, thanks for flagging this. What's happening in the gif example is a "white on white" issue: the attribution is there but the white letters get blended in with the white background for images that happen to be white there, which as you pointed out, SVGs specially fit this bill.

Nov 19 2021, 6:06 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)

Nov 17 2021

eamedina moved T294392: [Improvement] Add localized language name support from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Nov 17 2021, 1:25 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina claimed T294392: [Improvement] Add localized language name support.
Nov 17 2021, 1:25 PM · Inuka-Team (Kanban), Wikipedia-Preview

Nov 16 2021

eamedina moved T287146: Gutenberg custom format - language selector from Dev to Code Review on the Inuka-Team (Kanban) board.
Nov 16 2021, 7:42 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T287146: Gutenberg custom format - language selector.

Can we reduce the spacing here?

Nov 16 2021, 7:33 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T295803: Custom form fails to anchor with some keyboard interactions.
Nov 16 2021, 7:15 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina moved T287146: Gutenberg custom format - language selector from Design sign off to Dev on the Inuka-Team (Kanban) board.
Nov 16 2021, 1:51 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T287146: Gutenberg custom format - language selector.

Can we reduce the spacing here?

Nov 16 2021, 1:49 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Nov 15 2021

eamedina added a comment to T292474: Add Image Attributions.

Yes of course, realizing now my question was a bit vague without an example. Question is whether we include "Author unknown" or not when there's no author specified from api, as below. Currently we do show it as this is consistent with other galleries, but the question had come up during code review so just wanted to touch base with you

Nov 15 2021, 5:30 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)
eamedina added a comment to T294516: Styling update - text input padding.

@SGautam_WMF the behavior of how the text scrolls is actually pre-programmed and included with the input text box we are using. From what I can see by interacting with it, it seems the logic is dictated by where the cursor is positioned in the long string, the goal being that user can actually see the text that's currently being typed, and hence the flexibility of the text scrolling either left or right depending on the cursor position. The selected language itself does not have any effect on the text scrolling.

Nov 15 2021, 4:52 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Nov 5 2021

eamedina added a comment to T292474: Add Image Attributions.

@SGautam_WMF is there a preference on whether we should show "Author unknown" or omit the author line altogether when there's no author specified from the api on an image?

Nov 5 2021, 1:43 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)

Nov 4 2021

eamedina added a comment to T295047: Highlighted text does not appear in story creation process.

https://github.com/wikimedia/wikistories-prototype/pull/28

Nov 4 2021, 3:27 PM · Inuka-Team (Kanban), Wikistories (Prototype)

Nov 3 2021

eamedina moved T294959: Minor uncaught TypeError from Dev to Code Review on the Inuka-Team (Kanban) board.
Nov 3 2021, 7:14 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T294959: Minor uncaught TypeError from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Nov 3 2021, 5:52 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T294959: Minor uncaught TypeError .

https://github.com/wikimedia/wikipedia-preview/pull/155

Nov 3 2021, 5:52 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina updated the task description for T294959: Minor uncaught TypeError .
Nov 3 2021, 5:43 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina claimed T294959: Minor uncaught TypeError .
Nov 3 2021, 5:39 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T294959: Minor uncaught TypeError .
Nov 3 2021, 5:39 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T292474: Add Image Attributions from Dev to Code Review on the Inuka-Team (Kanban) board.
Nov 3 2021, 5:18 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)
eamedina added a comment to T292474: Add Image Attributions.

https://github.com/wikimedia/wikistories-prototype/pull/24

Nov 3 2021, 12:50 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)

Oct 29 2021

eamedina added a comment to T294516: Styling update - text input padding.

We can fix that when we work on T294392

Oct 29 2021, 8:55 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Oct 28 2021

eamedina moved T294538: wordpress edit preview popup Goes To the Wrong Anchor Word from Dev to Code Review on the Inuka-Team (Kanban) board.
Oct 28 2021, 4:50 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T294538: wordpress edit preview popup Goes To the Wrong Anchor Word.

https://github.com/wikimedia/wikipediapreview-wordpress/pull/52

Oct 28 2021, 4:50 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina claimed T294538: wordpress edit preview popup Goes To the Wrong Anchor Word.
Oct 28 2021, 4:36 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina moved T294516: Styling update - text input padding from Dev to Code Review on the Inuka-Team (Kanban) board.
Oct 28 2021, 5:21 AM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T294516: Styling update - text input padding.

https://github.com/wikimedia/wikipediapreview-wordpress/pull/51

Oct 28 2021, 5:21 AM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T294515: Fix "simple" language search from Dev to Code Review on the Inuka-Team (Kanban) board.
Oct 28 2021, 4:03 AM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T294515: Fix "simple" language search.

https://github.com/wikimedia/wikipediapreview-wordpress/pull/50

Oct 28 2021, 4:03 AM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T294516: Styling update - text input padding.
Oct 28 2021, 3:53 AM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T294515: Fix "simple" language search.
Oct 28 2021, 3:49 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Oct 26 2021

eamedina added a comment to T287146: Gutenberg custom format - language selector.

Creating https://phabricator.wikimedia.org/T294392 with regards to localized names to ensure this doesn't block release

Oct 26 2021, 9:48 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T294392: [Improvement] Add localized language name support.
Oct 26 2021, 9:47 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina moved T292474: Add Image Attributions from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Oct 26 2021, 5:50 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)
eamedina claimed T292474: Add Image Attributions.
Oct 26 2021, 5:50 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)
eamedina moved T283081: Use browserslist-config-wikimedia for Wikipedia-Preview from Dev to Code Review on the Inuka-Team (Kanban) board.
Oct 26 2021, 5:26 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T287146: Gutenberg custom format - language selector.

if I select hebrew language from searching "he" if there's no results, the language selector goes back to the previous language automatically, confusing the user

Oct 26 2021, 2:09 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Oct 22 2021

eamedina added a comment to T283081: Use browserslist-config-wikimedia for Wikipedia-Preview.

https://github.com/wikimedia/wikipedia-preview/pull/153

Oct 22 2021, 8:22 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina moved T283081: Use browserslist-config-wikimedia for Wikipedia-Preview from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Oct 22 2021, 2:17 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina claimed T283081: Use browserslist-config-wikimedia for Wikipedia-Preview.
Oct 22 2021, 2:17 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T292474: Add Image Attributions.

@SGautam_WMF is this the correct design to look at for this ticket?

Oct 22 2021, 2:15 PM · Wikistories (MVP), QTE-TestingOverview, Inuka-Team (Kanban)

Oct 19 2021

eamedina added a comment to T287146: Gutenberg custom format - language selector.

Regarding the birth of this component:

Oct 19 2021, 7:20 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T293634: Bug appear when back to earlier typed query from the no result found .

Could this be related to https://phabricator.wikimedia.org/T293306?

Oct 19 2021, 2:10 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Oct 14 2021

eamedina awarded Blog Post: How we deploy code a Love token.
Oct 14 2021, 1:14 PM

Oct 13 2021

eamedina moved T287146: Gutenberg custom format - language selector from Dev to Code Review on the Inuka-Team (Kanban) board.
Oct 13 2021, 8:47 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T287146: Gutenberg custom format - language selector.

https://github.com/wikimedia/wikipediapreview-wordpress/pull/40

Oct 13 2021, 8:47 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T293306: Uncaught TypeError with fulltextSearch (api.js).
Oct 13 2021, 8:28 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina created T293305: [Improvement] A more synchronized solution to whether there exists a wiki for a specific language.
Oct 13 2021, 8:24 PM · Inuka-Team, Wikipedia-Preview

Oct 5 2021

eamedina moved T287146: Gutenberg custom format - language selector from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Oct 5 2021, 1:55 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina claimed T287146: Gutenberg custom format - language selector.
Oct 5 2021, 1:54 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Oct 4 2021

eamedina moved T291862: Story Viewer from Dev to Code Review on the Inuka-Team (Kanban) board.
Oct 4 2021, 3:55 PM · Inuka-Team (Kanban), Wikistories (Prototype)
eamedina updated the task description for T291862: Story Viewer.
Oct 4 2021, 3:55 PM · Inuka-Team (Kanban), Wikistories (Prototype)
eamedina added a comment to T291862: Story Viewer.

https://github.com/wikimedia/wikistories-prototype/pull/8

Oct 4 2021, 1:46 PM · Inuka-Team (Kanban), Wikistories (Prototype)

Sep 29 2021

eamedina added a comment to T289471: Gallery RTL Text from Wikipedia Preview shows incorrect direction of LTR Text .

I'd say this is a possible candidate for a new ticket where we could revisit how we source the image caption, but likely out of scope for this RTL/LTR ticket. Currently the code attempts to grab the caption from a couple of places, the caption landing in that image for example is from this api call:

Sep 29 2021, 4:36 PM · I18n, RTL, Wikipedia-Preview, Inuka-Team (Kanban)

Sep 28 2021

eamedina moved T291862: Story Viewer from Backlog to Dev on the Inuka-Team (Kanban) board.
Sep 28 2021, 2:59 PM · Inuka-Team (Kanban), Wikistories (Prototype)
eamedina claimed T291862: Story Viewer.
Sep 28 2021, 2:59 PM · Inuka-Team (Kanban), Wikistories (Prototype)
eamedina added a comment to T289471: Gallery RTL Text from Wikipedia Preview shows incorrect direction of LTR Text .

Yes good catch @Jpita, could you test this follow up PR?

Sep 28 2021, 11:44 AM · I18n, RTL, Wikipedia-Preview, Inuka-Team (Kanban)

Sep 27 2021

eamedina added a comment to T289438: image not selectable from TU-154 polish wiki article.

The image when clicked within the article, should follow the same path as we do with any other images - take the user to the gallery.

Sep 27 2021, 4:10 PM · Inuka-Team, KaiOS-Wikipedia-app
eamedina moved T289471: Gallery RTL Text from Wikipedia Preview shows incorrect direction of LTR Text from Dev to Code Review on the Inuka-Team (Kanban) board.
Sep 27 2021, 4:01 PM · I18n, RTL, Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T289471: Gallery RTL Text from Wikipedia Preview shows incorrect direction of LTR Text .

PR opened: https://github.com/wikimedia/wikipedia-preview/pull/149

Sep 27 2021, 4:01 PM · I18n, RTL, Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T289471: Gallery RTL Text from Wikipedia Preview shows incorrect direction of LTR Text from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Sep 27 2021, 2:35 PM · I18n, RTL, Wikipedia-Preview, Inuka-Team (Kanban)
eamedina claimed T289471: Gallery RTL Text from Wikipedia Preview shows incorrect direction of LTR Text .
Sep 27 2021, 2:35 PM · I18n, RTL, Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T279549: Plugin localization.

Spanish working as well: https://es.wordpress.org/plugins/wikipedia-preview/

Sep 27 2021, 6:43 AM · I18n, Inuka-Team (Kanban), Wikipedia-Preview

Sep 7 2021

eamedina moved T284601: Gutenburg custom format - preview from Dev to Code Review on the Inuka-Team (Kanban) board.
Sep 7 2021, 4:47 PM · Inuka-Team (Kanban), Wikipedia-Preview

Aug 23 2021

eamedina moved T289438: image not selectable from TU-154 polish wiki article from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
Aug 23 2021, 2:19 PM · Inuka-Team, KaiOS-Wikipedia-app
eamedina moved T287144: Gutenberg custom format - loading state from Backlog to Design doing on the Inuka-Team (Kanban) board.
Aug 23 2021, 2:16 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T287146: Gutenberg custom format - language selector from Backlog to Design doing on the Inuka-Team (Kanban) board.
Aug 23 2021, 2:16 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T289489: TypeError on console from gallery click from Dev to Code Review on the Inuka-Team (Kanban) board.
Aug 23 2021, 1:08 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T289489: TypeError on console from gallery click.

https://github.com/wikimedia/wikipedia-preview/pull/143

Aug 23 2021, 1:07 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina moved T289489: TypeError on console from gallery click from Backlog to Dev on the Inuka-Team (Kanban) board.
Aug 23 2021, 12:34 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina claimed T289489: TypeError on console from gallery click.
Aug 23 2021, 12:34 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina created T289489: TypeError on console from gallery click.
Aug 23 2021, 12:33 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Aug 18 2021

eamedina moved T284601: Gutenburg custom format - preview from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Aug 18 2021, 2:49 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina claimed T284601: Gutenburg custom format - preview.
Aug 18 2021, 2:49 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina updated the task description for T279549: Plugin localization.
Aug 18 2021, 1:52 PM · I18n, Inuka-Team (Kanban), Wikipedia-Preview

Aug 10 2021

eamedina moved T279549: Plugin localization from Dev to Code Review on the Inuka-Team (Kanban) board.
Aug 10 2021, 8:26 PM · I18n, Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T279549: Plugin localization.

As of today https://es.wordpress.org/plugins/wikipedia-preview/ still does not show the README content in spanish, but if I understand this https://translate.wordpress.org/projects/wp-plugins/wikipedia-preview/ correctly, it means that spanish translations are waiting to be confirmed by a human somewhere. This is all good learning, will keep an eye on it

Aug 10 2021, 8:19 PM · I18n, Inuka-Team (Kanban), Wikipedia-Preview
eamedina created T288574: Plugin integration with TWN.
Aug 10 2021, 8:18 PM · Inuka-Team, Wikipedia-Preview

Aug 4 2021

eamedina moved T269787: Allow zoom in on preview gallery from Code Review to Dev on the Inuka-Team (Kanban) board.
Aug 4 2021, 7:58 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T269787: Allow zoom in on preview gallery.

The follow-up PR needs more love some bringing this back to dev

Aug 4 2021, 7:58 PM · Inuka-Team (Kanban), Wikipedia-Preview
eamedina added a comment to T279549: Plugin localization.

First step towards localization: https://github.com/wikimedia/wikipediapreview-wordpress/pull/24

Aug 4 2021, 7:48 PM · I18n, Inuka-Team (Kanban), Wikipedia-Preview
eamedina moved T286941: Test plugin with Wordpress 5.8 from Dev to Code Review on the Inuka-Team (Kanban) board.
Aug 4 2021, 4:04 PM · Wikipedia-Preview, Inuka-Team (Kanban)
eamedina added a comment to T286941: Test plugin with Wordpress 5.8.

PR opened: https://github.com/wikimedia/wikipediapreview-wordpress/pull/26

Aug 4 2021, 4:03 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Aug 2 2021

eamedina updated the task description for T279547: Gutenburg custom format - form.
Aug 2 2021, 7:26 PM · Inuka-Team (Kanban), Wikipedia-Preview

Jul 30 2021

eamedina moved T286941: Test plugin with Wordpress 5.8 from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Jul 30 2021, 5:16 PM · Wikipedia-Preview, Inuka-Team (Kanban)