Mon, Jan 10
Sure thing, I've created branch T292474-img-attributions-follow-up and the demo link is: https://wikimedia.github.io/wikistories-prototype/T292474-img-attributions-follow-up/#/
Wed, Dec 22
Dec 13 2021
Oh okay great! Glad it's working, it's good to make a note of your observation then
the story playback did not pause.
Hello @imaigwilo, actually there is no pause button. How to pause depends on whether you are on mobile or desktop, the behavior is specified as:
Dec 6 2021
Dec 2 2021
Dec 1 2021
Ready for review: https://github.com/wikimedia/wikistories-prototype/pull/39
Nov 24 2021
Nov 22 2021
Both the suggestions from Stephane and Elena could work, I think we can move this to design and @SGautam_WMF you can give us the final call?
Nov 19 2021
Hey @Etonkovidova, thanks for flagging this. What's happening in the gif example is a "white on white" issue: the attribution is there but the white letters get blended in with the white background for images that happen to be white there, which as you pointed out, SVGs specially fit this bill.
Nov 17 2021
Nov 16 2021
Can we reduce the spacing here?
Can we reduce the spacing here?
Nov 15 2021
Yes of course, realizing now my question was a bit vague without an example. Question is whether we include "Author unknown" or not when there's no author specified from api, as below. Currently we do show it as this is consistent with other galleries, but the question had come up during code review so just wanted to touch base with you
@SGautam_WMF the behavior of how the text scrolls is actually pre-programmed and included with the input text box we are using. From what I can see by interacting with it, it seems the logic is dictated by where the cursor is positioned in the long string, the goal being that user can actually see the text that's currently being typed, and hence the flexibility of the text scrolling either left or right depending on the cursor position. The selected language itself does not have any effect on the text scrolling.
Nov 5 2021
@SGautam_WMF is there a preference on whether we should show "Author unknown" or omit the author line altogether when there's no author specified from the api on an image?
Nov 4 2021
Nov 3 2021
Oct 29 2021
We can fix that when we work on T294392
Oct 28 2021
Oct 26 2021
Creating https://phabricator.wikimedia.org/T294392 with regards to localized names to ensure this doesn't block release
if I select hebrew language from searching "he" if there's no results, the language selector goes back to the previous language automatically, confusing the user
Oct 22 2021
@SGautam_WMF is this the correct design to look at for this ticket?
Oct 19 2021
Regarding the birth of this component:
Could this be related to https://phabricator.wikimedia.org/T293306?
Oct 14 2021
Oct 13 2021
Oct 5 2021
Oct 4 2021
Sep 29 2021
I'd say this is a possible candidate for a new ticket where we could revisit how we source the image caption, but likely out of scope for this RTL/LTR ticket. Currently the code attempts to grab the caption from a couple of places, the caption landing in that image for example is from this api call:
Sep 28 2021
Yes good catch @Jpita, could you test this follow up PR?
Sep 27 2021
The image when clicked within the article, should follow the same path as we do with any other images - take the user to the gallery.
Spanish working as well: https://es.wordpress.org/plugins/wikipedia-preview/
Sep 7 2021
Aug 23 2021
Aug 18 2021
Aug 10 2021
As of today https://es.wordpress.org/plugins/wikipedia-preview/ still does not show the README content in spanish, but if I understand this https://translate.wordpress.org/projects/wp-plugins/wikipedia-preview/ correctly, it means that spanish translations are waiting to be confirmed by a human somewhere. This is all good learning, will keep an eye on it
Aug 4 2021
The follow-up PR needs more love some bringing this back to dev
First step towards localization: https://github.com/wikimedia/wikipediapreview-wordpress/pull/24