Page MenuHomePhabricator

Treating "Image not available in Commons" for wikistories
Closed, ResolvedPublic

Assigned To
Authored By
PWaigi-WMF
Feb 16 2023, 8:41 PM
Referenced Files
F38180876: Frame 26.png
Oct 10 2023, 7:20 AM
F38180877: Frame 25.png
Oct 10 2023, 7:20 AM
F37740419: 2023-09-18_13-32-51.mp4.gif
Sep 19 2023, 10:25 PM
F37740416: 2023-09-18_13-31-07.png
Sep 19 2023, 10:25 PM
F37740414: 2023-09-18_13-34-20.png
Sep 19 2023, 10:25 PM
F37724086: Screenshot 2023-09-14 at 2.55.27 PM.png
Sep 14 2023, 8:02 PM
F37724089: Screenshot 2023-09-14 at 2.57.13 PM.png
Sep 14 2023, 8:02 PM
F37601769: image.png
Aug 21 2023, 1:56 PM

Description

Background

In the story viewer, readers currently see a black screen when the image is no longer available in Commons. This results in a problematic story.

Design and acceptance criteria

Example: https://id.wikipedia.org/wiki/Story:Sekilas_tentang_Uang

image.png (843×784 px, 203 KB)

This ticket will cover how to handle missing image in the Story namespace by:

  • show warning message: X image(s) used in this story is no longer available on Commons.
  • add tracking categories Story_with_no_image_file
  • purge the story, when user opens the story viewer AND no tracking categories found

QA Results - Local

Event Timeline

PWaigi-WMF triaged this task as Medium priority.Feb 20 2023, 1:59 PM
PWaigi-WMF moved this task from Definition to Backlog on the Inuka-Team (Kanban) board.

Change 903601 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Notification for "Image not available in Commons"

https://gerrit.wikimedia.org/r/903601

Change 906685 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Add Tracking Categories for the story that has no image

https://gerrit.wikimedia.org/r/906685

Change 906706 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Add Tracking Categories for the story without image

https://gerrit.wikimedia.org/r/906706

Change 906685 abandoned by Huei Tan:

[mediawiki/extensions/Wikistories@master] Add Tracking Categories for the story that has no image

Reason:

https://gerrit.wikimedia.org/r/906685

Change 906706 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Add Tracking Categories for the story without image

https://gerrit.wikimedia.org/r/906706

Change 903601 abandoned by Huei Tan:

[mediawiki/extensions/Wikistories@master] (WIP) Notification for "Image not available in Commons"

Reason:

check another patch using Tracking Categories

https://gerrit.wikimedia.org/r/903601

Change 932184 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Purge Story Page when no image found on Story Viewer

https://gerrit.wikimedia.org/r/932184

Change 932184 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Purge Story Page when no image found on Story Viewer

https://gerrit.wikimedia.org/r/932184

You can ignore the original ticket description.

Here's what we did for "no image found on the story" on Story namespace page

example: https://id.wikipedia.org/wiki/Story:Sekilas_tentang_Uang

image.png (843×784 px, 203 KB)

  • show warning message: X image(s) used in this story is no longer available on Commons.
  • add tracking categories Story_with_no_image_file
  • purge the story, when user opens the story viewer AND no tracking categories found

Noting that T344822 will address some of the testing issues on this ticket

This ticket will cover how to handle missing image in the Story namespace by:

✅ show warning message: X image(s) used in this story is no longer available on Commons.
✅ add tracking categories Story_with_no_image_file
❓ purge the story, when user opens the story viewer AND no tracking categories found

  • I am not sure what this one means? How do I test this?

❓ purge the story, when user opens the story viewer AND no tracking categories found

  • I am not sure what this one means? How do I test this?

it means when you open the story viewer (eg: https://id.m.wikipedia.org/wiki/Uang#/story/3758997), it will send the purge request if this page doesn't have the tracking categories (Story_with_no_image_file in this case) yet.

In order to test it, you need to first delete the image; then load the story viewer page.

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

@hueitan As for the task, it's working as designed so I will move this to Design sign-off. In the purge section gif, I did bring up the idea of a possible warning message for deleted images on which @SGautam_WMF can take a look at if it needs a new ticket or not. Thanks for all you work though!

Status:✅ Pass
Environment: Local
OS: macOS Ventura
Browser: Chrome 116
Device: MBA M2
Emulated Device:: N/A
Test Links:
http://localhost:8080/w/index.php?title=Dog

✅AC1: https://phabricator.wikimedia.org/T329895#9106292

BeforeAfter
2023-09-18_13-34-20.png (1×2 px, 572 KB)
2023-09-18_13-31-07.png (1×2 px, 416 KB)

Purge- It does not show the image since it's deleted but when an image is deleted from a wikistory, shouldn't there be some kind of warning that this image does not exist or got deleted anymore when the user views the story? Kind of like when you get a duplicate message warning so the user is aware of what's going on?
gif

2023-09-18_13-32-51.mp4.gif (1×2 px, 1 MB)