Page MenuHomePhabricator
Create Task
Maniphest T304318

Flow dumps are broken on all wikis due to MediaWIki update
Closed, ResolvedPublicBUG REPORT
Actions

Description

Stack trace:

2022-03-21 13:54:16: ptwikibooks Checksumming ptwikibooks-20220320-pages-logging.xml.gz via sha1
Fatal error: Class 'BackupDumper' not found in /srv/mediawiki/php-1.38.0-wmf.26/extensions/Flow/maintenance/dumpBackup.php on line 14
Fatal error: Class 'BackupDumper' not found in /srv/mediawiki/php-1.38.0-wmf.26/extensions/Flow/maintenance/dumpBackup.php on line 14
Fatal error: Class 'BackupDumper' not found in /srv/mediawiki/php-1.38.0-wmf.26/extensions/Flow/maintenance/dumpBackup.php on line 14

Details

SubjectRepoBranchLines +/-
dumpBackup: Re-add require_once for BackupDumper.phpmediawiki/extensions/Flowmaster+1 -0
Customize query in gerrit

Event Timeline

Hokwelum created this task.Mar 21 2022, 2:28 PM
ArielGlenn added a comment.Mar 21 2022, 2:41 PM

This is caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/770072
I verfied this in testing in deployment-prep: as dumpsgen user on deployment-dnapshot03, run

/usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php extensions/Flow/maintenance/dumpBackup.php --wiki=ruwiki --output=file:/tmp/junk.txt  https://phabricator.wikimedia.org/T304318

and get same failure; copy in old dumpBackup.php into the mediawiki dir on deployment-snapshot03 and run again, works as expected.

ArielGlenn added a subscriber: Reedy.Mar 21 2022, 2:42 PM

Adding @Reedy for awareness.

gerritbot added a comment.Mar 21 2022, 2:58 PM

Change 772414 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@master] dumpBackup: Re-ad require_once for BackupDumper.php

https://gerrit.wikimedia.org/r/772414

gerritbot added a project: Patch-For-Review.Mar 21 2022, 2:58 PM
gerritbot added a comment.Mar 21 2022, 3:09 PM

Change 772414 abandoned by Reedy:

[mediawiki/extensions/Flow@master] dumpBackup: Re-add require_once for BackupDumper.php

Reason:

https://gerrit.wikimedia.org/r/772414

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2022, 3:10 PM
Stashbot added a comment.Mar 21 2022, 3:43 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-21T15:43:48Z] <reedy@deploy1002> Synchronized php-1.39.0-wmf.1/extensions/Flow/maintenance: T304318 (duration: 00m 51s)

Stashbot added a comment.Mar 21 2022, 3:44 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-21T15:44:49Z] <reedy@deploy1002> Synchronized php-1.38.0-wmf.26/extensions/Flow/maintenance: T304318 (duration: 00m 49s)

ArielGlenn added a comment.Mar 21 2022, 3:48 PM

The cherry pick for the third branch (.2) will go when the train for .2 runs, as that branch is not yet staged, deployment is not possible or needed.

The other two branches have the fix deployed, thanks Reedy for the help. Leaving this task open until wee see the flow dump jobs start to run to completion.

ArielGlenn triaged this task as Medium priority.Mar 21 2022, 3:49 PM

Setting this to medium priority now (did I not set it to ubn initially? Oh well), since it is likely fixed.

ArielGlenn closed this task as Resolved.Mar 23 2022, 8:52 AM
ArielGlenn claimed this task.

Everything ran to completion, so this is fixed. Thanks for the help, folks!

ArielGlenn moved this task from Backlog to Done on the Dumps-Generation board.Oct 20 2022, 11:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits