Train blockers task throws exceptions on strange version numbers
Open, LowPublicBUG REPORT
Actions

Assigned To

None

Authored By

	thcipriani
	Mar 23 2022, 4:45 PM

Description

We have a custom phabricator extension to handle train blocker tasks.

Entering a non-conforming task number causes an exception see code in ReleaseDetailsCustomField.php

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Refactor handling of version ranges by ReleaseDetailsCustomField	repos/phabricator/extensions!25	dduvall	review/T304540	wmf/stable

Customize query in GitLab

Related Objects

Mentioned In: T362689: "Undefined offset: 5" error when visiting https://phabricator.wikimedia.org/T361395
rPHEX1b5c4a44369d: Fix resolution of next version in the series for release details
Mentioned Here: T362689: "Undefined offset: 5" error when visiting https://phabricator.wikimedia.org/T361395
T330797: Uninstall Differential (Phabricator application)

Event Timeline

thcipriani created this task.Mar 23 2022, 4:45 PM

Restricted Application added subscribers: RhinosF1, Aklapper. · View Herald TranscriptMar 23 2022, 4:45 PM

brennen subscribed.Mar 23 2022, 4:45 PM

dduvall mentioned this in rPHEX1b5c4a44369d: Fix resolution of next version in the series for release details.Mar 23 2022, 5:15 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-23T17:35:25Z] <brennen> restarting phabricator for T304540, brief downtime expected

thcipriani edited projects, added Release-Engineering-Team (🌱 Spring Cleaning — April 2022); removed Release-Engineering-Team (🚂🧪 Trainsperiment Week).Apr 4 2022, 8:57 PM

thcipriani edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team (🌱 Spring Cleaning — April 2022).Sep 7 2022, 3:40 PM

• Cyaj8 closed this task as Resolved.Nov 18 2022, 12:28 PM

• Cyaj8 claimed this task.

Dylsss reopened this task as Open.Nov 18 2022, 2:28 PM

Dylsss removed • Cyaj8 as the assignee of this task.

Dylsss added a subscriber: • Cyaj8.

TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:35 PM

@dduvall: Would you be willing and have time to transfer your patch in D1200 into a MR in https://gitlab.wikimedia.org/repos/phabricator/extensions ?
It's the last open patch we have in Differential which we'd like to switch off per T330797. If not I can do so - just don't want to steal credits from you. :) TIA!
(However does so in the end, please do abandon the patch in D1200 afterwards. Thanks.)