Page MenuHomePhabricator
Create Task
Maniphest T304796

"Search completion" setting is not changed.
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

"Search completion" setting is not changed. (Wikipedia:バグの報告#ログイン時のみ右上の検索ボックスのサジェストがおかしい、また個人設定の「検索の補完」が変更不能 - jawiki)

Using Firefox 98.0.2 and Chrome 99.0.4844.84/Windows 10 and Google Chrome 99.0.4844.74/macOS Big Sur ver. 11.6.4

Steps to reproduce:

  1. Access https://ja.wikipedia.org/wiki/Special:Preferences
  2. "Search completion" Change settings and save.
  3. Message for "Your preferences have been saved." However, it is unchanged from the default.

Same result with enwiki ( https://en.wikipedia.org/wiki/Special:Preferences ).

Details

SubjectRepoBranchLines +/-
Revert "Hooks: Set default value for completion profile"mediawiki/extensions/CirrusSearchREL1_38+0 -1
Revert "Hooks: Set default value for completion profile"mediawiki/extensions/CirrusSearchmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

altocool created this task.Mar 27 2022, 2:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2022, 2:43 PM
Aklapper added projects: CirrusSearch, Regression.Mar 27 2022, 3:06 PM

Hi @altocool, thanks for taking the time to report this! I can reproduce this.

Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 27 2022, 3:06 PM
• MPhamWMF moved this task from needs triage to Current work on the Discovery-Search board.Mar 28 2022, 3:17 PM
• MPhamWMF edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• MPhamWMF set the point value for this task to 3.Mar 28 2022, 3:40 PM
• MPhamWMF moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
thiemowmde merged a task: T305037: CompletionSuggester user preference appears to be broken.Mar 30 2022, 9:23 AM
thiemowmde subscribed.

I just run into this as well. I can't change the setting neither on a per-wiki basis nor via MediaWiki-extensions-GlobalPreferences.

gerritbot added a comment.Mar 30 2022, 10:14 AM

Change 774993 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/CirrusSearch@master] Revert "Hooks: Set default value for completion profile"

https://gerrit.wikimedia.org/r/774993

gerritbot added a project: Patch-For-Review.Mar 30 2022, 10:14 AM
Func subscribed.Mar 30 2022, 10:40 AM
dcausse assigned this task to Func.Mar 30 2022, 1:03 PM
dcausse moved this task from Ready for Dev -- SWE to To Be Deployed on the Discovery-Search (Current work) board.
gerritbot added a comment.Mar 30 2022, 1:09 PM

Change 774993 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Revert "Hooks: Set default value for completion profile"

https://gerrit.wikimedia.org/r/774993

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2022, 1:10 PM
gerritbot added a comment.Mar 30 2022, 1:14 PM

Change 775000 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/CirrusSearch@REL1_38] Revert "Hooks: Set default value for completion profile"

https://gerrit.wikimedia.org/r/775000

gerritbot added a project: Patch-For-Review.Mar 30 2022, 1:14 PM
gerritbot added a comment.Mar 31 2022, 12:28 PM

Change 775000 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_38] Revert "Hooks: Set default value for completion profile"

https://gerrit.wikimedia.org/r/775000

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2022, 1:10 PM
EBernhardson moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Apr 29 2022, 8:08 PM
Gehel closed this task as Resolved.May 9 2022, 9:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL