Page MenuHomePhabricator

hhvm: ext/mysql throws needless notices on query failures
Closed, ResolvedPublic

Description

Not terribly important, but annoying. I get the following for calls to Database::tableExists() in my logs:

HipHop Notice: runtime/ext_mysql: failed executing [SELECT /* DatabaseBase::tableExists 24.125.174.151 */ 1 FROM mw_cur LIMIT 1] [Table 'wikidb.mw_cur' doesn't exist]


Version: 1.18.x
Severity: minor

Details

Reference
bz28481

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:37 PM
bzimport set Reference to bz28481.

You should file it upstream if it can't be disabled. MediaWiki has its own logging system for query errors we actually care about, we don't need HipHop's.

Is this still an issue nowadays?

They're PHP E_NOTICEs and can be silenced in the usual ways.

(In reply to comment #3)

They're PHP E_NOTICEs and can be silenced in the usual ways.

Not true. I tried silencing them with wfSuppressWarnings(), didn't work. @ worked, but it's evil. I filed bug 54840 about this same issue...I had forgotten this old bug existed.

  • Bug 54840 has been marked as a duplicate of this bug. ***

This only applies to ext/mysql in hhvm, not zend or sqlite or anything else.

Since we already handle the errors ourselves, I went ahead and just silenced them in gerrit change 87281.

(In reply to comment #1)

You should file it upstream if it can't be disabled. MediaWiki has its own
logging system for query errors we actually care about, we don't need
HipHop's.

I should've listened to Tim a long time ago.

Should be handled in master soon: https://github.com/facebook/hiphop-php/pull/1140

Chad pull request got merged :-]

[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]