Page MenuHomePhabricator

Debug payments-wiki javascript with Safari
Closed, ResolvedPublic2 Estimated Story Points

Description

DoD:

  • timebox this to an afternoon and post any news/information here. If the issue is really big, maybe start new tasks.

Now that most of us have Macs, see if we can reproduce the client-side error messages that seem to happen most often in Safari (and even try in an iphone with remote debugging configured, if possible). Those are a huge source of noise in payments.error.

Example error:
Apr 12 16:55:22 payments1006 adyen_gateway: 118500977:118500977.1 Client side error: Array ( [message] => TypeError: null is not an object (evaluating 'config.locale')

Related Objects

Event Timeline

Dwisehaupt set the point value for this task to 2.Apr 11 2022, 8:24 PM

here is the errors related with this ticket, since not able to reproduce from the local env, shift focus to other tickets now, will back later https://docs.google.com/spreadsheets/d/1qVRqsfTWYSmx9ed5T9MlhaLpKk4sqCGo/edit?usp=sharing&ouid=109990517551911357524&rtpof=true&sd=true

Checking a few UA strings on this site shows this is not Safari but Chrome. So far I've only seen version 100. That version is old but apparently still supported.

Possible next steps, if they're considered to be worth the effort, might be to try to find specific places in the code where this could be happening, and counting how many such errors we get?

Thanks!!

I searched some recent logs for "Client side error", and found what seems like a relatively small number of errors, though many of the ones documented by @AnnWF here seem no longer to be occurring. (Thanks for that thorough research btw!! :) )

Looks like there are a few others... The total volume does not seem especially concerning, and they're probably mostly edge cases. Still, I think they could bear further digging when we get the chance.

Conclusion

  • The error indicated in the task description is actually not from Safari, but from a relatively recent, still-supported Chrome version.
  • I'd recommend separate tasks for reviewing and classifying client-side errors, and (if others agree, I think we might actually already have this) reviewing our client-side error monitoring to make sure would catch anything catastrophic quickly.

Thanks!!

DStrine set Final Story Points to 2.