Page MenuHomePhabricator

AndyRussG (Andrew Green)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 28 2014, 2:36 PM (229 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
AGreen (WMF) [ Global Accounts ]

Recent Activity

Thu, Mar 21

AndyRussG created T218958: E-mail unsubscribe: integration testing.
Thu, Mar 21, 9:45 PM · Fundraising-Backlog
AndyRussG created T218957: E-mail unsubscribe: alerts for full pipeline.
Thu, Mar 21, 9:42 PM · Fundraising-Backlog
AndyRussG removed a project from T218953: Document essential CentralNotice debugging: Epic.
Thu, Mar 21, 9:30 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG created T218953: Document essential CentralNotice debugging.
Thu, Mar 21, 9:19 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T218473: Simultaneous configuring of pending changes and page protection fails to apply page protection.

T217469 had a patch deployed... Is the issue on this task fixed, also, maybe?

Thu, Mar 21, 4:29 PM · Performance-Team, MediaWiki-Page-protection, MediaWiki-extensions-FlaggedRevs
AndyRussG added a comment to T218617: Fix EventLogging schemas that use array for items type.

FYI that this blocks some changes to improve refinement of data, cause until these schemas are changed they cannot be refined with the new code. Ping @AndyRussG

Thu, Mar 21, 4:19 PM · Analytics-EventLogging, Analytics-Kanban, Patch-For-Review, Fundraising-Backlog, Product-Analytics, Analytics
AndyRussG added a project to T218617: Fix EventLogging schemas that use array for items type: Fundraising-Backlog.
Thu, Mar 21, 4:18 PM · Analytics-EventLogging, Analytics-Kanban, Patch-For-Review, Fundraising-Backlog, Product-Analytics, Analytics
AndyRussG added a comment to T217176: Update fundraising tech training matrix.

Columned my update.

Thu, Mar 21, 2:28 AM · Fundraising Sprint Ewoks Take Manhattan, fundraising-tech-ops, Fundraising-Backlog
Mill <mill@mail.com> committed rWMFR5a148e84dbb2: %5edbaaaaaaaaaaa (authored by AndyRussG).
%5edbaaaaaaaaaaa
Thu, Mar 21, 12:36 AM
Mill <mill@mail.com> committed rWMFR629b78c9fbee: 9cbaaaaaaaaaaa (authored by AndyRussG).
9cbaaaaaaaaaaa
Thu, Mar 21, 12:36 AM
Mill <mill@mail.com> committed rWMFRe2992788533c: 8gbaaaaaaaaaaa (authored by AndyRussG).
8gbaaaaaaaaaaa
Thu, Mar 21, 12:36 AM
Mill <mill@mail.com> committed rWMFRf220862a0ca5: ahbaaaaaaaaaaa (authored by AndyRussG).
ahbaaaaaaaaaaa
Thu, Mar 21, 12:36 AM
Mill <mill@mail.com> committed rWMFR2ae8baf6e47f: 3jbaaaaaaaaaaa (authored by AndyRussG).
3jbaaaaaaaaaaa
Thu, Mar 21, 12:36 AM
Mill <mill@mail.com> committed rWMFRd6793ae45abb: 4jbaaaaaaaaaaa (authored by AndyRussG).
4jbaaaaaaaaaaa
Thu, Mar 21, 12:36 AM

Tue, Mar 5

AndyRussG moved T216150: New message inclusion syntax strips <span> with more than one class from Backlog to Review on the Fundraising Sprint Ewoks Take Manhattan board.
Tue, Mar 5, 10:00 PM · Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Patch-For-Review, Fundraising Sprint Da Vinci Coder, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Thu, Feb 28

AndyRussG edited projects for T217374: Consolidate QuickSurveys into CentralNotice, added: Fundraising-Backlog; removed Fundraising-Analysis.
Thu, Feb 28, 8:37 PM · Epic, Fundraising-Backlog, Code-Stewardship-Reviews, Performance, Research, MediaWiki-extensions-CentralNotice, QuickSurveys, Technical-Debt, Readers-Web-Backlog

Tue, Feb 26

AndyRussG added a comment to T159255: Draft Documentation for Community Banner design guidance.

It might be good for fr-tech to know that this exists and have links to it. However it's kind of a Seddon task. Fr-tech engineers should not attempt this without him.

Tue, Feb 26, 8:15 PM · Fundraising-Backlog, Wikimedia-CentralNotice-Administration, User-JSeddon
AndyRussG created T217185: Document responsibilities and roles of Advancement teams from the perspective of FR-Tech.
Tue, Feb 26, 7:08 PM · Fundraising-Backlog
AndyRussG created T217177: Archive or update old, out-of-date Fundraising Tech documentation.
Tue, Feb 26, 6:50 PM · Fundraising-Backlog
AndyRussG created T217175: Document how to query CentralNotice data via Hive and Druid.
Tue, Feb 26, 6:48 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T135653: Payments vagrant role has duplicated settings, needs more documentation.

Just to note, additional developer setup required for the fundraising vagrant role (such as perhaps specific XDebug stuff) should also be documented.

Tue, Feb 26, 6:39 PM · Fundraising-Backlog, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface
AndyRussG added a comment to T141617: Documentation: UML activity and sequence diagrams for all processors.

Here are the unfinished drafts from a while ago.

Tue, Feb 26, 6:33 PM · Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Octopus Untangling, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ
AndyRussG added a parent task for T141617: Documentation: UML activity and sequence diagrams for all processors: T209872: epic: frtech onwiki documentation overhaul.
Tue, Feb 26, 6:26 PM · Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Octopus Untangling, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ
AndyRussG added a subtask for T209872: epic: frtech onwiki documentation overhaul: T141617: Documentation: UML activity and sequence diagrams for all processors.
Tue, Feb 26, 6:26 PM · Epic, fundraising-tech-ops, Fundraising-Backlog
AndyRussG added a parent task for T205477: Document CentralNotice-Translate integration: T209872: epic: frtech onwiki documentation overhaul.
Tue, Feb 26, 6:18 PM · Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a subtask for T209872: epic: frtech onwiki documentation overhaul: T205477: Document CentralNotice-Translate integration.
Tue, Feb 26, 6:18 PM · Epic, fundraising-tech-ops, Fundraising-Backlog
AndyRussG added a parent task for T95254: CentralNotice documentation: review, reorganize, rewrite, purge, complete and bring up-to-date: T209872: epic: frtech onwiki documentation overhaul.
Tue, Feb 26, 6:18 PM · Documentation, MediaWiki-extensions-CentralNotice
AndyRussG added a subtask for T209872: epic: frtech onwiki documentation overhaul: T95254: CentralNotice documentation: review, reorganize, rewrite, purge, complete and bring up-to-date.
Tue, Feb 26, 6:18 PM · Epic, fundraising-tech-ops, Fundraising-Backlog

Feb 19 2019

AndyRussG added a project to T216287: CentralNotice must not query master on GET request (page views): Fundraising-Backlog.
Feb 19 2019, 2:36 AM · Fundraising-Backlog, Performance-Team (Radar), Availability (MediaWiki-MultiDC), Wikimedia-production-error, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible

Feb 14 2019

AndyRussG added a comment to T215088: Update page performance tests to use null banner parameter.

@AndyRussG, do you think it would be possible to check the headers in CentralNotice.hooks.php? When a banner header with a value of null is set, maybe we don't call $out->addModules( 'ext.centralNotice.startUp' );. This would disable the CentralNotice banner JavaScript from executing.

Feb 14 2019, 3:46 PM · Performance-Team (Radar), Readers-Web-Backlog

Feb 12 2019

AndyRussG moved T210986: Missing centralnotice admin protection level messages causing broken edit summaries and strings in Special Pages from Pending Deployment to Done on the Fundraising Sprint Casino Royale With Cheese board.
Feb 12 2019, 12:35 AM · Fundraising Sprint Casino Royale With Cheese, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Fundraising-Backlog, User-MarcoAurelio, MediaWiki-extensions-CentralNotice, I18n, WikimediaMessages
AndyRussG moved T209795: Add 'CentralNotice' tag to all CentralNotice banner edits from Pending Deployment to Done on the Fundraising Sprint Casino Royale With Cheese board.
Feb 12 2019, 12:35 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG closed T215086: Add null banner preview to CentralNotice for performance testing baseline as Resolved.
Feb 12 2019, 12:27 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG closed T215086: Add null banner preview to CentralNotice for performance testing baseline, a subtask of T215088: Update page performance tests to use null banner parameter, as Resolved.
Feb 12 2019, 12:27 AM · Performance-Team (Radar), Readers-Web-Backlog
AndyRussG moved T215086: Add null banner preview to CentralNotice for performance testing baseline from Pending Deployment to Done on the Fundraising Sprint Casino Royale With Cheese board.
Feb 12 2019, 12:25 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 11 2019

Jdlrobson awarded T215842: Investigate error tracking and alerts for in-banner JS a Like token.
Feb 11 2019, 9:55 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T215711: POTY banners are causing client side error during banner display on mobile AND desktop.
In T215711, @Jdlrobson wrote:

consider during the render process of a banner catching any errors and hitting a stats beacon with the banner name similar to this:
https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.scripts/errorLogging.js

Basically we can catch any errors and increment a counter at wikimedia.event.BannerError.<skin>.<bannerName> to help us identify banners that have problems

Feb 11 2019, 9:29 PM · MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising-Banners
AndyRussG renamed T215842: Investigate error tracking and alerts for in-banner JS from Investigate error tracking for in-banner JS to Investigate error tracking and alerts for in-banner JS.
Feb 11 2019, 9:27 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG created T215842: Investigate error tracking and alerts for in-banner JS.
Feb 11 2019, 9:26 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214412: Check and improve procedures and doc about code review, testing and linting of banner JS.

Another issue: T215711: POTY banners are causing client side error during banner display on mobile AND desktop.

Feb 11 2019, 6:41 PM · Fundraising-Backlog

Feb 8 2019

AndyRussG updated subscribers of T136904: Spike: Plan reforms of the CentralNotice deployment branch.

Following IRL discussion with @thcipriani, it seems there's a pretty easy solution! If the script that automatically generates release branches for extensions can be made to create branches based on wmf_deploy, rather than master, that would allow us to keep fine-grained control over how and when things are deployed, and at the same time let deployments use existing standard procedures. Any thoughts? Thanks in advance!!!!

Feb 8 2019, 5:29 PM · Patch-For-Review, Wikimedia-Incident, Release-Engineering-Team (Long-Lived-Branches), Spike, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 7 2019

AndyRussG added a comment to T215088: Update page performance tests to use null banner parameter.

T215086 just merged into CentralNotice master. It should go out with the train next week.

Feb 7 2019, 7:57 PM · Performance-Team (Radar), Readers-Web-Backlog
AndyRussG moved T215086: Add null banner preview to CentralNotice for performance testing baseline from Review to Pending Deployment on the Fundraising Sprint Casino Royale With Cheese board.
Feb 7 2019, 7:54 PM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 6 2019

AndyRussG added a comment to T214773: Banner and JS review request for 'stewvote' banner (desktop & mobile).

When I went to aa.wikibooks I guess it's not displaying to me because I got it displayed already at Meta?

Was my language there not being set in Afar. Displays okay to me.

Feb 6 2019, 7:48 PM · Wikimedia-CentralNotice-Administration, Fundraising-Backlog
AndyRussG closed T210102: Make protection reason localizable, display on wiki content language as Resolved.
Feb 6 2019, 4:04 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising Sprint Window dressing is mostly olive oil, I18n, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T209795: Add 'CentralNotice' tag to all CentralNotice banner edits from Done to Pending Deployment on the Fundraising Sprint Casino Royale With Cheese board.
Feb 6 2019, 4:01 PM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T210986: Missing centralnotice admin protection level messages causing broken edit summaries and strings in Special Pages from Backlog to Pending Deployment on the Fundraising Sprint Casino Royale With Cheese board.
Feb 6 2019, 3:59 PM · Fundraising Sprint Casino Royale With Cheese, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Fundraising-Backlog, User-MarcoAurelio, MediaWiki-extensions-CentralNotice, I18n, WikimediaMessages
AndyRussG added a project to T210986: Missing centralnotice admin protection level messages causing broken edit summaries and strings in Special Pages: Fundraising Sprint Casino Royale With Cheese.
Feb 6 2019, 3:58 PM · Fundraising Sprint Casino Royale With Cheese, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Fundraising-Backlog, User-MarcoAurelio, MediaWiki-extensions-CentralNotice, I18n, WikimediaMessages
AndyRussG closed T213565: Incorrect protection reason for non-source-language version of translatable banner messages as Resolved.
Feb 6 2019, 3:49 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG moved T215086: Add null banner preview to CentralNotice for performance testing baseline from Backlog to Review on the Fundraising Sprint Casino Royale With Cheese board.
Feb 6 2019, 3:39 PM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214773: Banner and JS review request for 'stewvote' banner (desktop & mobile).

I've refactored the javascript and created a test banner with it:

Feb 6 2019, 7:30 AM · Wikimedia-CentralNotice-Administration, Fundraising-Backlog

Feb 5 2019

AndyRussG added a comment to T214773: Banner and JS review request for 'stewvote' banner (desktop & mobile).

This is happening on 3 days and I'd rather not run into script issues that makes the banner go wild. Please help. Thank you.

Feb 5 2019, 6:34 AM · Wikimedia-CentralNotice-Administration, Fundraising-Backlog

Feb 2 2019

AndyRussG moved T215087: Add automatic performance testing for all live banners from Backlog to Review on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Feb 2 2019, 2:56 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a project to T215087: Add automatic performance testing for all live banners: Fundraising Sprint Bert and Ernie's Excellent Adventure.
Feb 2 2019, 2:56 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG updated subscribers of T215087: Add automatic performance testing for all live banners.
Feb 2 2019, 2:55 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG renamed T215086: Add null banner preview to CentralNotice for performance testing baseline from Add null banner preivew to CentralNotice for performance testing baseline to Add null banner preview to CentralNotice for performance testing baseline.
Feb 2 2019, 2:53 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG updated the task description for T215086: Add null banner preview to CentralNotice for performance testing baseline.
Feb 2 2019, 2:43 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG created T215087: Add automatic performance testing for all live banners.
Feb 2 2019, 2:42 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG created T215086: Add null banner preview to CentralNotice for performance testing baseline.
Feb 2 2019, 2:42 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Jan 25 2019

AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

I just re-ran the query, and the results are the same, as expected.

Jan 25 2019, 6:32 PM · Fundraising-Backlog
AndyRussG moved T210102: Make protection reason localizable, display on wiki content language from Pending Deployment to Done on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 25 2019, 5:23 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising Sprint Window dressing is mostly olive oil, I18n, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T213565: Incorrect protection reason for non-source-language version of translatable banner messages from Pending Deployment to Done on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 25 2019, 5:23 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T187207: Spin out a tiny EventLogging RL module for lightweight logging.

Ping here @AndyRussG and @phuedx @jlinehan so they now Eventlogging is been refactored such it can now be added in every page, it does not validate events client side like it used to but you can set up that validation in your development environment. We recommend any instrumenting code that is not using eventlogging and rather sending events directly to the becaon (virtual pageviews and some FR banners) to be changed so it is resilient to changes on the EL client that might be upcoming.

Jan 25 2019, 5:14 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Analytics-Kanban, Performance-Team (Radar), Analytics-EventLogging, Analytics
AndyRussG created T214709: Remove hacky EventLogging-duplicating code and use new lightweight EL facilities.
Jan 25 2019, 5:13 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

Did you intend to have a different field than uri_host in the OR clause looking for Special:BannerLoader? Lools like uri_host has to be exactly meta.wikimedia.org.

Jan 25 2019, 5:09 PM · Fundraising-Backlog

Jan 24 2019

AndyRussG added a comment to T214410: Investigate impact and protection from errors in banners JS.

As Timo predicted, I am not seeing any impact on any other JS on mobile or desktop.

Jan 24 2019, 8:16 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214410: Investigate impact and protection from errors in banners JS.

I've set up a test banner with a JS error on the beta cluster.

Jan 24 2019, 6:07 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

Just FYI, here's the task about the data discrepancy: T214600.

Jan 24 2019, 4:50 PM · Fundraising-Backlog
AndyRussG updated the task description for T214600: Investigate discrepancy in banner data for Steward elections campaign.
Jan 24 2019, 4:49 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG renamed T214600: Investigate discrepancy in banner data for Steward elections campaign from Investigate data discrepancy in banner data for Steward elections campaign to Investigate discrepancy in banner data for Steward elections campaign.
Jan 24 2019, 4:48 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG created T214600: Investigate discrepancy in banner data for Steward elections campaign.
Jan 24 2019, 4:47 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

Here is the data from Hive for actual calls to Special:BannerLoader to load and inject the banner into the page. The Hive query used follows.

Jan 24 2019, 4:28 PM · Fundraising-Backlog

Jan 23 2019

AndyRussG added a comment to T214410: Investigate impact and protection from errors in banners JS.

I was seeing broken JS for certain pages, but it's possible of course these were unrelated to the banner...

Jan 23 2019, 7:37 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214410: Investigate impact and protection from errors in banners JS.

@Krinkle , thanks much for the great explanation!

Jan 23 2019, 7:04 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

Hi! That campaign currently sets no banner going out to the mobile site. We have a quick (though slightly less reliable) way of querying the data, which shows that after the banner was removed, it was displayed no more than four times per hour. This could be due to JavaScript with the banner choices payload being cached longer than it should, somewhere outside our datacenters, so outside our control. I don't think that's enough to be the source of the errors you see? BTW at its peak, the banner wasn't being shown more often than 60 times per hour. See this Turnilo plot.

Jan 23 2019, 4:45 AM · Fundraising-Backlog

Jan 22 2019

AndyRussG closed T178930: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library as Resolved.
Jan 22 2019, 9:49 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint They Live, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Owls, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Junebugs prefer July, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising Sprint Vaporwerewolf, Fundraising Sprint Uptight Piano, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG closed T178930: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library, a subtask of T124132: [Epic] Analytics, graphs and monitoring for banners and CentralNotice, as Resolved.
Jan 22 2019, 9:49 PM · Epic, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG moved T195594: New scripts to ingress data from Kafkatee into MySQL from Backlog to Review on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:48 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint They Live, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint Raw data can give you salmonella, Patch-For-Review, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Owls, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog
AndyRussG moved T198752: Queries and maybe scripts to verify equivalence of data in new-Kafka-pipeline-testing and pgehres production databases from Backlog to Review on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:47 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint They Live, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint Raw data can give you salmonella, Patch-For-Review, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Owls, Fundraising-Backlog
AndyRussG moved T209795: Add 'CentralNotice' tag to all CentralNotice banner edits from Backlog to Pending Deployment on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:47 PM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T210102: Make protection reason localizable, display on wiki content language from Backlog to Pending Deployment on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:41 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising Sprint Window dressing is mostly olive oil, I18n, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T210983: CentralNotice protects CentralNotice templates endlessly each time a template is editted, polluting history and logs from Pending Deployment to Done on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:41 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T210983: CentralNotice protects CentralNotice templates endlessly each time a template is editted, polluting history and logs from Backlog to Pending Deployment on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:40 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T213565: Incorrect protection reason for non-source-language version of translatable banner messages from Backlog to Pending Deployment on the Fundraising Sprint Bert and Ernie's Excellent Adventure board.
Jan 22 2019, 9:39 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

From IRC:

Jan 22 2019, 8:14 PM · Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

Thanks for taking care of the banner problem. Errors haven't quite resumed to normal levels, is there a possibility old banner code could be cached? Obviously this could be another error, so I will continue investigating today.

Jan 22 2019, 7:26 PM · Fundraising-Backlog
AndyRussG created T214412: Check and improve procedures and doc about code review, testing and linting of banner JS.
Jan 22 2019, 4:22 PM · Fundraising-Backlog
AndyRussG renamed T214410: Investigate impact and protection from errors in banners JS from Investigate impact and protection from errors from in banners JS to Investigate impact and protection from errors in banners JS.
Jan 22 2019, 4:16 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG renamed T214410: Investigate impact and protection from errors in banners JS from Investigate impact and protection from errors from scripts in banners to Investigate impact and protection from errors from in banners JS.
Jan 22 2019, 4:16 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG created T214410: Investigate impact and protection from errors in banners JS.
Jan 22 2019, 4:14 PM · Performance-Team (Radar), MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG updated subscribers of T214330: Mobile Steward elections 2019 banner broken.
Jan 22 2019, 3:54 PM · Fundraising-Backlog

Jan 21 2019

AndyRussG updated the task description for T214330: Mobile Steward elections 2019 banner broken.
Jan 21 2019, 9:31 PM · Fundraising-Backlog
AndyRussG added a comment to T214330: Mobile Steward elections 2019 banner broken.

I've updated the mobile banner. I don't think it will cause errors now. I also added an alterImpressionData function to get correct data about whether or not the banner was displayed.

Jan 21 2019, 9:28 PM · Fundraising-Backlog
AndyRussG created T214330: Mobile Steward elections 2019 banner broken.
Jan 21 2019, 8:49 PM · Fundraising-Backlog

Jan 18 2019

AndyRussG moved T209795: Add 'CentralNotice' tag to all CentralNotice banner edits from Review to Pending Deployment on the Fundraising Sprint A series of unfortunate event handlers board.
Jan 18 2019, 5:30 PM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Jan 17 2019

AndyRussG moved T213915: wmf_deploy updated but not merged and deployed into .12 from Backlog to Done on the Fundraising Sprint A series of unfortunate event handlers board.
Jan 17 2019, 12:33 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T213915: wmf_deploy updated but not merged and deployed into .12.

Pulled this onto deploy1001 in the staging dir for wmf.12. git status no longer shows new commits in extensions/CentralNotice. :)

Jan 17 2019, 12:32 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG claimed T213915: wmf_deploy updated but not merged and deployed into .12.
Jan 17 2019, 12:31 AM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Jan 16 2019

AndyRussG added a comment to T213915: wmf_deploy updated but not merged and deployed into .12.

Shouldn’t need that. It’s already in the core branch as that’s tracking wmf_deploy...

Jan 16 2019, 7:49 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T213915: wmf_deploy updated but not merged and deployed into .12.

You just need to update the git sub module for CN on deploy1001 and sync it :)

Jan 16 2019, 7:37 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Fundraising Sprint A series of unfortunate event handlers, Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-CentralNotice