Just added another comment:

Here's what I just commented on Gerrit:

Confirmed! (See https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/58622/consoleFull)

In T211248#5325606, @Ottomata wrote:

@DStrine, I need some help from someone who knows how to make changes to centralnotice campaigns to test that these events work after migration. Who should I ask?

Hi! I'm getting a different result here...

@Jdforrester-WMF Thanks!!!

Also putting here the comments I added in Gerrit about QUnit tests:

Hi! I just posted the following on the Gerrit change (includes the above plus a few more thoughts):

In T226344#5309308, @mepps wrote:

Thanks @Ejegg! @AndyRussG anything to add? @DStrine I assume we don't have hours left to fix this. Should we be doing it ourselves?

The job should be processing correctly now. We also backfilled the files that weren't processed properly due to this error. Most of the data since the outage, and going forward, should be OK now.

In T226963#5298080, @sbassett wrote:

Just to confirm, these patch sets:
Rename and move update preview button (519974)
Rename link to preview saved version on-wiki (519973)
Refactor BannerRenderer and SpecialBannerLoader (519959)
Make BannerRenderer link methods static (519950)
Banner preview: JS improvements (516459)
Banner in-page preview mode (508720)
Banner live preview (497611)

Also: T226967: CentralNotice: Error handling for banner preview background calls

In T226963#5296429, @sbassett wrote:

Hey @AndyRussG - did you want the Security-Team to have a look at this? If so, we should get a request into our queue.

Patches submitted to fix almost everything. For details, see checkmarks and other notes on each point in the preceding comments.

In T225688#5255672, @Krinkle wrote:

For your tests, you'll have to look at what you need for this parameter:

• If it just needs a dummy instance, the simplest move is to insert new HashConfig. Or, use something like $this->createMock( ResourceLoader::class ).
• If it relies on actual global config, then explicitly pass in the current default from MediaWikiServices::getMainConfig().

@Krinkle Thanks!!!

Also noting here locations of review comments:

Review should look at the current "HEAD" of the series of Gerrit patches: https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/FRUEC/+/516062/

I've edited the previous comments to indicate the importance of each issue, as follows:

Comments on patch set 13 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/508720/ (5de28b87c8):

Indeed this should be fixed... The point of this was to warn people testing banners of potential problems. Thanks @Catrope, @Jdforrester-WMF!!

Suggested UI changes (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/497611/ PS 19 and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/508720/ PS 13):

Further comments on patch set 19 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/497611/ (619cd38294f0373):

In T136904#5240957, @greg wrote:

This is done, yes?

SpecialBannerLoader 68-69: check with security about how we're reflecting POSTed content back. Any need for sanitization? Any dangers given the current setup? Also, if this is indeed safe, add a comment about why, and and warning against future changes that could make it unsafe.

In T224733#5235149, @Ottomata wrote:

I believe that @AndyRussG recently deployed a change to the producer code to update the revision used?

Comments refer to patch set 19 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/497611/ (619cd38294f0373)

In T224733#5230636, @fdans wrote:

@Jgreen can you provide a little more context if you think we could be of help?