Page MenuHomePhabricator

AndyRussG (Andrew Green)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 28 2014, 2:36 PM (438 w, 4 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
AGreen (WMF) [ Global Accounts ]

Recent Activity

Yesterday

AndyRussG moved T331671: CentralNotice banners being shown too many times from Pending Deployment to Done on the Fundraising Tech - Chaos Crew board.
Mon, Mar 20, 8:17 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T331671: CentralNotice banners being shown too many times.

Just to confirm, the issue with user preferences not correctly hiding banners based on type: this part of the system now seems to be working as expected. Is anyone still experiencing this specific bug?

Mon, Mar 20, 8:17 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Fri, Mar 17

AndyRussG added a comment to T332396: Paypal EC Pending Transaction Resolver failed (missing 'date' param).

Thanks so much for this @jgleeson! The attached patch looks great.

Fri, Mar 17, 6:56 PM · Fundraising Tech - Chaos Crew, Fundraising-Backlog

Thu, Mar 16

AndyRussG added a comment to T322612: [REQUEST] Review updated test ESI comment injection patch.

Can this ticket be closed @AndyRussG given I think you took another direction?

Thu, Mar 16, 6:14 PM · Readers-Web-Backlog

Wed, Mar 15

AndyRussG added a comment to T331671: CentralNotice banners being shown too many times.

@Pcoombe Yes, I sadly know. And in my opinion, I consider this a bug and not a feature. Many of us are active on more than one project and get annoyed by the same banners multiple times.

Wed, Mar 15, 5:44 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Tue, Mar 14

AndyRussG added a comment to T331671: CentralNotice banners being shown too many times.

Thanks @AndyRussG for fixing the preference bug!

Tue, Mar 14, 5:10 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T331671: CentralNotice banners being shown too many times.

Heyyy here are some quick notes:

  • I was able to reproduce this on production just by disabling banner categories in my preferences and seeing what happened. Not sure why you're not seeing any banners, @TheresNoTime.
  • The fix turned out to be quite simple. It has been merged and placed on this week's deploy train. It should be deployed to most Wikipedias on Thursday, and to most other projects and a few Wikipedias on Wednesday.

Apologies for the delay in getting to this, and for not writing more details just now. (FR-Tech is rushing to get a new payments integration finished this week.) I'll try to find time later this week to explain more and reply to some comments above.
Thanks again!!

Tue, Mar 14, 2:42 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Mon, Mar 13

AndyRussG added a comment to T331678: International Women's day 2023 banner displaying even with account banner preferences set to not display.

Thanks so much for this, it's been immensely helpful!! As noted here T331671#8688951, it looks like there is indeed be a bug. I'll post more on the parent task as soon as I can.

Mon, Mar 13, 6:11 PM · Wikimedia-CentralNotice-Administration
AndyRussG added a comment to T331671: CentralNotice banners being shown too many times.

Thanks so much everyone for your input and effort on this, and many apologies for the delay.

Mon, Mar 13, 6:08 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG moved T324297: Support DLocal recurring cards in DonationInterface from Being Reviewed to Done on the Fundraising Sprint Everything I Merge I Merge For You board.
Mon, Mar 13, 2:40 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Sprint Everything I Merge I Merge For You, Fundraising Sprint Drop It Like It's Fraud, MediaWiki-extensions-DonationInterface, FR-dlocal, Fundraising-Backlog

Thu, Mar 9

AndyRussG added a project to T331671: CentralNotice banners being shown too many times: Fundraising-Backlog.
Thu, Mar 9, 9:47 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Tech - Chaos Crew, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Wed, Mar 8

AndyRussG moved T330724: Handle recurring IPNs for Dlocal from Backlog to Doing on the Fundraising Sprint Everything I Merge I Merge For You board.
Wed, Mar 8, 5:05 AM · Patch-For-Review, Fundraising Sprint Everything I Merge I Merge For You, FR-Smashpig, FR-dlocal, Fundraising-Backlog
AndyRussG claimed T330724: Handle recurring IPNs for Dlocal.
Wed, Mar 8, 5:04 AM · Patch-For-Review, Fundraising Sprint Everything I Merge I Merge For You, FR-Smashpig, FR-dlocal, Fundraising-Backlog

Wed, Mar 1

AndyRussG added a comment to T324297: Support DLocal recurring cards in DonationInterface.

Attached patches add the required fields to the donations queue message. Test and UI elements will be included in follow-on patches.

Wed, Mar 1, 6:56 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Sprint Everything I Merge I Merge For You, Fundraising Sprint Drop It Like It's Fraud, MediaWiki-extensions-DonationInterface, FR-dlocal, Fundraising-Backlog
AndyRussG moved T324297: Support DLocal recurring cards in DonationInterface from Backlog to Doing on the Fundraising Sprint Everything I Merge I Merge For You board.
Wed, Mar 1, 4:21 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Sprint Everything I Merge I Merge For You, Fundraising Sprint Drop It Like It's Fraud, MediaWiki-extensions-DonationInterface, FR-dlocal, Fundraising-Backlog

Fri, Feb 24

AndyRussG added a comment to T318103: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined.

Thanks so much @Krinkle, @kostajh !!

Fri, Feb 24, 10:29 PM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, Fundraising Tech - Chaos Crew, Fundraising-Backlog, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-CentralNotice

Wed, Feb 22

AndyRussG moved T324297: Support DLocal recurring cards in DonationInterface from Backlog to Doing on the Fundraising Sprint Drop It Like It's Fraud board.
Wed, Feb 22, 5:57 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Sprint Everything I Merge I Merge For You, Fundraising Sprint Drop It Like It's Fraud, MediaWiki-extensions-DonationInterface, FR-dlocal, Fundraising-Backlog
AndyRussG claimed T324297: Support DLocal recurring cards in DonationInterface.
Wed, Feb 22, 5:57 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Fundraising Sprint Everything I Merge I Merge For You, Fundraising Sprint Drop It Like It's Fraud, MediaWiki-extensions-DonationInterface, FR-dlocal, Fundraising-Backlog

Feb 16 2023

AndyRussG moved T324296: Implement backend for DLocal recurring card payments in SmashPig from Ready for Review to Being Reviewed on the Fundraising Sprint Drop It Like It's Fraud board.
Feb 16 2023, 4:56 PM · Fundraising Sprint Drop It Like It's Fraud, Recurring-Donations, FR-Smashpig, FR-dlocal, Fundraising-Backlog

Feb 14 2023

AndyRussG moved T301905: modernize DjangoBannerStats to python3 from Backlog to Done on the Fundraising Tech - Chaos Crew board.
Feb 14 2023, 3:24 AM · fundraising-tech-ops, Patch-For-Review, Fundraising Tech - Chaos Crew, Python3-Porting, Fundraising-Backlog

Feb 13 2023

AndyRussG added a comment to T301905: modernize DjangoBannerStats to python3.

Summary

  • The updated code for this is merged and deployed, but I'm unable to turn on the process-control job myself due to a permissions issue. (Can't push to fran1001:/var/lib/git/localsettings.git/)
  • Comparing the output of the old and new versions of the script, via spot-checking, we see the following:
    • Data in banner impressions seems identical.
    • Data in landingpageimpression_raw seems almost identical.
    • Data in donatewiki_unique seems to get additional entries with the new script. These entries are not present in data generated previously by the old script in the production pgehres database. However, this was probably due to an issue with the old script, or something related to the setup at that time, causing the old script to incorrectly drop data.
Feb 13 2023, 6:41 AM · fundraising-tech-ops, Patch-For-Review, Fundraising Tech - Chaos Crew, Python3-Porting, Fundraising-Backlog

Feb 7 2023

AndyRussG added a comment to T301905: modernize DjangoBannerStats to python3.

Instructions for running under fundraising-dev with bullseye:

Feb 7 2023, 9:05 AM · fundraising-tech-ops, Patch-For-Review, Fundraising Tech - Chaos Crew, Python3-Porting, Fundraising-Backlog

Feb 6 2023

AndyRussG added a comment to T319498: Uncaught TypeError: mw.centralNotice.isBannerShown is not a function.

Thanks @Jdlrobson! I'll make a CN patch just to always expose a mw.centralNotice.isBannerShown() function no matter what, since that seems like the most logical way for the CN JS API to work, and would prevent errors like the one mentioned in the task description.

Feb 6 2023, 7:00 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Instrument-ClientError, MediaWiki-extensions-WikimediaEvents, MediaWiki-extensions-CentralNotice

Feb 5 2023

AndyRussG added a subtask for T291697: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021): T327272: Refactor Smashpig healthcheck scripts to use HealthCheck class.
Feb 5 2023, 11:23 PM · Epic, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
AndyRussG added a parent task for T327272: Refactor Smashpig healthcheck scripts to use HealthCheck class: T291697: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021).
Feb 5 2023, 11:23 PM · Fundraising-Backlog
AndyRussG added a comment to T287028: Docker dev setup: scope out use cases, requirements and command-line UI to replace setup.sh.

An additional use case is the global enabling or disabling of components. Possible commands for this:
frdev disable privatebin
frdev enable donut

Feb 5 2023, 10:46 PM · Fundraising Sprint Fish HEAD^, Fundraising Sprint Can't touch $this, FR-Docker, Fundraising-Backlog
AndyRussG renamed T278728: Docker dev setup: replace setup.sh with something better from Docker dev setup: break out setup.sh into smaller scripts, maybe add a few new ones to Docker dev setup: replace setup.sh with something better.
Feb 5 2023, 10:37 PM · FR-Docker, Fundraising-Backlog
AndyRussG renamed T287028: Docker dev setup: scope out use cases, requirements and command-line UI to replace setup.sh from Docker dev setup: scope out use cases, requirements and command-line UI for breaking out setup.sh into smaller scripts to Docker dev setup: scope out use cases, requirements and command-line UI to replace setup.sh.
Feb 5 2023, 10:37 PM · Fundraising Sprint Fish HEAD^, Fundraising Sprint Can't touch $this, FR-Docker, Fundraising-Backlog

Feb 1 2023

AndyRussG committed rWFDV21140b972e78: Donut: Enable plain HTTP (authored by AndyRussG).
Donut: Enable plain HTTP
Feb 1 2023, 2:07 AM
AndyRussG added a comment to T318103: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined.

Fresh is now working on Donut (the MW instance with CentralNotice on the fr-dev stack).

Feb 1 2023, 1:46 AM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, Fundraising Tech - Chaos Crew, Fundraising-Backlog, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T326974: Docker: make all MediaWiki services work with Fresh.

This is working for Donut, with this patch: https://gerrit.wikimedia.org/r/885446.

Feb 1 2023, 1:41 AM · Fundraising Tech - Chaos Crew, FR-Docker, Fundraising-Backlog

Jan 31 2023

AndyRussG added a comment to T301905: modernize DjangoBannerStats to python3.

Thanks for all this!!

Jan 31 2023, 10:57 PM · fundraising-tech-ops, Patch-For-Review, Fundraising Tech - Chaos Crew, Python3-Porting, Fundraising-Backlog
AndyRussG moved T322793: Japan Form Variations for Testing for Q3 from Doing to Being Reviewed on the Fundraising Sprint Bridge over troubled Wifi board.
Jan 31 2023, 4:49 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Fundraising Sprint Bridge over troubled Wifi, Fundraising Sprint Amazing grep, fr-donorservices, FR-Japan, Fundraising-Backlog
AndyRussG committed rWFDV823563b703f6: Donut: set fake GeoIP cookie in Apache (authored by AndyRussG).
Donut: set fake GeoIP cookie in Apache
Jan 31 2023, 1:31 AM

Jan 30 2023

AndyRussG committed rWFDV801ac8a4ef51: Donut: add logger config (authored by AndyRussG).
Donut: add logger config
Jan 30 2023, 4:38 PM
AndyRussG updated the task description for T318103: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined.
Jan 30 2023, 4:48 AM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, Fundraising Tech - Chaos Crew, Fundraising-Backlog, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T318103: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined.

While I'm still unable to run tests locally using npm run qunit, I've made some progress running them in the browser locally under Donut wiki on the fr-dev stack.

Jan 30 2023, 4:45 AM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, Fundraising Tech - Chaos Crew, Fundraising-Backlog, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T326974: Docker: make all MediaWiki services work with Fresh.

Two attached patches (the second one was somehow not added by gerritbot):

Jan 30 2023, 4:31 AM · Fundraising Tech - Chaos Crew, FR-Docker, Fundraising-Backlog
AndyRussG created P43438 T318103 Jenkins output for test failure.
Jan 30 2023, 4:17 AM

Jan 25 2023

AndyRussG updated the task description for T327857: GPay issue due to missing config update [fixed].
Jan 25 2023, 8:22 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG updated the task description for T327857: GPay issue due to missing config update [fixed].
Jan 25 2023, 7:39 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG updated the task description for T327857: GPay issue due to missing config update [fixed].
Jan 25 2023, 7:32 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG renamed T327857: GPay issue due to missing config update [fixed] from Fix GPay issue due to missing config change to GPay issue due to missing config update [fixed].
Jan 25 2023, 7:24 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG added a project to T327857: GPay issue due to missing config update [fixed]: Fundraising-Backlog.
Jan 25 2023, 7:20 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG updated the task description for T327857: GPay issue due to missing config update [fixed].
Jan 25 2023, 7:19 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG triaged T327857: GPay issue due to missing config update [fixed] as Unbreak Now! priority.
Jan 25 2023, 6:59 AM · Fundraising-Backlog, Fundraising Tech - Chaos Crew
AndyRussG created T327855: Update config for Payments Staging.
Jan 25 2023, 5:33 AM · Fundraising-Backlog

Jan 23 2023

AndyRussG placed T327712: Review CentralNotice patch for Translate namespace change up for grabs.
Jan 23 2023, 9:13 PM · Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog, MediaWiki-extensions-Translate
AndyRussG created T327712: Review CentralNotice patch for Translate namespace change.
Jan 23 2023, 9:12 PM · Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog, MediaWiki-extensions-Translate
AndyRussG added a comment to T322793: Japan Form Variations for Testing for Q3.

From the commit message on the patch for the 2nd variant:

Jan 23 2023, 9:02 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Fundraising Sprint Bridge over troubled Wifi, Fundraising Sprint Amazing grep, fr-donorservices, FR-Japan, Fundraising-Backlog
AndyRussG added a comment to T318103: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined.

Hmmm maybe we're not mocking mw.requestIdleCallback in a qunit test somewhere where we should, and some recent change to CI has made calls to the original method unreliable? (More detailed explanations in also Gerrit.) Also, I do see this still happening recently, for example, here.

Jan 23 2023, 6:24 PM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, Fundraising Tech - Chaos Crew, Fundraising-Backlog, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-CentralNotice
AndyRussG added a project to T313242: Move classes in the Translate root directory to namespace: Fundraising-Backlog.
Jan 23 2023, 5:46 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Language-Team (Language-2023-January-March), Patch-For-Review, Technical-Debt, MediaWiki-extensions-Translate

Jan 20 2023

AndyRussG added a project to T327505: Site notice for Vector 2022 is sometimes not possible to dismiss: Fundraising-Backlog.
Jan 20 2023, 4:37 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Desktop Improvements (Vector 2022)

Jan 18 2023

AndyRussG added a comment to T287028: Docker dev setup: scope out use cases, requirements and command-line UI to replace setup.sh.

Another idea: an updated fr-dev CLI could also be a place to put automated scripts for the local steps needed to prepare a deploy.

Jan 18 2023, 4:41 PM · Fundraising Sprint Fish HEAD^, Fundraising Sprint Can't touch $this, FR-Docker, Fundraising-Backlog
AndyRussG moved T322793: Japan Form Variations for Testing for Q3 from Ready for Review to Being Reviewed on the Fundraising Sprint Bridge over troubled Wifi board.
Jan 18 2023, 4:03 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Fundraising Sprint Bridge over troubled Wifi, Fundraising Sprint Amazing grep, fr-donorservices, FR-Japan, Fundraising-Backlog

Jan 17 2023

AndyRussG moved T270680: Clean up install script from wmf_civicrm & move relevant parts to the extension from Being Reviewed to Pending Deployment on the Fundraising Sprint Amazing grep board.
Jan 17 2023, 7:39 PM · Fundraising Sprint Amazing grep, Fundraising Sprint Airline Passenger Experience, Patch-For-Review, Fundraising Sprint Zeitgeistbusters, Fr-drupal-upgrade-2021, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Jan 13 2023

AndyRussG added a comment to T326984: Vector 2022 deployment banner not appearing.

Looks like the issue is the campaign seems to be set to display 0 banners per device.

Jan 13 2023, 8:10 PM · Fundraising-Backlog
AndyRussG moved T270680: Clean up install script from wmf_civicrm & move relevant parts to the extension from Ready for Review to Being Reviewed on the Fundraising Sprint Amazing grep board.
Jan 13 2023, 5:02 PM · Fundraising Sprint Amazing grep, Fundraising Sprint Airline Passenger Experience, Patch-For-Review, Fundraising Sprint Zeitgeistbusters, Fr-drupal-upgrade-2021, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
AndyRussG added a comment to T326972: Docker: config to selectively enable/disable services.

Hi @Addshore! Ah interesting, thanks! They're part of the fundraising-dev environment we use to set up the diverse fundraising stack locally.

Jan 13 2023, 5:01 PM · mwcli, FR-Docker, Fundraising-Backlog
AndyRussG created T326974: Docker: make all MediaWiki services work with Fresh.
Jan 13 2023, 4:56 PM · Fundraising Tech - Chaos Crew, FR-Docker, Fundraising-Backlog
AndyRussG updated the task description for T326972: Docker: config to selectively enable/disable services.
Jan 13 2023, 4:47 PM · mwcli, FR-Docker, Fundraising-Backlog
AndyRussG created T326972: Docker: config to selectively enable/disable services.
Jan 13 2023, 4:44 PM · mwcli, FR-Docker, Fundraising-Backlog
AndyRussG created T326969: Docker: sync mechanism for content from production wikis.
Jan 13 2023, 4:23 PM · FR-Docker, Fundraising-Backlog
AndyRussG created T326968: Docker: add Donut campaigns and banners.
Jan 13 2023, 4:20 PM · FR-Docker, Fundraising-Backlog
AndyRussG created T326966: Docker: add links to other services to start page.
Jan 13 2023, 4:15 PM · FR-Docker, Fundraising-Backlog
AndyRussG moved T325191: Write up medium term project outline for ESI+CentralNotice from Backlog to Done on the Fundraising Sprint Amazing grep board.
Jan 13 2023, 3:38 PM · Fundraising Sprint Amazing grep, Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising-Backlog
AndyRussG added a subtask for T291697: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021): T323962: PaymentProviders capabilities should be clearly indicated by interfaces.
Jan 13 2023, 2:58 PM · Epic, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
AndyRussG added a parent task for T323962: PaymentProviders capabilities should be clearly indicated by interfaces: T291697: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021).
Jan 13 2023, 2:58 PM · Fundraising-Backlog, FR-Smashpig
AndyRussG added a comment to T308799: Test ESI feasibility with current Varnish installation.

The fix for T320734 is now deployed, so the ESI comment string for testing is now being added to the base HTML for both desktop and mobile sites. So, once the cache finishes rolling over, it'll be present throughout the base HTML served via Varnish.

Jan 13 2023, 5:10 AM · Patch-For-Review, SRE, Traffic
AndyRussG closed T320734: CentralNotice: Add ESI test string to base HTML, a subtask of T308799: Test ESI feasibility with current Varnish installation, as Resolved.
Jan 13 2023, 5:04 AM · Patch-For-Review, SRE, Traffic
AndyRussG closed T320734: CentralNotice: Add ESI test string to base HTML as Resolved.
Jan 13 2023, 5:04 AM · Fundraising Sprint Amazing grep, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising Sprint Vwl Cnsrvtn, Fundraising Sprint Undefined, Readers-Web-Backlog, Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, Fundraising Sprint Solid State Spaghetti, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG moved T320734: CentralNotice: Add ESI test string to base HTML from Pending Deployment to Done on the Fundraising Sprint Amazing grep board.
Jan 13 2023, 5:03 AM · Fundraising Sprint Amazing grep, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising Sprint Vwl Cnsrvtn, Fundraising Sprint Undefined, Readers-Web-Backlog, Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, Fundraising Sprint Solid State Spaghetti, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T320734: CentralNotice: Add ESI test string to base HTML.

This is now deployed!

Jan 13 2023, 5:03 AM · Fundraising Sprint Amazing grep, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising Sprint Vwl Cnsrvtn, Fundraising Sprint Undefined, Readers-Web-Backlog, Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, Fundraising Sprint Solid State Spaghetti, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T322612: [REQUEST] Review updated test ESI comment injection patch.

The BeforePageDisplay hook approach looks a lot better than the SiteNotice one @AndyRussG (enabling $wgMinervaEnableSiteNotice would have likely caused a lot of issues with user notices on mobile). If you need the ESI string to go inside banners in future, I'd suggest we do some refactoring of Minerva to achieve that. Glad to hear you are unblocked!

Jan 13 2023, 5:02 AM · Readers-Web-Backlog

Jan 12 2023

AndyRussG placed T324860: Bug: duplicate Adyen transactions in short sequence up for grabs.
Jan 12 2023, 5:33 PM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog
AndyRussG added a comment to T324860: Bug: duplicate Adyen transactions in short sequence.

Current version of the attached patch seems to work! I think at least a bit more testing and study is needed to check for possible side effects/edge cases. Also I feel we'd we need to fix exception thrown and add inline comments to explain how things work.

Jan 12 2023, 5:27 PM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog

Jan 11 2023

AndyRussG moved T317498: Add a test version of a main-cluster wiki to fundraising-dev, for dev work on on Donate Wiki, CentralNotice and banners (CentralDonut) from Ready for Review to Being Reviewed on the Fundraising Sprint Amazing grep board.
Jan 11 2023, 6:52 PM · Fundraising Sprint Amazing grep, Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising Sprint Vwl Cnsrvtn, Fundraising Sprint Undefined, Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, Patch-For-Review, FR-Docker, Fundraising-Backlog
AndyRussG moved T326673: Set up CentralNotice on donut container from Ready for Review to Being Reviewed on the Fundraising Sprint Amazing grep board.
Jan 11 2023, 6:52 PM · Fundraising Sprint Amazing grep, FR-Docker, Fundraising-Backlog

Jan 9 2023

AndyRussG added a comment to T320734: CentralNotice: Add ESI test string to base HTML.

Note: hoping to deploy the latest fix to production pretty soon, possibly this week. This would cause the test ESI comment string to be injected on both desktop and mobile sites (rather than just desktop, as is currently the case). Thanks!

Jan 9 2023, 7:36 PM · Fundraising Sprint Amazing grep, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising Sprint Vwl Cnsrvtn, Fundraising Sprint Undefined, Readers-Web-Backlog, Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, Fundraising Sprint Solid State Spaghetti, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T322612: [REQUEST] Review updated test ESI comment injection patch.

Quick update: the patch in question was looked over by other fr-tech engineers and we agreed it seems extremely safe. So, we merged it to master, which meant it has been deployed to the beta cluster, but not to production, since December 15th.

Jan 9 2023, 7:33 PM · Readers-Web-Backlog

Jan 3 2023

AndyRussG updated the language for P42746 civibuildkit fix 2023-01-03 from bash to diff.
Jan 3 2023, 7:44 PM
AndyRussG created P42746 civibuildkit fix 2023-01-03.
Jan 3 2023, 7:43 PM

Dec 22 2022

AndyRussG moved T324860: Bug: duplicate Adyen transactions in short sequence from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.
Dec 22 2022, 5:00 PM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog
AndyRussG moved T323895: Unresponsive donation form 11/24/22 from Ready for Review to Being Reviewed on the Fundraising Tech - Chaos Crew board.
Dec 22 2022, 5:00 PM · Fundraising Tech - Chaos Crew, fr-donorservices, Fundraising-Backlog

Dec 18 2022

Sj awarded T280476: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 a Haypence token.
Dec 18 2022, 5:06 PM · Performance-Team (Radar), Readers-Web-Backlog, WMDE-FUN-Team, WMDE-Fundraising-Tech, Product-Infrastructure-Team-Backlog-Deprecated, MediaWiki-extensions-CentralNotice, Product-Design-Strategy, Design, SEO, Fundraising-Backlog
Sj awarded T280477: Study options and designs for banner formats to prevent search ranking decline a Cup of Joe token.
Dec 18 2022, 4:59 PM · Performance-Team (Radar), Wikimedia-CentralNotice-Administration, Wikimedia-Fundraising-Banners, Design, Fundraising-Backlog

Dec 16 2022

AndyRussG moved T325191: Write up medium term project outline for ESI+CentralNotice from Doing to Ready for Review on the Fundraising Sprint Wibbly Wobbly Timey Wimey board.
Dec 16 2022, 6:49 AM · Fundraising Sprint Amazing grep, Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising-Backlog
AndyRussG added a comment to T325191: Write up medium term project outline for ESI+CentralNotice.

https://docs.google.com/document/d/1hNmtrmeFACnvmQ5QhXY898Aen69X20YPiawVp7iqABk/edit?usp=sharing

Dec 16 2022, 6:48 AM · Fundraising Sprint Amazing grep, Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising-Backlog

Dec 15 2022

AndyRussG moved T325191: Write up medium term project outline for ESI+CentralNotice from Backlog to Doing on the Fundraising Sprint Wibbly Wobbly Timey Wimey board.
Dec 15 2022, 3:59 PM · Fundraising Sprint Amazing grep, Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising-Backlog
AndyRussG added a project to T325191: Write up medium term project outline for ESI+CentralNotice: Fundraising Sprint Wibbly Wobbly Timey Wimey.
Dec 15 2022, 3:59 PM · Fundraising Sprint Amazing grep, Fundraising Sprint Wibbly Wobbly Timey Wimey, Fundraising-Backlog

Dec 14 2022

AndyRussG added a comment to T287028: Docker dev setup: scope out use cases, requirements and command-line UI to replace setup.sh.

Here's a proposal for the command-line interface. Let's have a single base command, say, frdev, with various subcommands to perform specific actions.

Dec 14 2022, 3:34 AM · Fundraising Sprint Fish HEAD^, Fundraising Sprint Can't touch $this, FR-Docker, Fundraising-Backlog

Dec 12 2022

AndyRussG added a comment to T324860: Bug: duplicate Adyen transactions in short sequence.

I'm able to reproduce this, or something similar to this, locally, with the following procedure:

  • Open an Adyen cc form.
  • Fill in the form using test card info.
  • In the JavaScript console, execute:
$( '#paymentSubmitBtn' ).click(); $( '#paymentSubmitBtn' ).click(); $( '#paymentSubmitBtn' ).click();
Dec 12 2022, 5:10 AM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog

Dec 11 2022

AndyRussG moved T324860: Bug: duplicate Adyen transactions in short sequence from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
Dec 11 2022, 5:57 PM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog
AndyRussG claimed T324860: Bug: duplicate Adyen transactions in short sequence.
Dec 11 2022, 5:57 PM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog

Dec 9 2022

AndyRussG moved T324863: Update post-payments monthly convert threshold from Backlog to Completed 20221206-20230103 on the Fundraising Tech - Chaos Crew board.
Dec 9 2022, 11:40 PM · Fundraising Tech - Chaos Crew, MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Fundraising-Backlog
AndyRussG added a project to T324863: Update post-payments monthly convert threshold: Fundraising Tech - Chaos Crew.
Dec 9 2022, 11:40 PM · Fundraising Tech - Chaos Crew, MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Fundraising-Backlog
AndyRussG created T324860: Bug: duplicate Adyen transactions in short sequence.
Dec 9 2022, 4:58 PM · Patch-For-Review, Fundraising Tech - Chaos Crew, Fundraising-Backlog

Dec 7 2022

AndyRussG created T324715: Handle geolocation for direct links to Donate Wiki Special:LangingPage.
Dec 7 2022, 9:33 PM · Fundraising-Backlog

Dec 5 2022

AndyRussG added a comment to T143266: Improve documentation for emergency & on-call procedures.

Verify your ability to log in to external and internal services, including access to 2FA tools required to do so.

Do we have a list of what those are so people can verify?

Dec 5 2022, 3:46 PM · Fundraising Tech - Chaos Crew, Documentation, Fundraising-Backlog
AndyRussG moved T199055: &banner causes CSP warning from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.
Dec 5 2022, 6:04 AM · Patch-For-Review, Security, Fundraising-Backlog, User-revi, MediaWiki-extensions-CentralNotice