Thanks again @EMartin, @Pcoombe!!! The fix to this now is deployed to production, so everything should be working as expected. :)

Thanks so much for the detailed report @Pcoombe!! I can confirm that happens locally, too. Digging in now.

In T310406#8003819, @EMartin wrote:

@fr-tech. Can we get an update on this? Was it addressed in the sprint above? We are having difficulty working fraud without this. Thanks

I'd like to suggest a different approach from the one in the first linked patch and in the task description.

In T197463#7995711, @Esanders wrote:

> Hopefully this approach will be good enough for CN to be able to drop the expiry code.

In T197463#7995190, @Esanders wrote:

The kvStore does store expiry times (defaulting to 1/2year), but these just causes the data to be ignored once it has elapsed, and nothing gets deleted.

This could be resolved using actual expiry as implemented in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804591/

In T302949#7986178, @jgleeson wrote:

I'll also update fundraising-dev to add the changes needed to enable the gateway.

In T302949#7956422, @jgleeson wrote:

To Test:

> LocalSettings-private.php updates:
...

Noooooooo

I searched some recent logs for "Client side error", and found what seems like a relatively small number of errors, though many of the ones documented by @AnnWF here seem no longer to be occurring. (Thanks for that thorough research btw!! :) )

Checking a few UA strings on this site shows this is not Safari but Chrome. So far I've only seen version 100. That version is old but apparently still supported.

Follow-on to specify currency for min amount: T307880.

@AlexisJazz, @Tacsipacsi thanks so much for looking at this!

We did some stuff to the civicrm container and the db and got the export to run during tech-talk today! Very rough notes are here:

In T307178#7896590, @AndyRussG wrote:

@hashar thanks! Just to note, actually a previously passing change is now failing. Seems likely not to be a CI issue, though, still checking.

Quick update: @Ejegg confirmed this is indeed unrelated to CI. Thanks again!

@hashar thanks! Just to note, actually a previously passing change is now failing. Seems likely not to be a CI issue, though, still checking.

Thanks so much for all this, @hashar! So, looks like for now we have working CI with the rollback to Stretch. :) :)

Hi! Thanks for finding this. Fixed in this patch, which is now merged and scheduled for deploy. :)

"review +2" on this task! Thanks for all this!

Thanks so so much, @SCherukuwada, @jcrespo, @akosiaris, @Dzahn, @faidon , @MatthewVernon and everyone else who contributed to this! Hugely, hugely appreciated!!!!!! :) :)

Here are some UML activity diagrams for code that we could add to Varnish.
For a full solution that would inject banners directly into the base HTML, the logic would approximately follow diagrams (1) Campaign selection and (2) Banner selection and injection.
For a simplified solution that would only inject CSS code to reserve space for banners, as needed, the logic would follow diagrams (1) Campaign selection and (3) CSS selection and injection.

Thanks so much once again @SCherukuwada and @jcrespo for your careful attention to all these important details!!!! :) :)

Wooohooo thanks so much once again, everyone!!! :) :)

@matmarex I don't actually! So there was an attempt last night to deploy the revert, and the error is from some deployment test. I don't have any more details beyond what's linked there, I'm afraid.

Hey @matmarex @Ammarpad any idea how reverting this patch could have caused the following error:

In T300199#7734277, @RhinosF1 wrote:

If it only affects one wiki, there's no point blocking the train but we should see asap about getting it deployed.

In T300069#7734720, @Ammarpad wrote:

This is now reverted per T302469: Recent message fallback change breaks fundraising banners

Thanks so much @Urbanecm @RhinosF1 @Ammarpad! We'll dig in later today to figure out what caused the deploy to fail.

Hi! Not sure if this UBN bug is a train blocker, but the fix does need to be deployed to Meta (group 1) right away:
T302469: Recent message fallback change breaks fundraising banners

In T298733#7733287, @mpopov wrote:

As a reference point @jwang worked on this question in T297213: Analyze impact of page experience metrics on French Wikipedia during campaign (perhaps this is the work referenced by the statement "There is no concrete evidence that this is impacting our pageviews at the moment.")

In T298991#7725178, @MatthewVernon wrote:

@AndyRussG I'm making this "Stalled", and "Low" priority for now, since I think really you are talking to Legal and this task (which has appeared on my pile as SRE person on duty) doesn't need SRE action for now. We can adjust again later when this reflects something that needs SRE attention. I hope that's OK!

In T300164#7714313, @JAllemandou wrote:

I have started a job extracting daily pageviews with the dimensions discussed with @Mayakp.wiki.

Ahhhhhh oki so just one more thought that I guess might be worth sharing here... (Really hope this is useful, if not, many apologies, and in that case please ignore...!)

Ahhhh one more idea, hope it's useful...