Page MenuHomePhabricator

AndyRussG (Andrew Green)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 28 2014, 2:36 PM (282 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
AGreen (WMF) [ Global Accounts ]

Recent Activity

Wed, Mar 18

AndyRussG moved T246461: Prepare CN deploy 2020-03 from Backlog to Pending Deployment on the Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées board.
Wed, Mar 18, 4:07 PM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Tue, Mar 17

AndyRussG moved T246461: Prepare CN deploy 2020-03 from Backlog to Pending Deployment on the Fundraising Sprint Evil Twins For Everyone board.
Tue, Mar 17, 7:52 AM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG claimed T246461: Prepare CN deploy 2020-03.
Tue, Mar 17, 7:19 AM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Mon, Mar 16

AndyRussG added a comment to T246461: Prepare CN deploy 2020-03.

Hi! Here's some documentation I made about this process.

Mon, Mar 16, 4:42 PM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG claimed T246819: Add IDEAL to adyen front end.
Mon, Mar 16, 3:09 PM · Fundraising Sprint Evil Twins For Everyone, FR-Adyen, Fundraising-Backlog

Thu, Mar 12

AndyRussG reassigned T246819: Add IDEAL to adyen front end from AndyRussG to jgleeson.
Thu, Mar 12, 5:46 PM · Fundraising Sprint Evil Twins For Everyone, FR-Adyen, Fundraising-Backlog

Wed, Mar 11

AndyRussG claimed T246819: Add IDEAL to adyen front end.
Wed, Mar 11, 3:48 PM · Fundraising Sprint Evil Twins For Everyone, FR-Adyen, Fundraising-Backlog

Tue, Mar 10

AndyRussG added a comment to T246461: Prepare CN deploy 2020-03.

Also, before we merge master to wmf_deploy we should properly revert this change that was accidentally +2'ed only on the wmf_deploy. (We thought we'd reverted it but the revert patch in the end didn't merge because of CI. The version of the change on master is waiting for an update from the author.)

Tue, Mar 10, 7:30 AM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T246461: Prepare CN deploy 2020-03.
Tue, Mar 10, 7:23 AM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Wed, Mar 4

AndyRussG created T246863: Adapt DonationInterface to new method signatures and response objects for Adyen and Ingenico.
Wed, Mar 4, 5:20 AM · Fundraising Sprint Evil Twins For Everyone, MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), FR-Ingenico, FR-Adyen, Fundraising-Backlog
AndyRussG moved T246825: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders from Backlog to Pending Deployment on the Fundraising Sprint Evil Twins For Everyone board.
Wed, Mar 4, 5:17 AM · Fundraising Sprint Evil Twins For Everyone, Recurring-Donations, FR-Adyen, Fundraising-Backlog
AndyRussG set the point value for T246825: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders to 1.
Wed, Mar 4, 5:17 AM · Fundraising Sprint Evil Twins For Everyone, Recurring-Donations, FR-Adyen, Fundraising-Backlog
AndyRussG claimed T246825: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders.
Wed, Mar 4, 5:16 AM · Fundraising Sprint Evil Twins For Everyone, Recurring-Donations, FR-Adyen, Fundraising-Backlog
AndyRussG renamed T246825: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders from Normalize approvePayment method signatures responses for Ingenico and Adyen PaymentProviders to Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders.
Wed, Mar 4, 5:16 AM · Fundraising Sprint Evil Twins For Everyone, Recurring-Donations, FR-Adyen, Fundraising-Backlog
AndyRussG moved T242278: Update civi SmashPig extension to be able to charge Adyen recurring from Backlog to Doing on the Fundraising Sprint Evil Twins For Everyone board.
Wed, Mar 4, 5:15 AM · Patch-For-Review, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Dampness, Fundraising Sprint CAPS LOCK CULTS, Recurring-Donations, FR-Adyen, Fundraising-Backlog

Tue, Mar 3

AndyRussG created T246825: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders.
Tue, Mar 3, 8:36 PM · Fundraising Sprint Evil Twins For Everyone, Recurring-Donations, FR-Adyen, Fundraising-Backlog
AndyRussG added a subtask for T192564: [Epic] Banner history improvements: T236285: CentralNotice: Adapt banner history for campaign fallback.
Tue, Mar 3, 3:52 AM · Epic, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a parent task for T236285: CentralNotice: Adapt banner history for campaign fallback: T192564: [Epic] Banner history improvements.
Tue, Mar 3, 3:52 AM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Fri, Feb 28

AndyRussG created T246461: Prepare CN deploy 2020-03.
Fri, Feb 28, 4:50 PM · Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Evil Twins For Everyone, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 25 2020

AndyRussG moved T242278: Update civi SmashPig extension to be able to charge Adyen recurring from Backlog to Doing on the Fundraising Sprint Dampness board.
Feb 25 2020, 8:52 PM · Patch-For-Review, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Dampness, Fundraising Sprint CAPS LOCK CULTS, Recurring-Donations, FR-Adyen, Fundraising-Backlog
AndyRussG claimed T242278: Update civi SmashPig extension to be able to charge Adyen recurring.
Feb 25 2020, 8:52 PM · Patch-For-Review, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Dampness, Fundraising Sprint CAPS LOCK CULTS, Recurring-Donations, FR-Adyen, Fundraising-Backlog

Feb 18 2020

AndyRussG moved T245285: Whitelist CentralNotice banner history events for sanitization and long-term storage from Review to Pending Deployment on the Fundraising Sprint CAPS LOCK CULTS board.
Feb 18 2020, 9:14 PM · Analytics-Kanban, Analytics, Fundraising-Backlog
AndyRussG added a comment to T245285: Whitelist CentralNotice banner history events for sanitization and long-term storage.

There should be 90 days available now, but the sanitize_delayed job will start sanitizing from 45 days ago once refinery is deployed. @AndyRussG, do you need the 90-45 days old data to be manually sanitized into the event_sanitized database too, or is starting from 45 days ago ok.

Feb 18 2020, 5:01 PM · Analytics-Kanban, Analytics, Fundraising-Backlog
AndyRussG added a comment to T245285: Whitelist CentralNotice banner history events for sanitization and long-term storage.

This would take effect once we deploy it but Analytics needs to run a refine job from the begging of the data stream being available. cc @fdans (who has the ops week) and @Ottomata

Feb 18 2020, 4:33 PM · Analytics-Kanban, Analytics, Fundraising-Backlog
AndyRussG added a comment to T243092: Find a better way for WMDE to get impression counts for their banners.

if the sampling ratio of the data on that table is good enough then we can help you set up workflows to read from that table the banner counts in question.

Feb 18 2020, 3:41 PM · Analytics, WMDE-Analytics-Engineering, WMDE-Fundraising-Tech, Fundraising-Backlog, WMDE-FUN-Team
AndyRussG updated the task description for T244882: Requirements for banner history processing for segmentation based on site usage.
Feb 18 2020, 3:19 PM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG renamed T244882: Requirements for banner history processing for segmentation based on site usage from Requirements for banner history processing for segmentation based on site usage patterns to Requirements for banner history processing for segmentation based on site usage.
Feb 18 2020, 3:14 PM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG moved T245285: Whitelist CentralNotice banner history events for sanitization and long-term storage from Backlog to Review on the Fundraising Sprint CAPS LOCK CULTS board.
Feb 18 2020, 5:02 AM · Analytics-Kanban, Analytics, Fundraising-Backlog
AndyRussG added a project to T245285: Whitelist CentralNotice banner history events for sanitization and long-term storage: Analytics.
Feb 18 2020, 4:59 AM · Analytics-Kanban, Analytics, Fundraising-Backlog
AndyRussG added a comment to T244882: Requirements for banner history processing for segmentation based on site usage.

See also T192564: [Epic] Banner history improvements for some ideas we've had over the years on how to improve these logs.

Feb 18 2020, 4:30 AM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T244882: Requirements for banner history processing for segmentation based on site usage.

Just a few initial thoughts:

  • Pre-processing might include flagging logs as randomly sampled or sent following a click to donate.
  • Time zone and geographical region are probably needed. For the pageview on which the log was sent back, this is in the unsanitized Hive table. Better would be to have it for every entry in the log. In either case, legal review would probably be needed. See also T170559.
  • The article viewed is purposefully not included in the logs, though it would be possible to find this information for the pageview on which the log was sent to the servers, using the Hive WebRequest table.
Feb 18 2020, 4:28 AM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG updated the task description for T244882: Requirements for banner history processing for segmentation based on site usage.
Feb 18 2020, 4:18 AM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG added a comment to T244882: Requirements for banner history processing for segmentation based on site usage.

banner history has been white listed by the analytics team. See https://phabricator.wikimedia.org/T161656. According to Nuria banner data will be stored on events_sanitized just like it is done for other eventlogging schemas.
https://wikitech.wikimedia.org/wiki/Analytics/Systems/EventLogging/Data_retention_and_auto-purging#The_white-list

Feb 18 2020, 4:13 AM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
AndyRussG renamed T244882: Requirements for banner history processing for segmentation based on site usage from Requirements and investigation for banner history storage and usage to Requirements for banner history processing for segmentation based on site usage patterns.
Feb 18 2020, 4:12 AM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 14 2020

AndyRussG created T245285: Whitelist CentralNotice banner history events for sanitization and long-term storage.
Feb 14 2020, 5:20 PM · Analytics-Kanban, Analytics, Fundraising-Backlog

Feb 12 2020

AndyRussG added a comment to T244771: Refining is failing to refine centranoticeimpression events.

FYI, if you need a new datatype, you should just make a new field :) It isn't clear how you'd query a field that has two different types at different dates anyway. :)

Feb 12 2020, 5:23 PM · Analytics-Kanban, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Analytics

Feb 11 2020

AndyRussG added a comment to T244771: Refining is failing to refine centranoticeimpression events.

Hi! Thanks much, @Nuria, @Ottomata, @DStrine, @jkumalah :) Apologies for the delay in replying...

Feb 11 2020, 10:57 PM · Analytics-Kanban, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Analytics
AndyRussG created T244882: Requirements for banner history processing for segmentation based on site usage.
Feb 11 2020, 3:59 PM · Research, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 10 2020

AndyRussG added projects to T244771: Refining is failing to refine centranoticeimpression events: MediaWiki-extensions-CentralNotice, Fundraising-Backlog.
Feb 10 2020, 6:18 PM · Analytics-Kanban, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Analytics

Jan 29 2020

AndyRussG added a comment to T243356: Civi: January 2020 Ingenico recurrings processing in duplicate?.

Here are the queries we used for this:

Jan 29 2020, 10:18 PM · Fundraising Sprint Byzantine Empire Strikes Back, Recurring-Donations, Fundraising-Backlog
AndyRussG created P10290 T243356 Check no one will get double-charged 2020-01.
Jan 29 2020, 10:17 PM
AndyRussG updated the title for P10261 T243356 Find cases of early recurring 2020-01 from T243356 Find cases of early recurring 2019-01 to T243356 Find cases of early recurring 2020-01.
Jan 29 2020, 9:43 PM

Jan 24 2020

AndyRussG created P10262 T243356 Generate CSV for batch refund script.
Jan 24 2020, 5:23 PM
AndyRussG updated the title for P10261 T243356 Find cases of early recurring 2020-01 from T243356 Query to check for early recurring 2019-01 to T243356 Find cases of early recurring 2019-01.
Jan 24 2020, 5:22 PM
AndyRussG edited P10261 T243356 Find cases of early recurring 2020-01.
Jan 24 2020, 5:20 PM
AndyRussG created P10261 T243356 Find cases of early recurring 2020-01.
Jan 24 2020, 5:20 PM
AndyRussG moved T243356: Civi: January 2020 Ingenico recurrings processing in duplicate? from Backlog to Done on the Fundraising Sprint Byzantine Empire Strikes Back board.
Jan 24 2020, 5:18 PM · Fundraising Sprint Byzantine Empire Strikes Back, Recurring-Donations, Fundraising-Backlog

Jan 15 2020

AndyRussG added projects to T242895: Safari crashes on some click handling events for banners that move the centralNotice element outside of the the main body: MediaWiki-extensions-CentralNotice, Fundraising-Backlog.
Jan 15 2020, 5:57 PM · Readers-Web-Backlog (Tracking), Performance-Team (Radar), MinervaNeue (Tracking), Fundraising-Backlog, MediaWiki-extensions-CentralNotice
AndyRussG added a comment to T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.

To test the fix locally:

  • Set up two campaigns, one higher priority than the other.
  • Include a close button in the banner for the campaign with higher priority.
  • The higher priority campaign should always show, until the close button is clicked on the banner. On subsequent pageviews after the button has been clicked, the lower priority campaign should show.
  • To test again, clear cookies for the local wiki.
Jan 15 2020, 5:28 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review

Jan 13 2020

AndyRussG added a comment to T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.

@AndyRussG Okay, I can see what you mean. When I look at the loop what I see is that state.setCampaign is called early on and that should set the status to CAMPAIGN_CHOSEN for the campaign that gets selected. cancelBanner is called if hide.shouldHide() is true. Just recording my findings as I go.

Jan 13 2020, 4:20 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review

Jan 10 2020

AndyRussG added a comment to T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.

@AndyRussG Is there any documentation of what these status codes mean?

Jan 10 2020, 2:46 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review

Jan 7 2020

AndyRussG renamed T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden from Campaign fallen back to gets incorrect status code to Campaign fallen back to gets incorrect status code and may be incorrectly hidden.
Jan 7 2020, 9:17 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG claimed T236834: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline.
Jan 7 2020, 9:16 PM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog
AndyRussG added a comment to T183978: [Epic] Fundraising kafkatee changes.

Here's an overview of the status of this project:

Jan 7 2020, 8:05 PM · Epic, Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog
AndyRussG added a subtask for T183978: [Epic] Fundraising kafkatee changes: T242065: FRUEC: Ensure compatibility with legacy behaviour for missing and empty values, for all LandingPage event properties.
Jan 7 2020, 4:44 AM · Epic, Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog
AndyRussG added a parent task for T242065: FRUEC: Ensure compatibility with legacy behaviour for missing and empty values, for all LandingPage event properties: T183978: [Epic] Fundraising kafkatee changes.
Jan 7 2020, 4:44 AM · Fundraising-Backlog
AndyRussG created T242065: FRUEC: Ensure compatibility with legacy behaviour for missing and empty values, for all LandingPage event properties.
Jan 7 2020, 4:43 AM · Fundraising-Backlog

Jan 6 2020

AndyRussG added a comment to T237997: FRUEC: For legacy compatibility, empty language property should default to 'en' for LandingPage impressions.

Just updated the draft specification for this. We should also look at legacy default values for empty country and project fields.

Jan 6 2020, 8:52 PM · Fundraising-Backlog
AndyRussG added a comment to T236834: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline.

We've set up a new kafkatee collector host at codfw, frban2001, which will replace the aged alnitak once we're confident everything is working properly on Debian Buster etc. In the meantime it's useful for comparison, to help rule out losses in the kafka->kafkatee->logfile segment in the pipeline. I ran all of yesterdays new-pipeline landingpages json logs through a simple perl json decoder and observed that alnitak and frban2001 collected exactly the same data for 12/11. The script I used is at mintaka:/tmp/json-log-filter, and frban2001's log store is mounted at mintaka:/mnt/banner_logs_new. The beacon-impressions logs are harder to compare since they're sampled at 1:10, and the two hosts are expected to collect different messages. So we set frban1001 to collecting beacon-impressions 1:1 for a day, and at the end we'll compare what was collected to what's in Hive.

Jan 6 2020, 7:27 PM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog
AndyRussG added a parent task for T242022: Verify no losses in kafka->kafkatee->logfile data pipeline segment: T183978: [Epic] Fundraising kafkatee changes.
Jan 6 2020, 7:25 PM · Fundraising-Backlog
AndyRussG added a subtask for T183978: [Epic] Fundraising kafkatee changes: T242022: Verify no losses in kafka->kafkatee->logfile data pipeline segment.
Jan 6 2020, 7:25 PM · Epic, Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog
AndyRussG created T242022: Verify no losses in kafka->kafkatee->logfile data pipeline segment.
Jan 6 2020, 7:25 PM · Fundraising-Backlog

Jan 3 2020

AndyRussG added a subtask for T183978: [Epic] Fundraising kafkatee changes: T236834: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline.
Jan 3 2020, 4:51 PM · Epic, Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog
AndyRussG added a parent task for T236834: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline: T183978: [Epic] Fundraising kafkatee changes.
Jan 3 2020, 4:51 PM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog
AndyRussG added a subtask for T183978: [Epic] Fundraising kafkatee changes: T236835: FRUEC: Debug minor discrepancy in landing page data between old and new pipelines.
Jan 3 2020, 4:39 PM · Epic, Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Asymmetrical Earth Theory, Fundraising-Backlog
AndyRussG added a parent task for T236835: FRUEC: Debug minor discrepancy in landing page data between old and new pipelines: T183978: [Epic] Fundraising kafkatee changes.
Jan 3 2020, 4:39 PM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog

Dec 22 2019

AndyRussG moved T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden from Doing to Backlog on the Fundraising Sprint YAMLton, the Musical board.
Dec 22 2019, 7:42 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review

Dec 19 2019

AndyRussG renamed T241162: Turnilo no longer showing sample-rate adjusted data for banner activity from Turnilo no longer showing sample-rate adjusted data to Turnilo no longer showing sample-rate adjusted data for banner activity.
Dec 19 2019, 6:54 PM · Analytics-Kanban, Analytics, Fundraising-Backlog
AndyRussG created T241162: Turnilo no longer showing sample-rate adjusted data for banner activity.
Dec 19 2019, 6:27 PM · Analytics-Kanban, Analytics, Fundraising-Backlog

Dec 18 2019

AndyRussG created T241070: Server for previewing/usability testing new CentralNotice features.
Dec 18 2019, 3:40 PM · Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Dampness, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
AndyRussG placed T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden up for grabs.
Dec 18 2019, 3:33 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review

Dec 16 2019

AndyRussG claimed T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.
Dec 16 2019, 7:19 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG moved T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden from Backlog to Doing on the Fundraising Sprint YAMLton, the Musical board.
Dec 16 2019, 7:19 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG added a project to T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden: Fundraising Sprint YAMLton, the Musical.
Dec 16 2019, 5:23 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG edited P9870 T240802 Hive query for status codes.
Dec 16 2019, 5:22 AM
AndyRussG updated the task description for T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.
Dec 16 2019, 5:20 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG updated the task description for T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.
Dec 16 2019, 12:22 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG created P9870 T240802 Hive query for status codes.
Dec 16 2019, 12:22 AM
AndyRussG updated the task description for T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.
Dec 16 2019, 12:17 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review
AndyRussG created T240802: Campaign fallen back to gets incorrect status code and may be incorrectly hidden.
Dec 16 2019, 12:14 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Patch-For-Review

Dec 12 2019

AndyRussG moved T196563: Write a specification for mapping banner/landing page impression event properties -> database schema from Backlog to Pending Deployment on the Fundraising Sprint YAMLton, the Musical board.
Dec 12 2019, 1:15 AM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint Usual Subscripts, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Sysadmin Kane, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Princess Mongodb, Fundraising Sprint Office  , Fundraising Sprint Never Ending Query, Fundraising Sprint Men In Slack, Fundraising Sprint Land before Timeouts, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint They Live, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Owls, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog
AndyRussG moved T236834: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline from Backlog to Review on the Fundraising Sprint YAMLton, the Musical board.
Dec 12 2019, 1:15 AM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog
AndyRussG moved T236835: FRUEC: Debug minor discrepancy in landing page data between old and new pipelines from Backlog to Review on the Fundraising Sprint YAMLton, the Musical board.
Dec 12 2019, 1:15 AM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog
AndyRussG moved T237736: FRUEC: Raise error when timestamp not found in filename from Backlog to Review on the Fundraising Sprint YAMLton, the Musical board.
Dec 12 2019, 1:14 AM · Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Patch-For-Review, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog
AndyRussG moved T240505: Unbreak now (please) : newly broken CentralNotice admin interface from Backlog to Deployed on the Fundraising Sprint YAMLton, the Musical board.
Dec 12 2019, 1:14 AM · Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog

Dec 11 2019

AndyRussG added a comment to T240505: Unbreak now (please) : newly broken CentralNotice admin interface.

As per T219604, it's just the RL modules aliases that have changed, but the modules are still around, so we should be able to fix pretty easily.

Dec 11 2019, 9:38 PM · Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog
AndyRussG added a comment to T240505: Unbreak now (please) : newly broken CentralNotice admin interface.

jquery.ui.datepicker was removed in wmf.10, yes. wmf_deploy strikes yet again.

Dec 11 2019, 9:35 PM · Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog

Dec 7 2019

AndyRussG added a comment to T239922: XSS in fundraising banners.

Thanks again, @sbassett and @Bawolff!

Dec 7 2019, 5:48 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog

Dec 6 2019

AndyRussG added a comment to T239922: XSS in fundraising banners.

@Pcoombe Thanks so much for this fix!!! Looks great!

Dec 6 2019, 6:04 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog

Dec 5 2019

AndyRussG assigned T239922: XSS in fundraising banners to Pcoombe.
Dec 5 2019, 6:29 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG added a comment to T239922: XSS in fundraising banners.

In T239922#5715938, @Bawolff wrote:
an attacker could just edit a page to introduce the trigger code instead of relying on url based injection.

Dec 5 2019, 5:01 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG added a comment to T239922: XSS in fundraising banners.

@Pcoombe wrote (on IRC):
presumably the vulnerability is that code could be saved in a page. and they just used preloadtitle to avoid creating a page demonstrating it that anyone can see

Dec 5 2019, 4:58 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG added a comment to T239922: XSS in fundraising banners.

@Bawolff, if I understand correctly, this is dependent on the injection into the DOM of content using the preloadtitle URL parameter, correct? I was unaware of this Mediawiki feature... now looking at the doc for this...

Dec 5 2019, 4:49 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG updated the task description for T239922: XSS in fundraising banners.
Dec 5 2019, 3:49 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG added a comment to T239922: XSS in fundraising banners.

I assume since the example contains %AVERAGE% it's the following code (and a similar bit for replacing %MINIMUM%) that occurs in https://meta.wikimedia.org/wiki/MediaWiki:FundraisingBanners/LocalizeJS-2017.js and hence all our banners

Dec 5 2019, 3:49 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG added a comment to T239778: Security review of banner with FB and Twitter share buttons.

Ugh, thanks for finding that, @Bawolff. I'm going to break that out into a separate high/ubn ticket.
Filed: T239919

Dec 5 2019, 3:34 PM · secscrum, Security Readiness Reviews, Privacy Engineering, MediaWiki-extensions-CentralNotice, Privacy, Fundraising-Backlog
AndyRussG added a project to T239922: XSS in fundraising banners: Vuln-XSS.
Dec 5 2019, 3:30 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG added a comment to T239778: Security review of banner with FB and Twitter share buttons.

@Bawolff thank you so much for finding this!!!! This same code is in live FR banners across enwiki. I've created a separate task: T239922

Dec 5 2019, 3:28 PM · secscrum, Security Readiness Reviews, Privacy Engineering, MediaWiki-extensions-CentralNotice, Privacy, Fundraising-Backlog
AndyRussG added a comment to T239922: XSS in fundraising banners.

@Bawolff, thanks so much for finding this!!!!! Could you please confirm that this is the code in question, and explain a few more details about how it works?

Dec 5 2019, 3:25 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog
AndyRussG triaged T239922: XSS in fundraising banners as Unbreak Now! priority.
Dec 5 2019, 3:23 PM · Security, MediaWiki-extensions-CentralNotice, Vuln-XSS, Fundraising Sprint X-rays, Fundraising-Backlog