Just completed the logging setup for this. (See the updated repo.)
Tue, Oct 13
Mon, Oct 5
Here's a WIP repo for setting up Fundraising dev environment.
@kostajh thanks so much for this!
Sep 20 2020
Sep 18 2020
Sep 16 2020
Hi! Adding the MediaWiki-Docker tag for visibility and coordination with related projects...
Sep 15 2020
Sep 14 2020
Sep 8 2020
Also, if anyone's interested in the rough notes from work on this, here's the etherpad.
More fallback-related issues were also discovered in work on this bug. They are described here: T261718: More minor bugs introduced with campaign fallback. The cleanup patch only fixes the first of the issues mentioned in that task, though it does clear the way for fixing all of them.
Hi! The patches for this and the related cleanup task (mainly T232235) are ready for review.
Sep 1 2020
The attached patch addresses only the first issue in the description (bannersNotGuaranteedToDisplay not reset on new iteration of fallback loop).
The attached patch renames methods (the first part of this task) but doesn't rename statuses (the second part).
Aug 31 2020
Aug 20 2020
We'll also have to adapt the mixins that register hook handlers to be able to run multiple times, since they were written with the expectation that they could only run once per pageview. We should do this for both pre and post handlers.
Aug 19 2020
Aug 18 2020
Aug 17 2020
Aug 9 2020
Thanks again! :)
Aug 7 2020
Aug 1 2020
Hi! The changes in the task description are now available on production. @EMartin, could you please confirm that this works for you? Thanks so much!!!
Jul 28 2020
Thanks so much @Krinkle for the information on this!
Jul 24 2020
Andrew still has access to Phab so I'll ask him to comment here as confirmation.
Jul 22 2020
Jul 20 2020
Jul 15 2020
Jul 14 2020
Thanks so much, @Ejegg!
Jul 10 2020
One more option (thanks to @Jgreen for this idea): we could create a thank-you banner on Wikipedia. So, instead of going to the thank-you page on Donate Wiki, donors could be sent to Wikipedia with a banner= parameter in the URL to force the banner to appear. It could have the same content as the thank-you page and set the cookie to suppress further FR banners.
@Ejegg what about this option? We set a special cookie on donate.wikimedia.org when people go to the thank-you page, then include code in the banners to check it in the background before actually displaying the banner? I think that's in line with sort of flow for cross-site interactions that will still be allowed?
Just another idea for the shortest-term solution: in the banner, we could try to determine the user's browser version, and based on that, only set the hide cookie from within the banner if we think the browser won't tolerate the hide cookie being set in the background on the thank-you page.
He suggested we put the thank you page on a *.wikipedia.org domain rather than *.wikimedia.org, so it can set the cookie itself.
Jul 8 2020
Jul 7 2020
Adding Traffic and Operations tags to ask for input about how Varnish caching for this new redirecting special page. Please see the attached patch.
Thanks @tstarling! As it turns out, current and upcoming browser restrictions on third-party cookies are quickly making cross-site banner hiding unworkable.