Page MenuHomePhabricator

{{filepath}} does not deliver full URL
Closed, ResolvedPublic

Description

Author: accnospamtom

Description:
Instead of the full URL it only shows the part after Server.

Example from our Wiki:

{{filepath:Wiki.png}}

delivers : /images/b/bc/Wiki.png
should be: http://kamelopedia.mormo.org/images/b/bc/Wiki.png

r80813 broke it [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/parser/CoreParserFunctions.php?r1=80512&r2=80813&sortby=date]

line 639: $url = $file->getUrl();
I think should be: $url = $file->getFullUrl();

Sorry for my poor english ;)


Version: 1.18.x
Severity: critical

Details

Reference
bz28618

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:33 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz28618.

Assigning to Krinkle because he broke this.

I also added wfExpandUrl.

See http://translatewiki.net/w/i.php?title=Sandbox&oldid=2941239 for comparison.

Only local non-thumb are affected.

I remember there was a reason I changed it to getUrl, but I believe it's no longer relevant.

Fixed in r86788.

(In reply to comment #2)

I also added a wfExpandUrl.

I meant that I added it in the initial commit in January (r80813).