Copy button in Codex demos copies extra newline in Chrome
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Apr 20 2022, 9:45 PM

Description

When I go to https://doc.wikimedia.org/codex/main/design-tokens/color.html using Chrome on Ubuntu, and I click the "Copy" button next to e.g. color-base--hover, the string that is copied to my clipboard has a newline at the start (i.e."\ncolor-base--hover").

This doesn't happen in Firefox. It seems like it might be caused by the complex code that tries to make this work in older iOS versions; the code mentions not being able to use textarea.select(); for that reason, but if I use that instead of range.selectNodeContents( textarea ); the bug goes away.

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v0.1.0-alpha.9 to v0.1.0-alpha.10	mediawiki/core	master	+261 -112
	CopyTextButton: Use Clipboard API when available to copy code	design/codex	main	+27 -1

Customize query in gerrit

Related Objects

Mentioned In: T311244: Lower the burden of contributing code to Codex

Event Timeline

Catrope created this task.Apr 20 2022, 9:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2022, 9:45 PM

Our use of document.execCommand( 'copy' ) might need to be reconsidered, since it is marked as deprecated, https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand

Perhaps instead we should use the Clipboard api? https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API

• STH triaged this task as Low priority.Apr 30 2022, 5:45 PM

• STH added a project: good first task.

• STH moved this task from Inbox to Backlog on the Design-System-Team board.

Change 822479 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[design/codex@main] CopyTextButton: Use Clipboard API when available to copy code

https://gerrit.wikimedia.org/r/822479

gerritbot added a project: Patch-For-Review.Aug 13 2022, 5:35 PM

abi_ mentioned this in T311244: Lower the burden of contributing code to Codex.Aug 14 2022, 4:48 AM

Catrope closed this task as Resolved.Aug 15 2022, 9:10 PM

Catrope assigned this task to abi_.

Change 822479 merged by jenkins-bot:

[design/codex@main] CopyTextButton: Use Clipboard API when available to copy code

https://gerrit.wikimedia.org/r/822479

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 9:30 PM

Change 823725 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.1.0-alpha.9 to v0.1.0-alpha.10

https://gerrit.wikimedia.org/r/823725

gerritbot added a project: Patch-For-Review.Aug 16 2022, 8:13 PM

Change 823725 merged by jenkins-bot: