Don't accept an employer field that's just numbers
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Ejegg
	Apr 21 2022, 4:34 PM

Description

It's down near the CC field on forms where it appears. Make sure people aren't putting their card numbers in there by doing client-side validation and rejecting anything that's just numbers, spaces and hyphens.

Details

	Subject	Repo	Branch	Lines +/-
	Add validation to employers field with test	mediawiki/extensions/DonationInterface	master	+75 -0

Customize query in gerrit

Event Timeline

Ejegg created this task.Apr 21 2022, 4:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2022, 4:34 PM

Context: it's only happened a few times, but I think it'll get more frequent if we start using Adyen in the US. We've mostly only used the employer field with Ingenico, and that form disables the contact info before it shows the card field.

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Apr 25 2022, 7:45 PM

Dwisehaupt set the point value for this task to 2.May 9 2022, 8:40 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.May 10 2022, 8:36 PM

• DStrine added a project: Fundraising Sprint Incantation optimisation.May 10 2022, 8:45 PM

Damilare claimed this task.May 11 2022, 10:31 AM

Damilare moved this task from Backlog to Doing on the Fundraising Sprint Incantation optimisation board.

• DStrine triaged this task as Medium priority.May 11 2022, 4:08 PM

Change 791078 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] WIP: Add validation to employers field

https://gerrit.wikimedia.org/r/791078

gerritbot added a project: Patch-For-Review.May 11 2022, 8:45 PM

Damilare moved this task from Doing to Review on the Fundraising Sprint Incantation optimisation board.May 12 2022, 2:37 PM

Change 791078 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add validation to employers field with test

https://gerrit.wikimedia.org/r/791078

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Incantation optimisation board.May 16 2022, 4:12 PM

Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 17 2022, 8:00 AM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Incantation optimisation board.May 18 2022, 12:02 AM

XenoRyet closed this task as Resolved.May 24 2022, 7:19 PM

XenoRyet set Final Story Points to 2.

Don't accept an employer field that's just numbersClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Event Timeline

Don't accept an employer field that's just numbers
Closed, ResolvedPublic2 Estimated Story Points
Actions