Page MenuHomePhabricator
Create Task
Maniphest T307201

🟪️ Handle Item redirects in GET /entities/items/{item_id}/statements
Closed, ResolvedPublic
Actions

Description

  • handle the redirect in the route handler and return a redirect response object containing the redirect target id
  • in GetItemStatementsRouteHandler return a 308 and set the location header accordingly

Details

SubjectRepoBranchLines +/-
REST: Extract shared ItemRedirectResponse classmediawiki/extensions/Wikibasemaster+18 -36
REST: Extract createRedirectForItem helpermediawiki/extensions/Wikibasemaster+21 -16
REST: Handle redirects in GetItemStatementsRouteHandlermediawiki/extensions/Wikibasemaster+47 -8
REST: Handle redirects in GetItemStatements use casemediawiki/extensions/Wikibasemaster+38 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Apr 29 2022, 11:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2022, 11:10 AM
Silvan_WMDE mentioned this in T305988: 🟪️ Create an initial implementation of GET /entities/items/{item_id}/statements.Apr 29 2022, 2:31 PM
Jakob_WMDE renamed this task from Handle Item redirects in GET /entities/items/{item_id}/statements to 🟧 Handle Item redirects in GET /entities/items/{item_id}/statements.Apr 29 2022, 2:34 PM
Jakob_WMDE renamed this task from 🟧 Handle Item redirects in GET /entities/items/{item_id}/statements to 🟪️ Handle Item redirects in GET /entities/items/{item_id}/statements.Apr 29 2022, 2:37 PM
Silvan_WMDE claimed this task.May 10 2022, 6:45 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 5) board.
Silvan_WMDE removed Silvan_WMDE as the assignee of this task.May 10 2022, 10:23 AM
Silvan_WMDE moved this task from Doing to To Do on the Wikibase Product Platform (v1) (Sprint 5) board.
Silvan_WMDE subscribed.
Jakob_WMDE claimed this task.May 11 2022, 10:03 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 5) board.
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 6); removed Wikibase Product Platform (v1) (Sprint 5).May 11 2022, 12:04 PM
WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 6) board.
gerritbot added a comment.May 11 2022, 2:19 PM

Change 791037 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Handle redirects in GetItemStatements use case

https://gerrit.wikimedia.org/r/791037

gerritbot added a project: Patch-For-Review.May 11 2022, 2:19 PM
gerritbot added a comment.May 11 2022, 2:44 PM

Change 791041 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Handle redirects in GetItemStatementsRouteHandler

https://gerrit.wikimedia.org/r/791041

gerritbot added a comment.May 11 2022, 3:09 PM

Change 791043 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extact createRedirectForItem helper

https://gerrit.wikimedia.org/r/791043

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 6) board.May 12 2022, 1:41 PM
gerritbot added a comment.May 13 2022, 8:10 AM

Change 791557 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extract shared ItemRedirectResponse class

https://gerrit.wikimedia.org/r/791557

gerritbot added a comment.May 13 2022, 8:28 AM

Change 791037 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle redirects in GetItemStatements use case

https://gerrit.wikimedia.org/r/791037

gerritbot added a comment.May 13 2022, 8:29 AM

Change 791041 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle redirects in GetItemStatementsRouteHandler

https://gerrit.wikimedia.org/r/791041

gerritbot added a comment.May 13 2022, 9:45 AM

Change 791043 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract createRedirectForItem helper

https://gerrit.wikimedia.org/r/791043

gerritbot added a comment.May 13 2022, 11:04 AM

Change 791557 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract shared ItemRedirectResponse class

https://gerrit.wikimedia.org/r/791557

Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 6) board.May 13 2022, 12:47 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 13 2022, 4:00 PM
WMDE-leszek closed this task as Resolved.May 25 2022, 12:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL