Page MenuHomePhabricator
Create Task
Maniphest T307906

Drop revision_actor_temp in production
Closed, ResolvedPublic
Actions

Description

We have stopped writing to this table in most wikis and there is no fireworks so far. We should slowly start dropping the table.

I suggest first dropping it in mediawikiwiki (and one host in codfw only, then one host in eqiad, etc.).

I will write here once we stop writing to it everywhere (very likely tomorrow)

Progress

  • s1 (renamed - dropped)
  • s2 (renamed - dropped)
  • s3 (renamed - dropped)
  • s4 (renamed - dropped)
  • s5 (renamed - dropped)
  • s6 (renamed - dropped)
  • s7 (renamed - dropped)
  • s8 (renamed - dropped)
  • labtestwiki

Related Objects
Search...

Event Timeline

Ladsgroup created this task.May 9 2022, 11:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2022, 11:48 AM
• Marostegui claimed this task.May 9 2022, 11:49 AM
• Marostegui triaged this task as High priority.
• Marostegui moved this task from Triage to In progress on the DBA board.

I will take care of this dangerous task :)

• Marostegui updated the task description. (Show Details)EditedMay 10 2022, 5:03 AM

Going to rename this on db2109 (mediawikiwiki) where the table hasn't been written for days:

root@db2109:~# ls -lh /srv/sqldata/mediawikiwiki/revision_actor_temp.ibd
-rw-r----- 1 mysql mysql 432M May  5 18:38 /srv/sqldata/mediawikiwiki/revision_actor_temp.ibd
• Marostegui added a comment.May 10 2022, 5:05 AM
mysql:root@localhost [mediawikiwiki]> set session sql_log_bin=0; rename table revision_actor_temp to T307906_revision_actor_temp;
Query OK, 0 rows affected (0.000 sec)

Query OK, 0 rows affected (0.006 sec)

mysql:root@localhost [mediawikiwiki]>
Stashbot added a comment.May 10 2022, 5:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-10T05:18:17Z] <marostegui> dbmaint s3@codfw T307906

Stashbot added a comment.May 10 2022, 5:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-10T05:18:36Z] <marostegui> Rename revision_actor_temp on db2109 T307906

LSobanski subscribed.May 10 2022, 7:29 AM
Ladsgroup added a comment.May 10 2022, 8:15 AM

Update: We stopped writing to it everywhere now.

• Marostegui added a comment.May 10 2022, 8:47 AM

Excellent, I am going to rename it on an enwiki codfw host then

Stashbot added a comment.May 10 2022, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-10T08:48:24Z] <marostegui> dbmaint s1@codfw T307906

Stashbot added a comment.May 10 2022, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-10T08:48:28Z] <marostegui> Rename revision_actor_temp on db2092 T307906

• Marostegui added a comment.May 10 2022, 8:48 AM
root@db2092.codfw.wmnet[enwiki]> set session sql_log_bin=0; rename table revision_actor_temp to T307906_revision_actor_temp;
Query OK, 0 rows affected (0.032 sec)

Query OK, 0 rows affected (0.035 sec)

root@db2092.codfw.wmnet[enwiki]>
• Marostegui updated the task description. (Show Details)May 11 2022, 6:00 AM
• Marostegui updated the task description. (Show Details)
• Marostegui added a comment.May 11 2022, 7:08 AM

Just checked all the masters:
s1 last write: May 10 08:19
s2 last write: May 10 08:22
s3 last write: May 10 08:09
s4 last write: May 9 04:50
s5 last write: May 10 10:37
s6 last write: May 10 08:57
s7 last write: May 10 09:02
s8 last write: May 9 05:48

Stashbot added a comment.May 11 2022, 8:12 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-11T08:12:57Z] <marostegui> Rename revision_actor_temp on db1132 (s1) and db1114 (s8) T307906

• Marostegui added a comment.May 11 2022, 8:14 AM

I have renamed the table on db1132 (s1) and db1114 (s8). If there are any reads we will see them failing on logstash:

root@db1114.eqiad.wmnet[wikidatawiki]> set session sql_log_bin=0; rename table revision_actor_temp to T307906_revision_actor_temp;
Query OK, 0 rows affected (0.000 sec)

Query OK, 0 rows affected (0.005 sec)
root@db1132.eqiad.wmnet[enwiki]> set session sql_log_bin=0; rename table revision_actor_temp to T307906_revision_actor_temp;
Query OK, 0 rows affected (0.000 sec)

Query OK, 0 rows affected (0.023 sec)
• Marostegui updated the task description. (Show Details)May 11 2022, 8:15 AM
• Marostegui updated the task description. (Show Details)
• Marostegui updated the task description. (Show Details)
• Marostegui added a comment.May 24 2022, 5:08 AM

There were no errors on the hosts were the table was renamed, so I am going to go ahead and rename it everywhere in s6.

Stashbot added a comment.May 24 2022, 5:11 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-24T05:11:11Z] <marostegui> Rename revision_actor_temp on s6 T307906

• Marostegui updated the task description. (Show Details)May 24 2022, 5:11 AM
• Marostegui added a comment.May 24 2022, 6:07 AM

Dropped in labtestwiki

mysql:root@localhost [labtestwiki]> drop table revision_actor_temp;
Query OK, 0 rows affected (0.076 sec)
• Marostegui updated the task description. (Show Details)May 24 2022, 6:07 AM
Stashbot added a comment.May 24 2022, 6:08 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-24T06:08:09Z] <marostegui> Rename revision_actor_temp on s8 T307906

• Marostegui added a comment.May 24 2022, 6:08 AM

Renamed entirely on s8 as well.

• Marostegui updated the task description. (Show Details)May 24 2022, 6:08 AM
Stashbot added a comment.May 25 2022, 4:57 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-25T04:57:04Z] <marostegui> Rename revision_actor_temp on s4 T307906

• Marostegui added a comment.May 25 2022, 4:57 AM

Renamed on s4 (testcommonswiki and commonswiki)

• Marostegui updated the task description. (Show Details)May 25 2022, 4:57 AM
Stashbot added a comment.May 25 2022, 5:03 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-25T05:03:12Z] <marostegui> Rename revision_actor_temp on s2 T307906

• Marostegui added a comment.May 25 2022, 5:03 AM

Renamed on all s2 wikis

• Marostegui updated the task description. (Show Details)May 25 2022, 5:03 AM
Stashbot added a comment.May 25 2022, 5:14 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-25T05:14:49Z] <marostegui> Rename revision_actor_temp on s7 T307906

• Marostegui added a comment.May 25 2022, 5:16 AM

Renamed on all s7 wikis

• Marostegui updated the task description. (Show Details)May 25 2022, 5:17 AM
Stashbot added a comment.May 25 2022, 5:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-25T05:18:41Z] <marostegui> Rename revision_actor_temp on s5 T307906

• Marostegui added a comment.May 25 2022, 5:29 AM

Renamed on all s5 wikis

• Marostegui updated the task description. (Show Details)May 25 2022, 5:30 AM
Stashbot added a comment.May 25 2022, 5:30 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-25T05:30:44Z] <marostegui> Rename revision_actor_temp on s1 T307906

• Marostegui added a comment.May 25 2022, 5:30 AM

Renamed on s1

• Marostegui updated the task description. (Show Details)May 25 2022, 5:31 AM
• Marostegui added a comment.May 25 2022, 8:40 AM

Starting to rename it across s3, it will take around 8 hours to finish.

• Marostegui updated the task description. (Show Details)May 26 2022, 5:26 AM
In T307906#7955718, @Marostegui wrote:

Starting to rename it across s3, it will take around 8 hours to finish.

This finished - I will drop it for good next week.

• Marostegui added a comment.May 30 2022, 5:26 AM

I have seen no errors on logstash so I am going to start proceeding with the deletion of the renamed table.

Stashbot added a comment.May 30 2022, 5:26 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T05:26:23Z] <marostegui> Drop renamed revision_actor_temp on s6 T307906

• Marostegui updated the task description. (Show Details)May 30 2022, 5:27 AM
Stashbot added a comment.May 30 2022, 5:28 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T05:28:42Z] <marostegui> Drop renamed revision_actor_temp on s2 T307906

• Marostegui updated the task description. (Show Details)May 30 2022, 5:33 AM
Stashbot added a comment.May 30 2022, 6:01 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T06:01:14Z] <marostegui> Drop renamed revision_actor_temp on s7 T307906

• Marostegui updated the task description. (Show Details)May 30 2022, 6:05 AM
Stashbot added a comment.May 30 2022, 6:10 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T06:10:20Z] <marostegui> Drop renamed revision_actor_temp on s5 T307906

• Marostegui updated the task description. (Show Details)May 30 2022, 6:33 AM
Stashbot added a comment.May 30 2022, 6:36 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T06:36:42Z] <marostegui> Drop renamed revision_actor_temp on s8 T307906

• Marostegui updated the task description. (Show Details)May 30 2022, 6:36 AM
Stashbot added a comment.May 30 2022, 6:39 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T06:39:08Z] <marostegui> Drop renamed revision_actor_temp on s4 T307906

• Marostegui updated the task description. (Show Details)May 30 2022, 6:39 AM
Stashbot added a comment.May 30 2022, 12:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-30T12:34:13Z] <marostegui> Drop renamed revision_actor_temp on s3 T307906

• Marostegui added a comment.May 30 2022, 12:34 PM

Started the drop on s3's master, it will take around 8h.

• Marostegui updated the task description. (Show Details)May 31 2022, 4:58 AM
In T307906#7967165, @Marostegui wrote:

Started the drop on s3's master, it will take around 8h.

Done

• Marostegui updated the task description. (Show Details)May 31 2022, 5:03 AM
• Marostegui closed this task as Resolved.May 31 2022, 6:26 AM
• Marostegui updated the task description. (Show Details)

This is all done

Maintenance_bot moved this task from In progress to Done on the DBA board.May 31 2022, 6:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL