Page MenuHomePhabricator

Table of Contents breaks tabs on max-width pages
Closed, DuplicatePublic

Description

With the Table of Contents config enabled, the top tabs are obscured on pages with max-width set (i.e. those specified by $wgVectorMaxWidthOptions and having body.skin-vector-disable-max-width).

This is with Vector version 7eb818543e78990f6ca62827ae61b6999448b084.

The following screenshots are from /index.php?title=Test&action=history.

With $wgVectorTableOfContents = false;With $wgVectorTableOfContents = true;
ToC open:
Screenshot 2022-05-17 at 10-17-14 Test Revision history - Dev wiki1.png (253×794 px, 31 KB)
This is the error.
Screenshot 2022-05-17 at 10-20-22 Test Revision history - Dev wiki1.png (252×624 px, 32 KB)
ToC closed:
Screenshot 2022-05-17 at 10-17-44 Test Revision history - Dev wiki1.png (263×634 px, 24 KB)
Screenshot 2022-05-17 at 10-20-04 Test Revision history - Dev wiki1.png (254×544 px, 21 KB)

Bug originally found by @TheresNoTime in T307725#7930783.

Event Timeline

The above screenshots are from 7eb818543e78990f6ca62827ae61b6999448b084 which includes that patch, and the problem still exists.

Jdlrobson added a subscriber: ovasileva.

Thanks for confirming. I can now see this impacts French Wikipedia:
https://fr.wikipedia.org/w/index.php?title=Test&action=history

@ovasileva presumably this will be a non-issue when we roll out the A/B test to French and Portuguese but we should fix it if there's a possibility they we will want to disable the table of contents post-A/B test