Vector 2022 sidebar overlaps links in the article toolbar when table of contents is disabled
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	abi_
	May 11 2022, 1:30 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Make sure the table of contents is disabled

$wgVectorTableOfContents = [
	'default' => false,
];

Go to Special:RecentChanges
Expand the vector-2022 sidebar on the top left

What happens?:

Notice that the "Special page" tab link is hidden under the Article toolbar

What should have happened instead?:

The tab should be visible.

Screenshots

Sidebar expanded	Sidebar collapsed

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

MediaWiki 1.39.0-alpha
Vector (master)
Firefox 99 on Linux

Technical details
Possibly caused by: rSVEC8d1dbab356e8: Merge "Simplify TOC spacing styles/logic by reusing the visible sticky header…

QA steps

IN production

Can be replicated on https://translatewiki.net/w/i.php?title=Special:LanguageStats&useskin=vector-2022

QA Results - Prod

AC	Status	Details
1	✅	T308130#7981687

Details

	Subject	Repo	Branch	Lines +/-
	Fixes Vector 2022 sidebar overlap when table of contents disabled	mediawiki/skins/Vector	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T308841: top tabs are not are not displayed correctly on History pages
Mentioned Here: rSVEC8d1dbab356e8: Merge "Simplify TOC spacing styles/logic by reusing the visible sticky header…

Event Timeline

abi_ created this task.May 11 2022, 1:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2022, 1:30 PM

TheresNoTime updated the task description. (Show Details)May 11 2022, 4:11 PM

Nikerabbit added a project: Desktop Improvements (Vector 2022).May 11 2022, 4:29 PM

Nikerabbit added a subscriber: bwang.

The issue is on https://translatewiki.net/w/i.php?hidebots=1&translations=filter&limit=50&days=7&enhanced=1&title=Special:RecentChanges&useskin=vector-2022&urlversion=2 but I can't replicate this on current master. What version of Vector is TranslateWiki running? I recall an old bug relating to this so I'm fairly confident this is a duplicate.

We just updated to latest master today and that introduced the problem. In my testing and comparing to beta cluster, at translatewiki.net we don't have the vector-toc-enabled class in the HTML which seems to add the margin.

Thanks that context was helpful. I can reproduce this now and this is most likely a recent regression so I've added it to our sprint board.

Change 791064 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Fixes Vector 2022 sidebar overlap when table of contents disabled

https://gerrit.wikimedia.org/r/791064

gerritbot added a project: Patch-For-Review.May 11 2022, 6:06 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 11 2022, 6:06 PM

Jdlrobson triaged this task as High priority.May 23 2022, 5:13 PM

LGoto set the point value for this task to 2.May 23 2022, 5:39 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 23 2022, 11:12 PM

Change 791064 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fixes Vector 2022 sidebar overlap when table of contents disabled

https://gerrit.wikimedia.org/r/791064

Maintenance_bot removed a project: Patch-For-Review.May 24 2022, 12:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 24 2022, 1:00 AM

Jdlrobson assigned this task to Edtadros.May 24 2022, 1:01 AM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Una_tantum mentioned this in T308841: top tabs are not are not displayed correctly on History pages.May 24 2022, 3:57 PM

Aklapper merged a task: T308841: top tabs are not are not displayed correctly on History pages.May 25 2022, 6:33 AM

Aklapper added a subscriber: Una_tantum.

@Jdlrobson I was unable to recreate this yesterday on the production link in the description. I'm not sure if the fix had already made because I don't know much about translatewiki and where it would be on the train. I tried firefox, on macos, but that didn't show the issue. Do you think this is a linux specific issue?

In T308130#7960560, @Edtadros wrote:

@Jdlrobson I was unable to recreate this yesterday on the production link in the description. I'm not sure if the fix had already made because I don't know much about translatewiki and where it would be on the train. I tried firefox, on macos, but that didn't show the issue. Do you think this is a linux specific issue?

The latest patch from @Jdlrobson was deployed yesterday to translatewiki.net and it has fixed the issue.

Yep as @_abi says it should be impossible to replicate this bug now in either production or beta cluster so I think we can just confirm this with a screenshot and move to sign off.

Jdlrobson merged a task: T308510: Table of Contents breaks tabs on max-width pages.May 27 2022, 4:08 PM

Jdlrobson added subscribers: Samwilson, ovasileva, TheresNoTime.

Test Result - Prod

Status: ✅ PASS
Environment: translatewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Translate tab should be visible with sidebar expanded and collapsed.

Screen Shot 2022-06-05 at 5.30.09 PM.png (521×713 px, 56 KB)

Screen Shot 2022-06-05 at 5.30.27 PM.png (523×706 px, 81 KB)

Edtadros updated the task description. (Show Details)Jun 6 2022, 12:34 AM

ovasileva closed this task as Resolved.Jun 6 2022, 7:48 AM

	F35210148: Screen Shot 2022-06-05 at 5.30.09 PM.png
	Jun 6 2022, 12:33 AM

	F35210149: Screen Shot 2022-06-05 at 5.30.27 PM.png
	Jun 6 2022, 12:33 AM

Vector 2022 sidebar overlaps links in the article toolbar when table of contents is disabledClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions