Page MenuHomePhabricator

MarkThisAgain message is used instead of MarkThis for non-translatable pages with translate tags
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce:

  • Visit a page which has never been marked for translation, but which now contains some <translate> tags. You may find a such page in “Pages proposed for translation” at Special:PageTranslation.
  • Look at top headline added by Translate.

What happens?:
If you are logged in as Translation admin: you will see “This page has changes since it was last marked for translation.
Else, you will see “This page contains changes which are not marked for translation.

What should have happened instead?:
If you are logged in as Translation admin: you should see “Mark this page for translation
Else, you should see [I don’t know what messages used to be displayed].

Regression of 7cdab19513ed, I think.

Related Objects

Event Timeline

abi_ changed the task status from Open to In Progress.May 19 2022, 5:21 AM
abi_ claimed this task.
abi_ triaged this task as High priority.
abi_ set the point value for this task to 1.May 19 2022, 8:13 AM

Change 793209 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Fix message in the header of page not yet marked for translation

https://gerrit.wikimedia.org/r/793209

Change 793209 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix message in the header of page not yet marked for translation

https://gerrit.wikimedia.org/r/793209

This is fixed. Tested on MediaWiki.org

image.png (429×801 px, 43 KB)

Nikerabbit renamed this task from MarkThisAgain message is used instead of MarkThis for non-translatable pages whith translate tags to MarkThisAgain message is used instead of MarkThis for non-translatable pages with translate tags.Jun 2 2022, 6:33 AM