Maniphest T308849

flake8 test fails with C417:
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	May 20 2022, 11:47 AM

Tags

Referenced Files

None

Subscribers

pywikibot-bugs-list

Description

List of steps to reproduce:
Run flake8 CI test with Python 3.8

What happens?:
https://integration.wikimedia.org/ci/job/pywikibot-core-tox-docker/19363/console

Test fails with this message
./pywikibot/page/_links.py: line 822:15: C417 Unnecessary use of map - use a set comprehension instead.

What to do?
C417 test was introduced with flake8-comprehensions 3.10.0 yesterday. The related line is 822 in ./pywikibot/page/_links.py.
The C417 issue and how to solve it is described at https://pypi.org/project/flake8-comprehensions/#description.

Software version:
Python 3.8+

Details

	Subject	Repo	Branch	Lines +/-
	[flake8] use set comprehension instead of map	pywikibot/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Xqt	T308849 flake8 test fails with C417:
		Resolved	BUG REPORT	Xqt	T308879 WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails

Event Timeline

Xqt created this task.May 20 2022, 11:47 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMay 20 2022, 11:47 AM

Xqt triaged this task as High priority.May 20 2022, 11:47 AM

Xqt moved this task from Backlog to Projects for Newcomers! on the Wikimedia-Hackathon-2022 board.May 20 2022, 11:50 AM

SrCerberus subscribed.May 20 2022, 1:19 PM

Change 793850 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [flake8] use set comprehension instead of map

https://gerrit.wikimedia.org/r/793850

gerritbot added a project: Patch-For-Review.May 20 2022, 4:44 PM

Xqt claimed this task.May 20 2022, 4:58 PM

Xqt added a subtask: T308879: WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails.May 20 2022, 6:29 PM

Change 793850 merged by jenkins-bot:

[pywikibot/core@master] [flake8] use set comprehension instead of map

https://gerrit.wikimedia.org/r/793850

Xqt closed this task as Resolved.May 21 2022, 1:15 AM

Xqt removed a project: Patch-For-Review.

Xqt changed the status of subtask T308879: WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails from Open to Stalled.May 21 2022, 1:19 AM

Urbanecm changed the status of subtask T308879: WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails from Stalled to Open.May 21 2022, 10:15 AM

Xqt closed subtask T308879: WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails as Resolved.May 21 2022, 12:41 PM