WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	May 20 2022, 5:11 PM

Description

List of steps to reproduce
pwb pagegenerators_tests -v WikibaseItemFilterPageGeneratorTestCase

What happens?:

tests: max_retries reduced from 15 to 1
test_filter_pages_with_item (__main__.WikibaseItemFilterPageGeneratorTestCase)
Test WikibaseItemFilterPageGenerator on pages with item. ... ok
test_filter_pages_without_item (__main__.WikibaseItemFilterPageGeneratorTestCase)
Test WikibaseItemFilterPageGenerator on pages without item. ... FAIL

======================================================================
FAIL: test_filter_pages_without_item (__main__.WikibaseItemFilterPageGeneratorTestCase)
Test WikibaseItemFilterPageGenerator on pages without item.
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\tests\pagegenerators_tests.py", line 677, in test_filter_pages_without_item
    self.assertLength(list(gen), 0)
  File "C:\pwb\GIT\core\tests\aspects.py", line 127, in assertLength
    self.fail(msg)
AssertionError: len([Page('Talk:Main Page')]) != 0

----------------------------------------------------------------------
Ran 2 tests in 2.502s

FAILED (failures=1)

Reason:

with https://www.wikidata.org/w/index.php?title=Q112079466&action=history the item page was created as Q112079466

Software version:
Tested with Pywikibot 7.1-7.3

Details

	Subject	Repo	Branch	Lines +/-
	Revert "[tests] ignore failing pg test until WD item was deleted"	pywikibot/core	master	+0 -1
	[tests] ignore failing pg test until WD item was deleted	pywikibot/core	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	BUG REPORT	Xqt	T308849 flake8 test fails with C417:
Resolved	BUG REPORT	Mpaa	T302804 log entries in log files should not contain color format strings
Resolved	BUG REPORT	Xqt	T308879 WikibaseItemFilterPageGeneratorTestCase.test_filter_pages_without_item fails

Event Timeline

Xqt created this task.May 20 2022, 5:11 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMay 20 2022, 5:11 PM

Xqt triaged this task as High priority.May 20 2022, 5:12 PM

Xqt updated the task description. (Show Details)May 20 2022, 5:21 PM

Xqt moved this task from Backlog to Projects for Newcomers! on the Wikimedia-Hackathon-2022 board.

Xqt added a project: good first task.

This would be solved after deletion:
https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Q112079466

Until this is done, the test should be decorated with @unittest.expectedFailure
https://docs.python.org/3/library/unittest.html?highlight=expectedfailure#unittest.expectedFailure

Xqt added a parent task: T308849: flake8 test fails with C417: .May 20 2022, 6:29 PM

Xqt added a parent task: T302804: log entries in log files should not contain color format strings.May 20 2022, 11:47 PM

Change 793792 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] ignore failing pg test until WD item was deleted

https://gerrit.wikimedia.org/r/793792

gerritbot added a project: Patch-For-Review.May 20 2022, 11:58 PM

Change 793792 merged by Xqt:

[pywikibot/core@master] [tests] ignore failing pg test until WD item was deleted

https://gerrit.wikimedia.org/r/793792

Xqt changed the task status from Open to Stalled.May 21 2022, 1:19 AM

Maintenance_bot removed a project: Patch-For-Review.May 21 2022, 1:30 AM

In T308879#7945368, @Xqt wrote:

This would be solved after deletion:
https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Q112079466

I've deleted the item. Reopening the task.

Change 793793 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Revert "[tests] ignore failing pg test until WD item was deleted"

https://gerrit.wikimedia.org/r/793793

gerritbot added a project: Patch-For-Review.May 21 2022, 10:19 AM

Xqt closed this task as Resolved.May 21 2022, 12:41 PM

Xqt claimed this task.

Change 793793 merged by jenkins-bot: