Page MenuHomePhabricator

Improve comments in mediawiki-config about IPInfo
Closed, ResolvedPublic1 Estimated Story Points

Description

We should:

  • Remove an outdated comment saying that IPInfo access should be revoked from beta admins before deploying to production. (This is no longer the case, as explained in T270347#7851971.)
  • Add a comment to CommonSettings.php explaining that IPInfo access should not be updated without getting approval from Legal first, to avoid violating our contract with MaxMind

Event Timeline

Change 793848 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Remove outdated comment about IPInfo from CommonSettings-labs.php

https://gerrit.wikimedia.org/r/793848

Change 793849 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Add comment to consult Legal before updating IPInfo access

https://gerrit.wikimedia.org/r/793849

  • Add a comment to CommonSettings.php explaining that IPInfo access should not be updated without getting approval from Legal first, to avoid violating our contract with MaxMind

@Niharika - should this say Legal or AHT?

@Niharika also see T263263 and T288844 . That is where we added the Maxmind license used for these additional databases. The request and license was provided by AH.

fwiw: I don't think we can actually violate the contract. If we added databases we don't have a license for or it expires.. it would just fail to fetch those databases and alert us about it.

Change 793848 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove outdated comment about IPInfo from CommonSettings-labs.php

https://gerrit.wikimedia.org/r/793848

Mentioned in SAL (#wikimedia-operations) [2022-05-24T20:08:55Z] <cjming@deploy1002> Synchronized wmf-config/CommonSettings-labs.php: Config: [[gerrit:793848|Remove outdated comment about IPInfo from CommonSettings-labs.php (T308876)]] (duration: 00m 49s)

Change 793849 merged by jenkins-bot:

[operations/mediawiki-config@master] Add comment to consult Legal before updating IPInfo access

https://gerrit.wikimedia.org/r/793849

Mentioned in SAL (#wikimedia-operations) [2022-05-24T20:54:48Z] <cjming@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:793849|Add comment to consult Legal before updating IPInfo access (T308876)]] (duration: 00m 52s)

Having spoken with @Niharika, the Legal team were advising on who could access IPInfo without violating our contract with MaxMind. (The concern is rights being given too widely to access the currently-available databases.)

  • Add a comment to CommonSettings.php explaining that IPInfo access should not be updated without getting approval from Legal first, to avoid violating our contract with MaxMind

@Niharika - should this say Legal or AHT?

Yup! While the AHT team is in charge of handing out the rights, it is the Legal team who are advising on who can access the information, conforming with the ToS for MaxMind. So we should keep "Legal" in the wording.