Page MenuHomePhabricator

PHP Notice: Undefined property: stdClass::$page_restrictions
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined property: stdClass::$page_restrictions
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(835)
#0 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(835): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Threads.php(84): Thread::bulkLoad(array)
#2 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Threads.php(97): Threads::loadFromResult(Wikimedia\Rdbms\MysqliResultWrapper, Wikimedia\Rdbms\DBConnRef, boolean)
#3 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Threads.php(169): Threads::where(array, array, boolean)
#4 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(1255): Threads::withId(string)
#5 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(980): Thread->topmostThread()
#6 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(710): Thread->doLazyUpdates()
#7 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(638): Thread->__construct(stdClass)
#8 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php(854): Thread::newFromRow(stdClass)
#9 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Threads.php(84): Thread::bulkLoad(array)
#10 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Threads.php(97): Threads::loadFromResult(Wikimedia\Rdbms\MysqliResultWrapper, Wikimedia\Rdbms\DBConnRef, boolean)
#11 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Threads.php(154): Threads::where(array, array, boolean)
#12 /srv/mediawiki/php-1.39.0-wmf.13/extensions/LiquidThreads/classes/LqtHooks.php(913): Threads::withRoot(WikiPage)
#13 /srv/mediawiki/php-1.39.0-wmf.13/includes/HookContainer/HookContainer.php(338): LqtHooks::onGetUserPermissionsErrors(Title, User, string, string)
#14 /srv/mediawiki/php-1.39.0-wmf.13/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#15 /srv/mediawiki/php-1.39.0-wmf.13/includes/HookContainer/HookRunner.php(1949): MediaWiki\HookContainer\HookContainer->run(string, array)
#16 /srv/mediawiki/php-1.39.0-wmf.13/includes/Permissions/PermissionManager.php(550): MediaWiki\HookContainer\HookRunner->onGetUserPermissionsErrors(Title, User, string, string)
#17 /srv/mediawiki/php-1.39.0-wmf.13/includes/Permissions/PermissionManager.php(508): MediaWiki\Permissions\PermissionManager->checkPermissionHooks(string, User, array, string, boolean, Title)
#18 /srv/mediawiki/php-1.39.0-wmf.13/includes/Permissions/PermissionManager.php(298): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal(string, User, Title, string, boolean)
#19 /srv/mediawiki/php-1.39.0-wmf.13/includes/Permissions/UserAuthority.php(290): MediaWiki\Permissions\PermissionManager->userCan(string, User, Title, string)
#20 /srv/mediawiki/php-1.39.0-wmf.13/includes/Permissions/UserAuthority.php(208): MediaWiki\Permissions\UserAuthority->internalCan(string, string, Title, NULL)
#21 /srv/mediawiki/php-1.39.0-wmf.13/includes/user/User.php(3729): MediaWiki\Permissions\UserAuthority->authorizeRead(string, Title, NULL)
#22 /srv/mediawiki/php-1.39.0-wmf.13/includes/api/ApiFeedContributions.php(236): User->authorizeRead(string, Title)
#23 /srv/mediawiki/php-1.39.0-wmf.13/includes/api/ApiFeedContributions.php(208): ApiFeedContributions->feedItem(stdClass)
#24 /srv/mediawiki/php-1.39.0-wmf.13/includes/api/ApiMain.php(1900): ApiFeedContributions->execute()
#25 /srv/mediawiki/php-1.39.0-wmf.13/includes/api/ApiMain.php(874): ApiMain->executeAction()
#26 /srv/mediawiki/php-1.39.0-wmf.13/includes/api/ApiMain.php(845): ApiMain->executeActionWithErrorHandling()
#27 /srv/mediawiki/php-1.39.0-wmf.13/api.php(90): ApiMain->execute()
#28 /srv/mediawiki/php-1.39.0-wmf.13/api.php(45): wfApiMain()
#29 /srv/mediawiki/w/api.php(3): require(string)
#30 {main}
Impact
Notes

Seems to be caused by the drop for page.page_restrictions.

Event Timeline

Change 800985 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/LiquidThreads@master] Stop trying to pass legacy page_restrictions to RestrictionStore

https://gerrit.wikimedia.org/r/800985

Change 800705 had a related patch set uploaded (by Ladsgroup; author: Zabe):

[mediawiki/extensions/LiquidThreads@wmf/1.39.0-wmf.13] Stop trying to pass legacy page_restrictions to RestrictionStore

https://gerrit.wikimedia.org/r/800705

Change 800985 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Stop trying to pass legacy page_restrictions to RestrictionStore

https://gerrit.wikimedia.org/r/800985

Change 800705 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@wmf/1.39.0-wmf.13] Stop trying to pass legacy page_restrictions to RestrictionStore

https://gerrit.wikimedia.org/r/800705

Mentioned in SAL (#wikimedia-operations) [2022-05-30T08:40:53Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.13/extensions/LiquidThreads/classes/Thread.php: Backport: [[gerrit:800705|Stop trying to pass legacy page_restrictions to RestrictionStore (T309460)]] (duration: 00m 47s)

Ladsgroup assigned this task to Zabe.