Page MenuHomePhabricator
Create Task
Maniphest T310091

Updates for Xcode 14
Closed, ResolvedPublic
Actions

Description

Update project so that:

  • Project builds to device and simulator in Xcode 14
  • There are no warnings in Xcode 14
  • Project deploys via our build server Jenkins Deploy and Experimenal jobs with Xcode 14 (Note: as of June 7th, build server currently has Xcode 14 beta 1).

We should not merge these project fixes into main until we are sure the next release will be built with the Xcode 14 GM. But until then we can keep a separate ongoing branch with this work over the summer for testing.

Notes for QA

Just a general regression test needed in the app for this.

Related Objects

Event Timeline

Tsevener created this task.Jun 7 2022, 6:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2022, 6:02 PM
Tsevener added a comment.Jun 7 2022, 6:04 PM

Some initial tweaks are in the xcode-14-building branch, though commit 7c8e3eb2ab should be re-evaluated to be sure it's the proper fix.

LGoto triaged this task as Medium priority.Jun 13 2022, 6:37 PM
LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
LGoto added a project: ios-app-v7.0.
Tsevener moved this task from Tasks from Product Backlog to Needs Engineering Sync on the ios-app-v7.0 board.Jul 19 2022, 4:38 PM
Tsevener moved this task from Needs Engineering Sync to Ready for Development on the ios-app-v7.0 board.Aug 10 2022, 6:21 PM
• JMinor edited projects, added ios-app-v7.1; removed ios-app-v7.0.Aug 16 2022, 9:11 PM
Tsevener claimed this task.Sep 14 2022, 7:51 PM
Tsevener edited projects, added ios-app-v7.0; removed ios-app-v7.1.
Tsevener moved this task from Ready for Development to Doing on the ios-app-v7.0 board.
Tsevener mentioned this in T317901: Speed up incremental build times by using input files.Sep 15 2022, 4:59 PM
Tsevener mentioned this in T317905: Fix priority inversion console warnings in Xcode 14.Sep 15 2022, 5:50 PM
Tsevener added a comment.Sep 15 2022, 9:36 PM

https://github.com/wikimedia/wikipedia-ios/pull/4323

Tsevener removed Tsevener as the assignee of this task.Sep 15 2022, 9:36 PM
Tsevener moved this task from Doing to Needs Code Review on the ios-app-v7.0 board.
Tsevener updated the task description. (Show Details)
Tsevener edited projects, added iOS-app-v6.9.3; removed ios-app-v7.0.Sep 20 2022, 7:18 PM
Tsevener moved this task from Tasks from Product Backlog to Needs QA on the iOS-app-v6.9.3 board.
Tsevener moved this task from Needs QA to Needs Testing Criteria on the iOS-app-v6.9.3 board.Sep 20 2022, 8:32 PM
Tsevener moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v6.9.3 board.Sep 26 2022, 9:22 PM
ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.9.3 board.Sep 29 2022, 6:22 PM
ABorbaWMF subscribed.

Looks good to me on 6.9.3 (1980) and some earlier 6.9.3 versions tested as well.

• JMinor closed this task as Resolved.Oct 18 2022, 9:04 PM
• JMinor claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL