Page MenuHomePhabricator
Create Task
Maniphest T311037

PHP Notice: Uninitialized string offset: 0
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Uninitialized string offset: 0
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(183)
#0 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(183): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(186): Kartographer\SimpleStyleParser->sanitize(stdClass)
#2 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(178): Kartographer\SimpleStyleParser->sanitize(stdClass)
#3 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(186): Kartographer\SimpleStyleParser->sanitize(array)
#4 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(178): Kartographer\SimpleStyleParser->sanitize(stdClass)
#5 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(92): Kartographer\SimpleStyleParser->sanitize(array)
#6 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(79): Kartographer\SimpleStyleParser->normalizeAndSanitize(array)
#7 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/SimpleStyleParser.php(58): Kartographer\SimpleStyleParser->parseObject(array)
#8 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/ApiSanitizeMapData.php(74): Kartographer\SimpleStyleParser->parse(string)
#9 /srv/mediawiki/php-1.39.0-wmf.16/extensions/Kartographer/includes/ApiSanitizeMapData.php(59): Kartographer\ApiSanitizeMapData->sanitizeJson(Title, string)
#10 /srv/mediawiki/php-1.39.0-wmf.16/includes/api/ApiMain.php(1901): Kartographer\ApiSanitizeMapData->execute()
#11 /srv/mediawiki/php-1.39.0-wmf.16/includes/api/ApiMain.php(875): ApiMain->executeAction()
#12 /srv/mediawiki/php-1.39.0-wmf.16/includes/api/ApiMain.php(846): ApiMain->executeActionWithErrorHandling()
#13 /srv/mediawiki/php-1.39.0-wmf.16/api.php(90): ApiMain->execute()
#14 /srv/mediawiki/php-1.39.0-wmf.16/api.php(45): wfApiMain()
#15 /srv/mediawiki/w/api.php(3): require(string)
#16 {main}
Notes

May be related to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Kartographer/+/802891 Force empty properties to be JSON serialized as an object for T308560

Found 1 occurrence this morning while checking logs before the train deployment. It is most certainly due to user input. The log entry had referrer https://de.wikipedia.org/wiki/H%C3%A4selbach_(Wei%C3%9Fer_Kocher)?veaction=edit

Either the POST happened while editing or is a result of the following diff https://de.wikipedia.org/w/index.php?title=H%C3%A4selbach_(Wei%C3%9Fer_Kocher)&type=revision&diff=223870802&oldid=221919402&diffmode=source

<mapframe latitude="48.813491" longitude="10.147719" zoom="15" width="434" height="263" align="left">
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {
        "fill": "#0000ff",
        "title": "Quellweiher"
      },
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
            [
              10.155684,
              48.811483
            ],
            [
              10.155695,
              48.811509
            ],
            [
              10.155813,
              48.811591
            ],
            [
              10.15592,
              48.811642
            ],
            [
              10.156033,
              48.811651
            ],
            [
              10.156127,
              48.811652
            ],
            [
              10.156188,
              48.811621
            ],
            [
              10.15621,
              48.811578
            ],
            [
              10.15618,
              48.811518
            ],
            [
              10.156087,
              48.811453
            ],
            [
              10.155891,
              48.811354
            ],
            [
              10.155845,
              48.811351
            ],
            [
              10.155684,
              48.811483
            ]
          ]
        ]
      }
    },
    {
      "type": "Feature",
      "properties": {
        "title": "Hauptlauf",
        "stroke": "#0000ff",
        "stroke-width": 3
      },
      "geometry": {
        "type": "LineString",
        "coordinates": [
          [
            10.155751,
            48.811425
          ],
          [
            10.155448,
            48.811308
          ],
          [
            10.155083,
            48.811202
          ],
          [
            10.154829,
            48.811126
          ],
          [
            10.154646,
            48.811093
          ],
          [
            10.154083,
            48.811008
          ],
          [
            10.153868,
            48.810969
          ],
          [
            10.153635,
            48.810907
          ],
          [
            10.153498,
            48.810906
          ],
          [
            10.153361,
            48.810879
          ],
          [
            10.153225,
            48.810826
          ],
          [
            10.153176,
            48.810823
          ],
          [
            10.152822,
            48.81099
          ],
          [
            10.152101,
            48.811336
          ],
          [
            10.151336,
            48.8117
          ],
          [
            10.151063,
            48.811831
          ],
          [
            10.150937,
            48.812028
          ],
          [
            10.150768,
            48.812118
          ],
          [
            10.150628,
            48.812237
          ],
          [
            10.150108,
            48.812581
          ],
          [
            10.150034,
            48.812638
          ],
          [
            10.149785,
            48.812717
          ],
          [
            10.149519,
            48.812836
          ],
          [
            10.149026,
            48.813087
          ],
          [
            10.148956,
            48.813394
          ],
          [
            10.148945,
            48.813546
          ],
          [
            10.148865,
            48.813638
          ],
          [
            10.148682,
            48.813698
          ],
          [
            10.148645,
            48.813786
          ],
          [
            10.148709,
            48.813853
          ],
          [
            10.148768,
            48.813969
          ],
          [
            10.14865,
            48.814047
          ],
          [
            10.148682,
            48.814146
          ],
          [
            10.147384,
            48.814393
          ],
          [
            10.146075,
            48.814623
          ],
          [
            10.144734,
            48.814859
          ],
          [
            10.144702,
            48.814933
          ],
          [
            10.144579,
            48.815039
          ],
          [
            10.144208,
            48.815145
          ],
          [
            10.143892,
            48.815194
          ],
          [
            10.143806,
            48.81518
          ],
          [
            10.14372,
            48.815127
          ],
          [
            10.143495,
            48.81512
          ],
          [
            10.143361,
            48.815145
          ],
          [
            10.143264,
            48.815269
          ],
          [
            10.143173,
            48.815336
          ],
          [
            10.142996,
            48.815442
          ],
          [
            10.14283,
            48.815509
          ],
          [
            10.142637,
            48.815523
          ],
          [
            10.142438,
            48.815579
          ],
          [
            10.142256,
            48.81565
          ],
          [
            10.142148,
            48.815886
          ],
          [
            10.142106,
            48.815943
          ],
          [
            10.142047,
            48.816095
          ],
          [
            10.141939,
            48.816239
          ],
          [
            10.141676,
            48.816412
          ],
          [
            10.141564,
            48.816564
          ],
          [
            10.141655,
            48.816695
          ],
          [
            10.141827,
            48.81685
          ],
          [
            10.14202,
            48.816967
          ]
        ]
      }
    },
    {
      "type": "Feature",
      "properties": {
        "title": "Seeausleitungsrinne 2",
        "stroke": "#0000ff",
        "stroke-width": 3
      },
      "geometry": {
        "type": "LineString",
        "coordinates": [
          [
            10.14903,
            48.813087
          ],
          [
            10.148952,
            48.813073
          ],
          [
            10.148828,
            48.813074
          ],
          [
            10.148614,
            48.81312
          ],
          [
            10.148397,
            48.813205
          ],
          [
            10.148311,
            48.81324
          ],
          [
            10.148279,
            48.813268
          ],
          [
            10.148308,
            48.813297
          ],
          [
            10.148415,
            48.813291
          ],
          [
            10.148485,
            48.813279
          ],
          [
            10.148504,
            48.813307
          ],
          [
            10.148493,
            48.813355
          ],
          [
            10.148437,
            48.813482
          ],
          [
            10.148418,
            48.813561
          ],
          [
            10.148496,
            48.813784
          ],
          [
            10.148659,
            48.81404
          ]
        ]
      }
    },
    {
      "type": "Feature",
      "properties": {
        "title": "Seeausleitungsrinne 1",
        "stroke": "#0000ff",
        "stroke-width": 3
      },
      "geometry": {
        "type": "LineString",
        "coordinates": [
          [
            10.149027,
            48.813088
          ],
          [
            10.148877,
            48.81314
          ],
          [
            10.14881,
            48.813235
          ],
          [
            10.148775,
            48.813305
          ],
          [
            10.148533,
            48.813385
          ],
          [
            10.148474,
            48.813404
          ]
        ]
      }
    },
    {
      "type": "Feature",
      "properties": {
        "title": "Ehemaliger Mühlkanal",
        "stroke": "#0000ff",
        "stroke-width": 3
      },
      "geometry": {
        "type": "LineString",
        "coordinates": [
          [
            10.15003,
            48.81264
          ],
          [
            10.14988,
            48.812836
          ],
          [
            10.149681,
            48.813201
          ],
          [
            10.149585,
            48.813371
          ],
          [
            10.149319,
            48.813688
          ],
          [
            10.149016,
            48.813936
          ],
          [
            10.148794,
            48.814089
          ],
          [
            10.148684,
            48.814146
          ]
        ]
      }
    },
    {
      "type": "Feature",
      "properties": {
          "fill": "#0000ff",
        "title": "Mühlweiher"
      },
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
            [
              10.148973,
              48.813039
            ],
            [
              10.149341,
              48.812853
            ],
            [
              10.149652,
              48.812638
            ],
            [
              10.149805,
              48.812618
            ],
            [
              10.149934,
              48.812626
            ],
            [
              10.150027,
              48.812648
            ],
            [
              10.149883,
              48.812749
            ],
            [
              10.149164,
              48.8131
            ],
            [
              10.149056,
              48.813118
            ],
            [
              10.149011,
              48.813123
            ],
            [
              10.148971,
              48.813081
            ],
            [
              10.148973,
              48.813039
            ]
          ]
        ]
      }
    }
  ]
}
</mapframe>

Details

Request URL
https://de.wikipedia.org/w/api.php
SubjectRepoBranchLines +/-
Fix "uninitialized string offset" error on empty stringsmediawiki/extensions/Kartographermaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Jun 21 2022, 7:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2022, 7:43 AM
hashar mentioned this in T308560: Map is broken after adding a line manually in VE.Jun 21 2022, 7:47 AM
thiemowmde added a project: WMDE-TechWish-Maintenance.Jun 21 2022, 8:11 AM
gerritbot added a comment.Jun 21 2022, 9:13 AM

Change 807070 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix "uninitialized string offset" error on empty strings

https://gerrit.wikimedia.org/r/807070

gerritbot added a project: Patch-For-Review.Jun 21 2022, 9:13 AM
thiemowmde claimed this task.Jun 21 2022, 9:13 AM
thiemowmde added projects: Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-06-08.
thiemowmde set the point value for this task to 1.
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-06-08 board.
gerritbot added a comment.Jun 21 2022, 9:39 AM

Change 807070 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix "uninitialized string offset" error on empty strings

https://gerrit.wikimedia.org/r/807070

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 21 2022, 10:00 AM
thiemowmde closed this task as Resolved.Jun 21 2022, 10:13 AM
thiemowmde moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-08 board.
thiemowmde removed a project: Patch-For-Review.
Krinkle moved this task from Untriaged to Jun 2022 on the Wikimedia-production-error board.Jun 23 2022, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL