[Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language"
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Pixel caught an unexpected UI change in the languages sidebar:

Screen Shot 2022-06-24 at 10.40.36 AM.png (1×2 px, 250 KB)

The sidebar heading has changed from languages to "In other language". We are loading modern templates inside the legacy Vector skin and have broken an integration point with ULS.

Details

	Subject	Repo	Branch	Lines +/-
	Technical: Use unambigious menu template	mediawiki/skins/Vector	master	+28 -26

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jun 24 2022, 5:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2022, 5:46 PM

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Jun 24 2022, 5:46 PM

Change 808336 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use unambigious menu template

https://gerrit.wikimedia.org/r/808336

gerritbot added a project: Patch-For-Review.Jun 25 2022, 12:21 AM

This was caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/803976 which switched the h3 to a p in legacy Vector. ULS has some JavaScript that overrides this.

We're loading the wrong templates in legacy so I think to be on the safe side we should fix this before the train rolls.

Jdlrobson added a project: UniversalLanguageSelector.Jun 25 2022, 12:27 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

• santhosh subscribed.Jun 27 2022, 5:27 AM

ovasileva subscribed.Jun 27 2022, 10:32 AM

ovasileva assigned this task to Jdrewniak.Jun 27 2022, 5:51 PM

ovasileva set the point value for this task to 2.

Jdlrobson removed Jdrewniak as the assignee of this task.Jun 27 2022, 5:51 PM

Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson added a subscriber: Jdrewniak.

Change 808336 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Technical: Use unambigious menu template

https://gerrit.wikimedia.org/r/808336

Skipping QA as this can be verified using pixel
https://pixel.wmcloud.org/reports/desktop/index.html

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2022, 8:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 27 2022, 9:00 PM

We're down to 6 UI regressions on https://pixel.wmcloud.org/reports/desktop/index.html which are expected

	F35272347: Screen Shot 2022-06-24 at 10.41.40 AM.png
	Jun 24 2022, 5:46 PM

	F35272338: Screen Shot 2022-06-24 at 10.40.36 AM.png
	Jun 24 2022, 5:46 PM

[Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language"Closed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

Details

Event Timeline

[Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language"
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions