Page MenuHomePhabricator
Create Task
Maniphest T311718

Regression: unchecking the last parameter in a template causes the next part to be selected
Closed, InvalidPublic
Actions

Description

Should leave the recently unchecked parameter still selected.

Details

SubjectRepoBranchLines +/-
Don't select following part when removed is last parametermediawiki/extensions/VisualEditormaster+8 -2
Customize query in gerrit

Event Timeline

awight created this task.Jun 30 2022, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2022, 1:37 PM
awight updated the task description. (Show Details)Jun 30 2022, 1:39 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:26 PM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 1 2022, 10:04 AM
lilients_WMDE renamed this task from Regression: removing the last parameter in a template causes the next part to be selected to Regression: unchecking the last parameter in a template causes the next part to be selected.Jul 4 2022, 4:36 PM
gerritbot added a comment.Jul 4 2022, 8:49 PM

Change 810974 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Don't select following part when removed is last parameter

https://gerrit.wikimedia.org/r/810974

gerritbot added a project: Patch-For-Review.Jul 4 2022, 8:49 PM
WMDE-Fisch claimed this task.Jul 4 2022, 8:52 PM
WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.
WMDE-Fisch closed this task as Invalid.Jul 5 2022, 10:04 AM

The selection should just be removed when parameters are unchecked.

gerritbot added a comment.Jul 5 2022, 10:05 AM

Change 810974 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] Don't select following part when removed is last parameter

Reason:

Ticket is invalid. The selection should just be removed when parameters are unchecked.

https://gerrit.wikimedia.org/r/810974

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2022, 10:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL