Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in EventBus
Closed, DeclinedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Ottomata subscribed.

I'm looking now, and I'm not aware of any IDatabase::select usage in the EventBus extension. Declining for now, please reopen if I am wrong.