Page MenuHomePhabricator

Regression: unchecking a parameter causes the parameter selection to focus and starts keyboard navigation mode
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Open the template dialog and select a template or wikitext part:

image.png (376×408 px, 29 KB)

  • Click in a parameter's checkbox to unselect it:

image.png (459×496 px, 39 KB)

What happens:

  • The parameter select list is focused and keyboard navigation begins. This is strange because it's the only case in which this happens: clicking the checkbox or label to add a parameter do not focus the select list.
  • If the previous selection was outside of the parameter list, then the first element of the list is highlighted and cursor keys will move the selection starting from there. This causes wacky scrolling if the first parameter wasn't already visible (more about that in a new task).

Event Timeline

Change 813631 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Don't call parent on SelectWidget focus event

https://gerrit.wikimedia.org/r/813631

Change 813631 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't call parent on SelectWidget focus event

https://gerrit.wikimedia.org/r/813631

Change 814161 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Don't fire selection events for deleted parameters

https://gerrit.wikimedia.org/r/814161

thiemowmde claimed this task.