Communication/coordination work: Selecting participant does not work correctly when using shift-selection
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jul 14 2022, 6:27 PM

Description

See T313077, if you try to shift-select participants, things won't be updated correctly. Since we cannot disable shift-selection for V0, we should communicate on this in T313077 with appropriate maintainers/contributors [who will we need to figure out].

Details

	Subject	Repo	Branch	Lines +/-
	Disable shift-selection of participants on Special:MyEvents	mediawiki/extensions/CampaignEvents	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: T313124: Re-enable shift-selection of participants when it works properly with OOUI checkboxes
Mentioned Here: T313077: checkboxShift.js is incompatible with OOUI checkboxes

Event Timeline

Daimona created this task.Jul 14 2022, 6:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2022, 6:27 PM

Daimona mentioned this in T313124: Re-enable shift-selection of participants when it works properly with OOUI checkboxes.Jul 15 2022, 1:22 PM

Change 814166 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Disable shift-selection of participants on Special:MyEvents

https://gerrit.wikimedia.org/r/814166

gerritbot added a project: Patch-For-Review.Jul 15 2022, 1:23 PM

Change 814166 abandoned by Daimona Eaytoy:

[mediawiki/extensions/CampaignEvents@master] Disable shift-selection of participants on Special:MyEvents

Reason:

https://gerrit.wikimedia.org/r/814166

Huh, checkboxShift.js only cares about classes on the input and CheckboxInputWidget does not let you set classes on the input. Aaaaaaaaalrighty then.

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2022, 1:30 PM

ifried renamed this task from Selecting participant does not work correctly when using shift-selection to Communication/coordination work: Selecting participant does not work correctly when using shift-selection.Jul 19 2022, 3:41 PM

ifried updated the task description. (Show Details)

ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-17); removed Campaign-Tools (Campaign-Tools-Sprint-16).Jul 20 2022, 1:28 AM

Daimona moved this task from Ready 🎬 to Blocked ⛔ on the Campaign-Tools (Campaign-Tools-Sprint-17) board.Jul 26 2022, 6:03 PM

ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools (Campaign-Tools-Sprint-17).Aug 14 2022, 9:29 PM

ldelench_wmf moved this task from Needs Input / Design in progress to Blocked ⛔ on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Aug 14 2022, 9:38 PM

ldelench_wmf claimed this task.Sep 7 2022, 9:14 PM

Hey @ifried , I'm picking up this task to figure out who can help us - would you say the shift+select issue is a hard requirement for darkship? Or v1?

No, @ldelench_wmf, this isn't a hard requirement for V1. Thanks!

@ldelench_wmf I'm not sure what we should do with this task now. Should it be closed because the communicaton part is done? Or should we use it to track the specific bug in the CE extension? In any case, I think we need a task for our sprint board (mostly for QA).

Good call @Daimona , resolving this one - also pushed T313077 into our sprint board/code review.

Communication/coordination work: Selecting participant does not work correctly when using shift-selectionClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Communication/coordination work: Selecting participant does not work correctly when using shift-selection
Closed, ResolvedPublic
Actions