Page MenuHomePhabricator
Create Task
Maniphest T313388

Keyboard shortcut for adding an undocumented parameter often doesn't work and doesn't cause focus
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

(Linux, FF): <control>-<shift>-D should open the undocumented parameter input and focus the field. In many cases it's not doing anything. In other cases it focuses the section but the header is collapsed. In yet other cases the section is present but the input doesn't get focused.

This might (again) be a browser-specific issue. Ctrl+Shift+D is apparently "bookmark all tabs" in Firefox.

Details

SubjectRepoBranchLines +/-
Prefer adding parameter to currently focussed templatemediawiki/extensions/VisualEditormaster+32 -4
Fix filtering not clearing "currently selected page" statemediawiki/extensions/VisualEditormaster+1 -2
Move getters for the currently selected part to two-pane layoutmediawiki/extensions/VisualEditormaster+26 -33
Fix Ctrl+D and Ctrl+Shift+Y hotkeys to add partsmediawiki/extensions/VisualEditormaster+3 -1
Fix Ctrl+Shift+D hotkey to add undocumented parametersmediawiki/extensions/VisualEditormaster+5 -1
Customize query in gerrit

Event Timeline

awight created this task.Jul 20 2022, 9:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2022, 9:13 AM
thiemowmde renamed this task from Regression: keyboard shortcut for adding an undocumented parameter often doesn't work and doesn't cause focus to Keyboard shortcut for adding an undocumented parameter often doesn't work and doesn't cause focus.Jul 20 2022, 9:55 AM
thiemowmde added a project: WMDE-TechWish-Maintenance.
thiemowmde updated the task description. (Show Details)
thiemowmde claimed this task.Jul 22 2022, 1:11 PM
thiemowmde added projects: Regression, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-07-20.
thiemowmde set the point value for this task to 2.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".
gerritbot added a comment.Jul 22 2022, 1:22 PM

Change 816145 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix Ctrl+Shift+D hotkey to add undocumented parameters

https://gerrit.wikimedia.org/r/816145

gerritbot added a project: Patch-For-Review.Jul 22 2022, 1:22 PM
gerritbot added a comment.Jul 22 2022, 1:28 PM

Change 816167 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix Ctrl+D and Ctrl+Shift+Y hotkeys to add parts

https://gerrit.wikimedia.org/r/816167

gerritbot added a comment.Jul 22 2022, 1:57 PM

Change 816173 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move getters for the currently selected part to two-pane layout

https://gerrit.wikimedia.org/r/816173

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-20 board.Jul 22 2022, 1:57 PM
gerritbot added a comment.Jul 22 2022, 3:11 PM

Change 816183 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix filtering not clearing "currently selected page" state

https://gerrit.wikimedia.org/r/816183

gerritbot added a comment.Jul 25 2022, 2:45 PM

Change 816796 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [POC] Force add parameter on template that's currently focussed

https://gerrit.wikimedia.org/r/816796

gerritbot added a comment.Jul 26 2022, 9:20 AM

Change 816145 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix Ctrl+Shift+D hotkey to add undocumented parameters

https://gerrit.wikimedia.org/r/816145

gerritbot added a comment.Jul 26 2022, 9:23 AM

Change 816167 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix Ctrl+D and Ctrl+Shift+Y hotkeys to add parts

https://gerrit.wikimedia.org/r/816167

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 26 2022, 10:01 AM
lilients_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 26 2022, 12:24 PM
gerritbot added a comment.Jul 26 2022, 12:30 PM

Change 816173 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move getters for the currently selected part to two-pane layout

https://gerrit.wikimedia.org/r/816173

gerritbot added a comment.Jul 26 2022, 2:36 PM

Change 816183 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix filtering not clearing "currently selected page" state

https://gerrit.wikimedia.org/r/816183

gerritbot added a comment.Jul 28 2022, 11:34 AM

Change 816796 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Prefer adding parameter to currently focussed template

https://gerrit.wikimedia.org/r/816796

Andrew-WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-20 board.Jul 28 2022, 12:00 PM
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jul 28 2022, 3:54 PM
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Aug 8 2022, 3:38 PM
thiemowmde closed this task as Resolved.Aug 16 2022, 9:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL